Patchwork Add iPerf

login
register
mail settings
Submitter Benz Schenk
Date Oct. 18, 2016, 4:06 p.m.
Message ID <20161018180646.48bbb60d@gondolin.arda>
Download mbox | patch
Permalink /patch/16626/
State New
Headers show

Comments

Benz Schenk - Oct. 18, 2016, 4:06 p.m.
Hi

This is my first patch, it's really straight-forward.
But I'm not quite sure about the naming because there's iperf, iperf2
and iperf3 which are different projects. The original iperf is
abandoned and iperf2 is backwards compatible and still gets bug fixes
and iperf3, which this patch is for, is in active development and adds a
lot of new features but also lacks some of the options of previous
versions. Thus it's often referred to as iperf3, which is also the name
of the binary, so I'm not sure wheter the package should better be
called iperf3 or iperf.

Thanks for your feedback

Benz
Marius Bakke - Oct. 18, 2016, 9:37 p.m.
Benz Schenk <benz.schenk@uzh.ch> writes:

> Hi
>
> This is my first patch, it's really straight-forward.
> But I'm not quite sure about the naming because there's iperf, iperf2
> and iperf3 which are different projects. The original iperf is
> abandoned and iperf2 is backwards compatible and still gets bug fixes
> and iperf3, which this patch is for, is in active development and adds a
> lot of new features but also lacks some of the options of previous
> versions. Thus it's often referred to as iperf3, which is also the name
> of the binary, so I'm not sure wheter the package should better be
> called iperf3 or iperf.

Hi Benz,

Thanks for this patch! I think naming it "iperf" is fine, even though
the binary and manual is called iperf3. If we need iperf2 later it can
be packaged as "iperf@2".

I'm not sure about the home page: the manual and github page both list
http://software.es.net/iperf/ as the home. What is the relation between
iperf.fr and this project? Should we not go with the official source?

Other than that I'd like to make the following modifications. This can
be done before pushing, no need to send an updated patch:

* Change synopsis to "TCP, UDP and SCTP bandwidth measurement tool".
* Update license to match what's in the LICENSE file.
* Fix minor typos in the description (bandwith->bandwidth).
* Change commit message to match our current convention.
* Download the tarball from http://downloads.es.net/pub/iperf/

Are you okay with these changes (including the home page)?

Thanks again, and welcome! :)
Benz Schenk - Oct. 19, 2016, 12:07 a.m.
On Tue, 18 Oct 2016 22:37:40 +0100
Marius Bakke <mbakke@fastmail.com> wrote:

> Benz Schenk <benz.schenk@uzh.ch> writes:
> 
> > Hi
> >
> > This is my first patch, it's really straight-forward.
> > But I'm not quite sure about the naming because there's iperf, iperf2
> > and iperf3 which are different projects. The original iperf is
> > abandoned and iperf2 is backwards compatible and still gets bug fixes
> > and iperf3, which this patch is for, is in active development and adds a
> > lot of new features but also lacks some of the options of previous
> > versions. Thus it's often referred to as iperf3, which is also the name
> > of the binary, so I'm not sure wheter the package should better be
> > called iperf3 or iperf.  
> 
> Hi Benz,
> 
> Thanks for this patch! I think naming it "iperf" is fine, even though
> the binary and manual is called iperf3. If we need iperf2 later it can
> be packaged as "iperf@2".
> 
> I'm not sure about the home page: the manual and github page both list
> http://software.es.net/iperf/ as the home. What is the relation between
> iperf.fr and this project? Should we not go with the official source?
> 
> Other than that I'd like to make the following modifications. This can
> be done before pushing, no need to send an updated patch:
> 
> * Change synopsis to "TCP, UDP and SCTP bandwidth measurement tool".
> * Update license to match what's in the LICENSE file.
> * Fix minor typos in the description (bandwith->bandwidth).
> * Change commit message to match our current convention.
> * Download the tarball from http://downloads.es.net/pub/iperf/
> 
> Are you okay with these changes (including the home page)?
> 
> Thanks again, and welcome! :)

Sure thing, I just need the software for uni and got this homepage from
my advisor.

Thank you
Marius Bakke - Oct. 19, 2016, 12:23 p.m.
Benz Schenk <benz.schenk@uzh.ch> writes:

> On Tue, 18 Oct 2016 22:37:40 +0100
> Marius Bakke <mbakke@fastmail.com> wrote:
>
>> Benz Schenk <benz.schenk@uzh.ch> writes:
>> 
>> > Hi
>> >
>> > This is my first patch, it's really straight-forward.
>> > But I'm not quite sure about the naming because there's iperf, iperf2
>> > and iperf3 which are different projects. The original iperf is
>> > abandoned and iperf2 is backwards compatible and still gets bug fixes
>> > and iperf3, which this patch is for, is in active development and adds a
>> > lot of new features but also lacks some of the options of previous
>> > versions. Thus it's often referred to as iperf3, which is also the name
>> > of the binary, so I'm not sure wheter the package should better be
>> > called iperf3 or iperf.  
>> 
>> Hi Benz,
>> 
>> Thanks for this patch! I think naming it "iperf" is fine, even though
>> the binary and manual is called iperf3. If we need iperf2 later it can
>> be packaged as "iperf@2".
>> 
>> I'm not sure about the home page: the manual and github page both list
>> http://software.es.net/iperf/ as the home. What is the relation between
>> iperf.fr and this project? Should we not go with the official source?
>> 
>> Other than that I'd like to make the following modifications. This can
>> be done before pushing, no need to send an updated patch:
>> 
>> * Change synopsis to "TCP, UDP and SCTP bandwidth measurement tool".
>> * Update license to match what's in the LICENSE file.
>> * Fix minor typos in the description (bandwith->bandwidth).
>> * Change commit message to match our current convention.
>> * Download the tarball from http://downloads.es.net/pub/iperf/
>> 
>> Are you okay with these changes (including the home page)?
>> 
>> Thanks again, and welcome! :)
>
> Sure thing, I just need the software for uni and got this homepage from
> my advisor.

Thanks for clarifying. I've tested this and pushed it with the mentioned
changes as b747718e230eba267ae158d03d506527bfe1a67a !

Patch

From 30d1c08b2163d150994fd8dfb3e901b9f4668b46 Mon Sep 17 00:00:00 2001
From: Benz Schenk <benz.schenk@uzh.ch>
Date: Tue, 18 Oct 2016 17:28:23 +0200
Subject: [PATCH] add iperf

---
 gnu/packages/networking.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 4b77aad..459893c 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -10,6 +10,7 @@ 
 ;;; Copyright © 2016 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
 ;;; Copyright © 2016 Arun Isaac <arunisaac@systemreboot.net>
+;;; Copyright © 2016 Benz Schenk <benz.schenk@uzh.ch>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -927,3 +928,25 @@  HTTPS on port 443, allowing SSH connections from inside corporate firewalls
 that block port 22.")
     (license (list license:bsd-2        ; tls.[ch]
                    license:gpl2+))))    ; everything else
+
+(define-public iperf
+  (package
+    (name "iperf")
+    (version "3.1.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/esnet/" name
+                                  "/archive/" version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+                (base32
+                  "0lzmwqs5cqbr23gkvr835dnmghk2ws0rnfic5lra22n8zw6gck73"))))
+    (build-system gnu-build-system)
+    (synopsis "Actively measure the maximum bandwith on IP networks")
+    (description
+     "iPerf is a tool to measure achievable bandwith on IP networks.  It
+supports tuning of verious parameters related to timing, buffers and
+protocols (TCP, UDP, SCTP with IPv4 and IPv6).  For each test it reports
+the bandwith, loss, and other parameters.")
+    (home-page "http://iperf.fr")
+    (license license:expat)))
-- 
2.10.1