Patchwork gnu: Enable pam in xlock

login
register
mail settings
Submitter John Darrington
Date Oct. 17, 2016, 7:49 p.m.
Message ID <1476733783-1474-1-git-send-email-jmd@gnu.org>
Download mbox | patch
Permalink /patch/16588/
State New
Headers show

Comments

John Darrington - Oct. 17, 2016, 7:49 p.m.
* gnu/packages/xdisorg.scm (xlockmore) [arguments]: Add --enable-pam
---
 gnu/packages/xdisorg.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Ludovic Courtès - Oct. 18, 2016, 12:30 p.m.
John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/xdisorg.scm (xlockmore) [arguments]: Add --enable-pam

Subject line should start with “gnu: xlockmore:”, but otherwise LGTM!

Interestingly, I always thought PAM support was enabled and we even
populate /etc/pam.d with an entry for ‘xlock’ via the ‘screen-locker’
service.

Thanks,
Ludo’.
John Darrington - Oct. 19, 2016, 5:06 a.m.
On Tue, Oct 18, 2016 at 02:30:07PM +0200, Ludovic Court??s wrote:
     John Darrington <jmd@gnu.org> skribis:
     
     > * gnu/packages/xdisorg.scm (xlockmore) [arguments]: Add --enable-pam
     
     Subject line should start with ???gnu: xlockmore:???, but otherwise LGTM!
     
     Interestingly, I always thought PAM support was enabled and we even
     populate /etc/pam.d with an entry for ???xlock??? via the ???screen-locker???
     service.
     
Although linux-pam was declared an input, xlockmore doesn't use it unless given
a configure option.

However, xlockmore has three configure options: --enable-pam, --enable-pam-good 
and --enable-pam-bad  but none of them seem to work properly.


So I'm going to refrain from pushing this patch until I can work out what is going
on.


J'

Patch

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 323ff11..0fe9c94 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -563,7 +563,8 @@  things less distracting.")
                "138d79b8zc2hambbr9fnxp3fhihlcljgqns04zf0kv2f53pavqwl"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:configure-flags (list (string-append "--enable-appdefaultdir="
+     '(#:configure-flags (list "--enable-pam"
+                               (string-append "--enable-appdefaultdir="
                                               (assoc-ref %outputs "out")
                                               "/lib/X11/app-defaults"))
        #:tests? #f))                            ;no such thing as a test suite