Patchwork import: pypi: All inputs are propagated-inputs by default.

login
register
mail settings
Submitter Hartmut Goebel
Date Oct. 17, 2016, 9 a.m.
Message ID <1476694815-23201-1-git-send-email-h.goebel@crazy-compilers.com>
Download mbox | patch
Permalink /patch/16570/
State New
Headers show

Comments

Hartmut Goebel - Oct. 17, 2016, 9 a.m.
* guix/import/pypi.scm (maybe-inputs): Return inputs as
  "propagated-inputs".
---
 guix/import/pypi.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Hartmut Goebel - Oct. 17, 2016, 10:33 a.m.
Am 17.10.2016 um 11:00 schrieb Hartmut Goebel:
> * guix/import/pypi.scm (maybe-inputs): Return inputs as
>   "propagated-inputs".

Rational: Most python inputs need to be propagated inputs, not normal ones.
Ludovic Courtès - Oct. 18, 2016, 12:26 p.m.
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> * guix/import/pypi.scm (maybe-inputs): Return inputs as
>   "propagated-inputs".
> ---
>  guix/import/pypi.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
> index 8aeffb2..68153d5 100644
> --- a/guix/import/pypi.scm
> +++ b/guix/import/pypi.scm
> @@ -111,7 +111,7 @@ package definition."
>      (()
>       '())
>      ((package-inputs ...)
> -     `((inputs (,'quasiquote ,package-inputs))))))
> +     `((propagated-inputs (,'quasiquote ,package-inputs))))))

I think it’s the right thing to do.

Cyril, David: WDYT?

Ludo’.
Hartmut Goebel - Oct. 23, 2016, 5:24 p.m.
Am 17.10.2016 um 11:00 schrieb Hartmut Goebel:
> * guix/import/pypi.scm (maybe-inputs): Return inputs as
>   "propagated-inputs".
Applied as b5c347ad3d83ee580c111bd14c80b469b0dcb294

Patch

diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
index 8aeffb2..68153d5 100644
--- a/guix/import/pypi.scm
+++ b/guix/import/pypi.scm
@@ -111,7 +111,7 @@  package definition."
     (()
      '())
     ((package-inputs ...)
-     `((inputs (,'quasiquote ,package-inputs))))))
+     `((propagated-inputs (,'quasiquote ,package-inputs))))))
 
 (define (guess-requirements source-url wheel-url tarball)
   "Given SOURCE-URL, WHEEL-URL and a TARBALL of the package, return a list of