Patchwork gnu: Add python-whoosh.

login
register
mail settings
Submitter Ricardo Wurmus
Date Oct. 15, 2016, 1:01 p.m.
Message ID <20161015130143.5185-1-rekado@elephly.net>
Download mbox | patch
Permalink /patch/16532/
State New
Headers show

Comments

Ricardo Wurmus - Oct. 15, 2016, 1:01 p.m.
* gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables.
---
 gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
Kei Yamashita - Oct. 15, 2016, 9:05 p.m.
Ricardo Wurmus <rekado@elephly.net> writes:

> * gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables.
> ---
>  gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 6207896..69c7d36 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -8823,6 +8823,36 @@ library.")
>        (native-inputs `(("python2-setuptools" ,python2-setuptools)
>                         ,@(package-native-inputs responses))))))
>  
> +(define-public python-whoosh
> +  (package
> +    (name "python-whoosh")
> +    (version "2.7.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "Whoosh" version))
> +       (sha256
> +        (base32
> +         "10qsqdjpbc85fykc1vgcs8xwbgn4l2l52c8d83xf1q59pwyn79bw"))))
> +    (build-system python-build-system)
> +    (native-inputs
> +     `(("python-setuptools" ,python-setuptools)
> +       ("python-pytest" ,python-pytest)))
> +    (home-page "http://bitbucket.org/mchaput/whoosh")
> +    (synopsis "Full text indexing, search, and spell checking library")
> +    (description
> +     "Whoosh is a fast, pure-Python full text indexing, search, and spell
> +checking library.")
> +    (license license:bsd-2)))
> +
> +(define-public python2-whoosh
> +  (let ((whoosh (package-with-python2 (strip-python2-variant python-whoosh))))
> +    (package (inherit whoosh)
> +      (propagated-inputs
> +       `(("python2-backport-ssl-match-hostname"
> +          ,python2-backport-ssl-match-hostname)
> +          ,@(package-propagated-inputs whoosh))))))
> +
>  (define-public python-pathlib
>    (package
>      (name "python-pathlib")

Linting works fine, but outputs differ on each build. Is this a common
problem with python packages?
Marius Bakke - Oct. 15, 2016, 9:48 p.m.
Kei Kebreau <kei@openmailbox.org> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> * gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables.
>> ---
>>  gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index 6207896..69c7d36 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -8823,6 +8823,36 @@ library.")
>>        (native-inputs `(("python2-setuptools" ,python2-setuptools)
>>                         ,@(package-native-inputs responses))))))
>>  
>> +(define-public python-whoosh
>> +  (package
>> +    (name "python-whoosh")
>> +    (version "2.7.4")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "Whoosh" version))
>> +       (sha256
>> +        (base32
>> +         "10qsqdjpbc85fykc1vgcs8xwbgn4l2l52c8d83xf1q59pwyn79bw"))))
>> +    (build-system python-build-system)
>> +    (native-inputs
>> +     `(("python-setuptools" ,python-setuptools)
>> +       ("python-pytest" ,python-pytest)))
>> +    (home-page "http://bitbucket.org/mchaput/whoosh")
>> +    (synopsis "Full text indexing, search, and spell checking library")
>> +    (description
>> +     "Whoosh is a fast, pure-Python full text indexing, search, and spell
>> +checking library.")
>> +    (license license:bsd-2)))
>> +
>> +(define-public python2-whoosh
>> +  (let ((whoosh (package-with-python2 (strip-python2-variant python-whoosh))))
>> +    (package (inherit whoosh)
>> +      (propagated-inputs
>> +       `(("python2-backport-ssl-match-hostname"
>> +          ,python2-backport-ssl-match-hostname)
>> +          ,@(package-propagated-inputs whoosh))))))
>> +
>>  (define-public python-pathlib
>>    (package
>>      (name "python-pathlib")
>
> Linting works fine, but outputs differ on each build. Is this a common
> problem with python packages?

Yes, it's a common problem with python packages. This should be largely
fixed by the new python build system however.

Wrt the patch, setuptools is not required for the python3 variant. But
since it will no longer be required for python2 either after the new
build system, I think it's okay to keep it for now, since it would
complicate the patch a lot.

LGTM.
Leo Famulari - Oct. 15, 2016, 10:19 p.m.
On Sat, Oct 15, 2016 at 05:05:23PM -0400, Kei Kebreau wrote:
> Ricardo Wurmus <rekado@elephly.net> writes:
> 
> > * gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables.
> > ---
> >  gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> >
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index 6207896..69c7d36 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -8823,6 +8823,36 @@ library.")
> >        (native-inputs `(("python2-setuptools" ,python2-setuptools)
> >                         ,@(package-native-inputs responses))))))
> >  
> > +(define-public python-whoosh
> > +  (package
> > +    (name "python-whoosh")
> > +    (version "2.7.4")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (pypi-uri "Whoosh" version))
> > +       (sha256
> > +        (base32
> > +         "10qsqdjpbc85fykc1vgcs8xwbgn4l2l52c8d83xf1q59pwyn79bw"))))
> > +    (build-system python-build-system)
> > +    (native-inputs
> > +     `(("python-setuptools" ,python-setuptools)
> > +       ("python-pytest" ,python-pytest)))
> > +    (home-page "http://bitbucket.org/mchaput/whoosh")
> > +    (synopsis "Full text indexing, search, and spell checking library")
> > +    (description
> > +     "Whoosh is a fast, pure-Python full text indexing, search, and spell
> > +checking library.")
> > +    (license license:bsd-2)))
> > +
> > +(define-public python2-whoosh
> > +  (let ((whoosh (package-with-python2 (strip-python2-variant python-whoosh))))
> > +    (package (inherit whoosh)
> > +      (propagated-inputs
> > +       `(("python2-backport-ssl-match-hostname"
> > +          ,python2-backport-ssl-match-hostname)
> > +          ,@(package-propagated-inputs whoosh))))))
> > +
> >  (define-public python-pathlib
> >    (package
> >      (name "python-pathlib")
> 
> Linting works fine, but outputs differ on each build. Is this a common
> problem with python packages?

The Python 3.4.3 (what we have on master) bytecode compiler puts
timestamps in the bytecode:

https://bugs.gnu.org/22533

I think this issue will be fixed when we upgrade to Python 3.5.2.

And, IIRC, our version of Sphinx puts timestamps in man pages. This is
also fixed in more recent versions of Sphinx, again IIRC.
Ricardo Wurmus - Oct. 16, 2016, 11:15 a.m.
Kei Kebreau <kei@openmailbox.org> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> * gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables.

Thanks for the review (and for checking reproducibility).  This has been
pushed to master as b7afd01893ef2f08049810bd63784e915a8a2f9a.

~~ Ricardo

Patch

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 6207896..69c7d36 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8823,6 +8823,36 @@  library.")
       (native-inputs `(("python2-setuptools" ,python2-setuptools)
                        ,@(package-native-inputs responses))))))
 
+(define-public python-whoosh
+  (package
+    (name "python-whoosh")
+    (version "2.7.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "Whoosh" version))
+       (sha256
+        (base32
+         "10qsqdjpbc85fykc1vgcs8xwbgn4l2l52c8d83xf1q59pwyn79bw"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)
+       ("python-pytest" ,python-pytest)))
+    (home-page "http://bitbucket.org/mchaput/whoosh")
+    (synopsis "Full text indexing, search, and spell checking library")
+    (description
+     "Whoosh is a fast, pure-Python full text indexing, search, and spell
+checking library.")
+    (license license:bsd-2)))
+
+(define-public python2-whoosh
+  (let ((whoosh (package-with-python2 (strip-python2-variant python-whoosh))))
+    (package (inherit whoosh)
+      (propagated-inputs
+       `(("python2-backport-ssl-match-hostname"
+          ,python2-backport-ssl-match-hostname)
+          ,@(package-propagated-inputs whoosh))))))
+
 (define-public python-pathlib
   (package
     (name "python-pathlib")