Patchwork [4/5] gnu: python.scm: Update some home-page urls and descriptions.

login
register
mail settings
Submitter Hartmut Goebel
Date Oct. 10, 2016, 1:10 p.m.
Message ID <1476105003-29538-5-git-send-email-h.goebel@crazy-compilers.com>
Download mbox | patch
Permalink /patch/16390/
State New
Headers show

Comments

Hartmut Goebel - Oct. 10, 2016, 1:10 p.m.
* gnu/packages/python.scm (python-keyring, python-pylockfile): Update
  home-page url. (python-pathlib): Update description.
---
 gnu/packages/python.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Leo Famulari - Oct. 12, 2016, 4:01 p.m.
On Mon, Oct 10, 2016 at 03:10:02PM +0200, Hartmut Goebel wrote:
> * gnu/packages/python.scm (python-keyring, python-pylockfile): Update
>   home-page url. (python-pathlib): Update description.

This should really be separate commits :)

> ---
>  gnu/packages/python.scm | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index a289093..9b62241 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -763,7 +763,7 @@ concepts.")
>      (arguments '(#:test-target "check"))
>      (native-inputs
>       `(("python-pbr" ,python-pbr)))
> -    (home-page "http://code.google.com/p/pylockfile/")
> +    (home-page "https://launchpad.net/pylockfile")
>      (synopsis "Platform-independent file locking module")
>      (description
>       "The lockfile package exports a LockFile class which provides a simple
> @@ -900,7 +900,7 @@ etc.).  The package is structured to make adding new modules easy.")
>       `(("python-pycrypto" ,python-pycrypto)))
>      (arguments
>       `(#:tests? #f))                      ;TODO: tests require pytest
> -    (home-page "http://bitbucket.org/kang/python-keyring-lib")
> +    (home-page "https://github.com/jaraco/keyring")
>      (synopsis "Store and access your passwords safely")
>      (description
>       "The Python keyring lib provides a easy way to access the system keyring
> @@ -8852,7 +8852,10 @@ be done easily through operators, attribute accesses, and method calls.
>  comparing Windows paths ignores casing.
>  @item Well-defined semantics, eliminating any inconsistencies or
>  ambiguities (forward vs. backward slashes, etc.).
> -@end enumerate\n")
> +@end enumerate
> +
> +Note: This module isn't maintained anymore. Please consider python-pathlib2
> +instead.")

We should also point out that this module was merged into the Python
standard library in 3.4:

https://pypi.python.org/pypi/pathlib/

"In Python 3.4, pathlib is now part of the standard library. For Python
3.3 and earlier, easy_install pathlib or pip install pathlib should do
the trick."
Hartmut Goebel - Oct. 13, 2016, 8:36 a.m.
Am 12.10.2016 um 18:01 schrieb Leo Famulari:
> On Mon, Oct 10, 2016 at 03:10:02PM +0200, Hartmut Goebel wrote:
>> > * gnu/packages/python.scm (python-keyring, python-pylockfile): Update
>> >   home-page url. (python-pathlib): Update description.
> This should really be separate commits :)
>

How many? Three?
Ludovic Courtès - Oct. 13, 2016, 8:14 p.m.
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 12.10.2016 um 18:01 schrieb Leo Famulari:
>> On Mon, Oct 10, 2016 at 03:10:02PM +0200, Hartmut Goebel wrote:
>>> > * gnu/packages/python.scm (python-keyring, python-pylockfile): Update
>>> >   home-page url. (python-pathlib): Update description.
>> This should really be separate commits :)
>>
>
> How many? Three?

Yes, one patch for each logical change.  See the last item at
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>.

Thanks,
Ludo’.
Hartmut Goebel - Oct. 14, 2016, 8:03 a.m.
Am 13.10.2016 um 22:14 schrieb Ludovic Courtès:
> Yes, one patch for each logical change.  See

Fine, this is how I normally do it.

Patch

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index a289093..9b62241 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -763,7 +763,7 @@  concepts.")
     (arguments '(#:test-target "check"))
     (native-inputs
      `(("python-pbr" ,python-pbr)))
-    (home-page "http://code.google.com/p/pylockfile/")
+    (home-page "https://launchpad.net/pylockfile")
     (synopsis "Platform-independent file locking module")
     (description
      "The lockfile package exports a LockFile class which provides a simple
@@ -900,7 +900,7 @@  etc.).  The package is structured to make adding new modules easy.")
      `(("python-pycrypto" ,python-pycrypto)))
     (arguments
      `(#:tests? #f))                      ;TODO: tests require pytest
-    (home-page "http://bitbucket.org/kang/python-keyring-lib")
+    (home-page "https://github.com/jaraco/keyring")
     (synopsis "Store and access your passwords safely")
     (description
      "The Python keyring lib provides a easy way to access the system keyring
@@ -8852,7 +8852,10 @@  be done easily through operators, attribute accesses, and method calls.
 comparing Windows paths ignores casing.
 @item Well-defined semantics, eliminating any inconsistencies or
 ambiguities (forward vs. backward slashes, etc.).
-@end enumerate\n")
+@end enumerate
+
+Note: This module isn't maintained anymore. Please consider python-pathlib2
+instead.")
     (license license:expat)))
 
 (define-public python2-pathlib