Patchwork [5/5] guix: python-build-system: Fix an outdated comment.

login
register
mail settings
Submitter Hartmut Goebel
Date Oct. 10, 2016, 1:10 p.m.
Message ID <1476105003-29538-6-git-send-email-h.goebel@crazy-compilers.com>
Download mbox | patch
Permalink /patch/16389/
State New
Headers show

Comments

Hartmut Goebel - Oct. 10, 2016, 1:10 p.m.
---
 guix/build/python-build-system.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Leo Famulari - Oct. 12, 2016, 4:03 p.m.
On Mon, Oct 10, 2016 at 03:10:03PM +0200, Hartmut Goebel wrote:
> ---
>  guix/build/python-build-system.scm | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
> index 9109fb4..e906e60 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -137,8 +137,7 @@ installed with setuptools."
>      #t))
>  
>  (define %standard-phases
> -  ;; 'configure' and 'build' phases are not needed.  Everything is done during
> -  ;; 'install'.
> +  ;; 'configure' phase is not needed.

I have no real comment because I don't know the python-build-system well
enough. Is the sentence about 'install' no longer accurate?
Hartmut Goebel - Oct. 13, 2016, 7:32 a.m.
Am 12.10.2016 um 18:03 schrieb Leo Famulari:
>> >  (define %standard-phases
>> > -  ;; 'configure' and 'build' phases are not needed.  Everything is done during
>> > -  ;; 'install'.
>> > +  ;; 'configure' phase is not needed.
> I have no real comment because I don't know the python-build-system well
> enough. Is the sentence about 'install' no longer accurate?

The python-build-system uses the build and the install phase, but not
the configure phase. So the old comment was plain wrong. I assume once
only the install phase was used[*] and the comment has had been correct :-)

Which is possible and much like running "make install" without prior run
to "make".
Ludovic Courtès - Oct. 13, 2016, 8:06 p.m.
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 12.10.2016 um 18:03 schrieb Leo Famulari:
>>> >  (define %standard-phases
>>> > -  ;; 'configure' and 'build' phases are not needed.  Everything is done during
>>> > -  ;; 'install'.
>>> > +  ;; 'configure' phase is not needed.
>> I have no real comment because I don't know the python-build-system well
>> enough. Is the sentence about 'install' no longer accurate?
>
> The python-build-system uses the build and the install phase, but not
> the configure phase. So the old comment was plain wrong. I assume once
> only the install phase was used[*] and the comment has had been correct :-)
>
> Which is possible and much like running "make install" without prior run
> to "make".

Indeed, I think this has been the case since commit
b191f88ee34576a6908b9b5e94cb7664e88c7e79.

Note however that Mark reverted this patch from master because it would
have caused a rebuild of all things Python.  However feel free to apply
it to wip-python-build-system.

Thanks,
Ludo’.

Patch

diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index 9109fb4..e906e60 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -137,8 +137,7 @@  installed with setuptools."
     #t))
 
 (define %standard-phases
-  ;; 'configure' and 'build' phases are not needed.  Everything is done during
-  ;; 'install'.
+  ;; 'configure' phase is not needed.
   (modify-phases gnu:%standard-phases
     (add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-1980)
     (delete 'configure)