Patchwork gnu: lynx: Fix GnuTLS support.

login
register
mail settings
Submitter Kei Yamashita
Date Oct. 7, 2016, 12:48 a.m.
Message ID <87oa2x3rxc.fsf@openmailbox.org>
Download mbox | patch
Permalink /patch/16324/
State New
Headers show

Comments

Kei Yamashita - Oct. 7, 2016, 12:48 a.m.
HTTPS connections using lynx work on my machine with this patch. Would
someone else like to see about this?
From c18ab7b9c24f07ab86529d7f5f08f4dd21cea549 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Thu, 6 Oct 2016 20:38:39 -0400
Subject: [PATCH] gnu: lynx: Fix GnuTLS support.

* gnu/packages/lynx.scm (lynx)[arguments]: Pass "--with-gnutls" in
---
 gnu/packages/lynx.scm | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)
Leo Famulari - Oct. 7, 2016, 1:28 a.m.
On Thu, Oct 06, 2016 at 08:48:31PM -0400, Kei Kebreau wrote:
> HTTPS connections using lynx work on my machine with this patch. Would
> someone else like to see about this?

Thanks for working on this!

It still fails for me, but in a different way than before [0]:

-----
$ lynx https://famulari.name                   

Looking up famulari.name
Making HTTPS connection to famulari.name
Retrying connection without TLS.
Looking up famulari.name
Making HTTPS connection to famulari.name
Alert!: Unable to make secure connection to remote host.

lynx: Can't access startfile https://famulari.name/
-----

I assume that I'm missing some environment variable on this Guix /
Debian system. Any ideas?

If it works for you, I'd say go for it.

> From c18ab7b9c24f07ab86529d7f5f08f4dd21cea549 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Thu, 6 Oct 2016 20:38:39 -0400
> Subject: [PATCH] gnu: lynx: Fix GnuTLS support.
> 
> * gnu/packages/lynx.scm (lynx)[arguments]: Pass "--with-gnutls" in

I think this commit message is truncated.

[0] Without this patch, lynx says:
Alert!: This client does not contain support for HTTPS URLs.
Tobias Geerinckx-Rice - Oct. 7, 2016, 1:56 a.m.
Kei,

On 07/10/16 03:28, Leo Famulari wrote:
> On Thu, Oct 06, 2016 at 08:48:31PM -0400, Kei Kebreau wrote:
>> HTTPS connections using lynx work on my machine with this patch. Would
>> someone else like to see about this?
> 
> Thanks for working on this!

+1!

On 07/10/16 03:28, Leo Famulari wrote:
> It still fails for me, but in a different way than before:
> $ lynx https://famulari.name

On my pure GuixSD machine,

  $ lynx https://tobias.gr

suffers the same fate. Interestingly,

  $ lynx https://google.com

works just fin— Wait a minute, this all sounds terribly familiar.

https://lists.gnu.org/archive/html/guix-devel/2016-03/msg00135.html

I gave up at this point, as Guix was new and scary and my need for Lynx
vanished anyway. It looks like there might some Lynx-specific quirks
involved as well (e.g. ‘--with-gnutls=’ sufficing, at least back then).

Kind regards/good luck,

T G-R
Tobias Geerinckx-Rice - Oct. 7, 2016, 2:02 a.m.
On 07/10/16 03:56, Tobias Geerinckx-Rice wrote:
> Interestingly,
> 
>   $ lynx https://google.com
> 
> works just fin—

(In the interest of balance,

  $ lynx https://duckduckgo.com

works just fin– as well.)

Kind regards,

T G-R
ng0 - Oct. 7, 2016, 6:27 a.m.
Tobias Geerinckx-Rice <me@tobias.gr> writes:

> [ Unknown signature status ]
> On 07/10/16 03:56, Tobias Geerinckx-Rice wrote:
>> Interestingly,
>> 
>>   $ lynx https://google.com
>> 
>> works just fin—
>
> (In the interest of balance,
>
>   $ lynx https://duckduckgo.com
>
> works just fin– as well.)
>
> Kind regards,
>
> T G-R
>

Without knowing all the history of this bug, could it be related to the
curl problem (which currently keeps my darcs, pbpst, and probably
something else from getting into master)? Do we need some environment
variable to pass or work into lynx to make it work for us? or patch lynx
at its source?

Patch

diff --git a/gnu/packages/lynx.scm b/gnu/packages/lynx.scm
index 3182b3e..71bed77 100644
--- a/gnu/packages/lynx.scm
+++ b/gnu/packages/lynx.scm
@@ -53,19 +53,21 @@ 
               ("gzip" ,gzip)
               ("bzip2" ,bzip2)))
     (arguments
-     `(#:configure-flags '("--with-pkg-config"
-                           "--with-screen=ncurses"
-                           "--with-zlib"
-                           "--with-bzlib"
-                           "--with-gnutls"
-                           ;; "--with-socks5"    ; XXX TODO
-                           "--enable-widec"
-                           "--enable-ascii-ctypes"
-                           "--enable-local-docs"
-                           "--enable-htmlized-cfg"
-                           "--enable-gzip-help"
-                           "--enable-nls"
-                           "--enable-ipv6")
+     `(#:configure-flags
+       (let ((gnutls (assoc-ref %build-inputs "gnutls")))
+         `("--with-pkg-config"
+           "--with-screen=ncurses"
+           "--with-zlib"
+           "--with-bzlib"
+           ,(string-append "--with-gnutls=" gnutls)
+           ;; "--with-socks5"    ; XXX TODO
+           "--enable-widec"
+           "--enable-ascii-ctypes"
+           "--enable-local-docs"
+           "--enable-htmlized-cfg"
+           "--enable-gzip-help"
+           "--enable-nls"
+           "--enable-ipv6"))
        #:tests? #f  ; no check target
        #:phases (alist-replace
                  'install