[RFA,3/3] PR remote/20655 - small fix in handle_tracepoint_bkpts

Message ID 1475531646-18049-4-git-send-email-tom@tromey.com
State New, archived
Headers

Commit Message

Tom Tromey Oct. 3, 2016, 9:54 p.m. UTC
  handle_tracepoint_bkpts has two parallel "if"s.  This changes the
second one to check ipa_error_tracepoint, which seems to be what was
intended.

2016-10-03  Tom Tromey  <tom@tromey.com>

	PR remote/20655:
	* tracepoint.c (handle_tracepoint_bkpts): Check
	ipa_error_tracepoint, not ipa_stopping_tracepoint.
---
 gdb/gdbserver/ChangeLog    | 6 ++++++
 gdb/gdbserver/tracepoint.c | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)
  

Comments

Yao Qi Oct. 4, 2016, 12:53 p.m. UTC | #1
On Mon, Oct 3, 2016 at 10:54 PM, Tom Tromey <tom@tromey.com> wrote:
> handle_tracepoint_bkpts has two parallel "if"s.  This changes the
> second one to check ipa_error_tracepoint, which seems to be what was
> intended.
>
> 2016-10-03  Tom Tromey  <tom@tromey.com>
>
>         PR remote/20655:
>         * tracepoint.c (handle_tracepoint_bkpts): Check
>         ipa_error_tracepoint, not ipa_stopping_tracepoint.

Patch is good to me.
  

Patch

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 5c2cca9..afb0f78 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,9 @@ 
+2016-10-03  Tom Tromey  <tom@tromey.com>
+
+	PR remote/20655:
+	* tracepoint.c (handle_tracepoint_bkpts): Check
+	ipa_error_tracepoint, not ipa_stopping_tracepoint.
+
 2016-09-30  Yao Qi  <yao.qi@linaro.org>
 
 	PR gdbserver/20627
diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c
index c07e525..7700ad1 100644
--- a/gdb/gdbserver/tracepoint.c
+++ b/gdb/gdbserver/tracepoint.c
@@ -4534,7 +4534,7 @@  handle_tracepoint_bkpts (struct thread_info *tinfo, CORE_ADDR stop_pc)
 	    trace_debug ("lib stopped due to full buffer.");
 	  if (ipa_stopping_tracepoint)
 	    trace_debug ("lib stopped due to tpoint");
-	  if (ipa_stopping_tracepoint)
+	  if (ipa_error_tracepoint)
 	    trace_debug ("lib stopped due to error");
 	}