Patchwork [v2] python-lzo + python-lz4

login
register
mail settings
Submitter ng0
Date Sept. 24, 2016, 8:22 p.m.
Message ID <87y42hrqtz.fsf@we.make.ritual.n0.is>
Download mbox | patch
Permalink /patch/15980/
State New
Headers show

Comments

ng0 - Sept. 24, 2016, 8:22 p.m.
Danny Milosavljevic <dannym@scratchpost.org> writes:

Okay, there was one character which I did miss. this fixed it. Here's
the updated patch including the python2 variant, which yours did not
have.
Danny Milosavljevic - Sept. 24, 2016, 8:45 p.m.
On Sat, 24 Sep 2016 20:22:00 +0000
ngillmann@runbox.com wrote:

> Danny Milosavljevic <dannym@scratchpost.org> writes:
> 
> Okay, there was one character which I did miss. this fixed it. Here's
> the updated patch including the python2 variant, which yours did not
> have.

Right.

Your new patch is missing imports for the function pypi-uri. I think it's (guix build-system python).
ng0 - Sept. 24, 2016, 9:12 p.m.
Danny Milosavljevic <dannym@scratchpost.org> writes:

> On Sat, 24 Sep 2016 20:22:00 +0000
> ngillmann@runbox.com wrote:
>
>> Danny Milosavljevic <dannym@scratchpost.org> writes:
>> 
>> Okay, there was one character which I did miss. this fixed it. Here's
>> the updated patch including the python2 variant, which yours did not
>> have.
>
> Right.
>
> Your new patch is missing imports for the function pypi-uri. I think it's (guix build-system python).
>
No, it is not. lzo was number 2 in the original patch couple  and is
still intended to be applied as such.
Danny Milosavljevic - Sept. 24, 2016, 9:28 p.m.
> No, it is not. lzo was number 2 in the original patch couple  and is
> still intended to be applied as such.

I see what you mean but I really doubt that patchwork can see it (also because of the subject it probably will replace the entire set by just this package).
ng0 - Sept. 24, 2016, 9:48 p.m.
Danny Milosavljevic <dannym@scratchpost.org> writes:

>> No, it is not. lzo was number 2 in the original patch couple  and is
>> still intended to be applied as such.
>
> I see what you mean but I really doubt that patchwork can see it (also because of the subject it probably will replace the entire set by just this package).
>
Okay, I understand but won't send it again.
I used patchwork for a while, and looking at the past discussions about
alternatives and looking at how much functionality it lacks and almost
no one except ludovic, myself and maybe 2 more people seemed to use
it. So I don't care about patchworks as it is broken. Whoever applies my
patches uses email, no need to adjust my work to a broken tool we
started to test.

Good night

Patch

From 21672f816d1d685a18f1c4bd9d4a6e0766655a66 Mon Sep 17 00:00:00 2001
From: ng0 <ngillmann@runbox.com>
Date: Thu, 22 Sep 2016 00:08:21 +0000
Subject: [PATCH] gnu: Add python-lzo.

* gnu/packages/compression.scm (python-lzo): New variable.

Co-authored-by: Danny Milosavljevic <dannym@scratchpost.org>
---
 gnu/packages/compression.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index b1d5338..50859ff 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -364,6 +364,46 @@  LZO is written in ANSI C.  Both the source code and the compressed data
 format are designed to be portable across platforms.")
     (license license:gpl2+)))
 
+(define-public python-lzo
+  (package
+    (name "python-lzo")
+    (version "1.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "python-lzo" version))
+       (sha256
+        (base32
+         "11p3ifg14p086byhhin6azx5svlkg8dzw2b5abixik97xd6fm81q"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:test-target "check"
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-setuppy
+           (lambda _
+             (substitute* "setup.py"
+               (("include_dirs.append.*")
+                (string-append "include_dirs.append(\""
+                               (assoc-ref %build-inputs "lzo") "/include/lzo" "\")
+"))))))))
+    (inputs
+     `(("lzo" ,lzo)))
+    (home-page "https://github.com/jd-boyd/python-lzo")
+    (synopsis "Python bindings for the LZO data compression library")
+    (description
+     "Python-LZO provides Python bindings for LZO, i.e. you can access
+the LZO library from your Python scripts thereby compressing ordinary
+Python strings.")
+    (license license:gpl2+)))
+
+(define-public python2-lzo
+  (package
+    (inherit (package-with-python2
+              (strip-python2-variant python-lzo)))
+    (native-inputs
+     `(("python2-setuptools" ,python2-setuptools)))))
+
 (define-public lzop
   (package
     (name "lzop")
-- 
2.10.0