[4/6] Installed-header hygiene (BZ#20366): stack_t.

Message ID CAKCAbMiWVmhARt2VSOH1ahx5XRAiNa6L-NEBd8YHDbKGuf1cZA@mail.gmail.com
State Superseded
Headers

Commit Message

Zack Weinberg Sept. 24, 2016, 7:22 p.m. UTC
  On Sat, Sep 24, 2016 at 10:33 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> I'm getting a build failure on s390x:
> <https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc/s/s390x>

Looks like s390/sys/ucontext.h had a quirk that I accidentally zapped.
Please try the following patch, which does *not* put the quirk back,
it brings this header in line with the others:


zw
  

Comments

Andreas Schwab Sept. 26, 2016, 10:26 a.m. UTC | #1
On Sep 24 2016, Zack Weinberg <zackw@panix.com> wrote:

> On Sat, Sep 24, 2016 at 10:33 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> I'm getting a build failure on s390x:
>> <https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc/s/s390x>
>
> Looks like s390/sys/ucontext.h had a quirk that I accidentally zapped.
> Please try the following patch, which does *not* put the quirk back,
> it brings this header in line with the others:

Looks ok now.

Andreas.
  
Zack Weinberg Sept. 28, 2016, 11:32 a.m. UTC | #2
On 09/26/2016 06:26 AM, Andreas Schwab wrote:
> On Sep 24 2016, Zack Weinberg <zackw@panix.com> wrote:
> 
>> On Sat, Sep 24, 2016 at 10:33 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>> I'm getting a build failure on s390x:
>>> <https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc/s/s390x>
>>
>> Looks like s390/sys/ucontext.h had a quirk that I accidentally zapped.
>> Please try the following patch, which does *not* put the quirk back,
>> it brings this header in line with the others:
> 
> Looks ok now.

Thanks for testing, I've committed that.

zw
  

Patch

--- a/sysdeps/unix/sysv/linux/s390/sys/ucontext.h
+++ b/sysdeps/unix/sysv/linux/s390/sys/ucontext.h
@@ -74,14 +74,14 @@  typedef struct
   } mcontext_t;

 /* Userlevel context.  */
-struct ucontext
+typedef struct ucontext
   {
     unsigned long int uc_flags;
     struct ucontext *uc_link;
     stack_t uc_stack;
     mcontext_t uc_mcontext;
     __sigset_t uc_sigmask;
-  };
+  } ucontext_t;


 #endif /* sys/ucontext.h */