diff mbox

Check the right proc name

Message ID 1474472423-20278-1-git-send-email-yao.qi@linaro.org
State New, archived
Headers

Commit Message

Yao Qi Sept. 21, 2016, 3:40 p.m. UTC 
  In lib/gdbserver-support.exp, we rename gdb_exit to
gdbserver_orig_gdb_exit, but we check the existence gdbserver_gdb_exit.
We should check gdbserver_orig_gdb_exit instead.  Looks it is a typo
or an oversight.

gdb/testsuite:

2016-09-21  Yao Qi  <yao.qi@linaro.org>

	* lib/gdbserver-support.exp: Check the existence of
	gdbserver_orig_gdb_exit rather than gdbserver_gdb_exit.
---
 gdb/testsuite/lib/gdbserver-support.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pedro Alves Sept. 21, 2016, 3:52 p.m. UTC | #1 
On 09/21/2016 04:40 PM, Yao Qi wrote:
> In lib/gdbserver-support.exp, we rename gdb_exit to
> gdbserver_orig_gdb_exit, but we check the existence gdbserver_gdb_exit.
> We should check gdbserver_orig_gdb_exit instead.  Looks it is a typo
> or an oversight.

Definitely.  OK.

Thanks,
Pedro Alves
Yao Qi Sept. 22, 2016, 9:05 a.m. UTC | #2 
On Wed, Sep 21, 2016 at 4:52 PM, Pedro Alves <palves@redhat.com> wrote:
>
> Definitely.  OK.
>

Patch is pushed in.
diff mbox

Patch

diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp
index c0f17cd..70c8a5f 100644
--- a/gdb/testsuite/lib/gdbserver-support.exp
+++ b/gdb/testsuite/lib/gdbserver-support.exp
@@ -358,7 +358,7 @@  proc close_gdbserver {} {
 
 # Hook into GDB exit, and close GDBserver.
 
-if { [info procs gdbserver_gdb_exit] == "" } {
+if { [info procs gdbserver_orig_gdb_exit] == "" } {
     rename gdb_exit gdbserver_orig_gdb_exit
 }
 proc gdb_exit {} {