Message ID | 1473424150-6407-1-git-send-email-ynorov@caviumnetworks.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 83089 invoked by alias); 9 Sep 2016 12:29:37 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 82915 invoked by uid 89); 9 Sep 2016 12:29:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, T_FILL_THIS_FORM_SHORT autolearn=ham version=3.3.2 spammy=H*r:sk:NAM02-C, H*r:104.47.37, H*r:sk:mail-cy X-HELO: NAM02-CY1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; From: Yury Norov <ynorov@caviumnetworks.com> To: <libc-alpha@sourceware.org> CC: Yury Norov <ynorov@caviumnetworks.com> Subject: [PATCH] fxstatat: fix __fxstatat64 symbol generation Date: Fri, 9 Sep 2016 15:29:10 +0300 Message-ID: <1473424150-6407-1-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM3PR03CA038.eurprd03.prod.outlook.com (10.141.191.166) To BN4PR07MB2241.namprd07.prod.outlook.com (10.164.63.147) X-MS-Office365-Filtering-Correlation-Id: 5451faa9-9d77-43ff-769f-08d3d8acee37 X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2241; 2:E7zmp0SUlidds34GKBtsx/g+Ihfq4P1FBmkSLPhZuYLH8G76uOIzQw1BSIwELEkit6f0xXzomVvQfN5qgK+QbIirih6Muq4gKCflxR8WOKsAaLdec/UwgLvXuY2fDZYXHzVYwbc5K846PKzNDwuZFLHP2qG7Ezcoy7aWhO5/PzzVmvUxRtutzIp/YihehbCh; 3:sAdYTVc9WAuytkQb3pLOzCGCcajhn6xeGEvaBPyICmNb2Uu7vb7+WZgKY+aX89W9HTeHLF8Uo9bVIFAmVD0KL+ZNyClqBudQF1julrytV4XTKiUVQWcs37rdVnh0hTuX; 25:HSssOUJkidi/OZC2Rn4gqU1He5vFwprSSAWQFUAc2+zWtSGZdgfL5qRNPfV4OmFrUSavgfiVf3zcGjv/AdOncqJotBKRpOxP/6A/HswhEqP3aMH67UhBwsMmQjtHhOdIfJ85Z/MzGAFo2U1omo34tmNORAlqNmmzSqajYhw4xh6DEs97RGpYpK1BslqpNPMKFrPXO4M3yNkR1SIJn2MbS4NX+ENyq7HC4EOsvbi5pPHmC7gZcej920654CTDgIY1SomKZpJZN6kTA7SrDe+LxvUvNtLYeWEAlKFPHPs1NsAFcXpIzkNCZnhxoEu0MLAptSI00Uv1aagm5KaBFlt//SV7rzEFOwenSeS6CMzIx9+gtCEIzzlAqFFpVb1nGau4kDaJSqZeNs13iTghbK7XvicB4PoC3tAMj7WewvMxIFo= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2241; X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2241; 31:xzrP0sANF6vKbEsCAhoapl9wKLLCemJdwmjsDPGYEriIyaEqMNkyv8z3PdIyA8OFfQeeIlJTQSbhsTRr4BXfJTkgAA5Lp4UGBAr29H7rqvuoyQJgSgGnWfBZODciWtSHBvsQK+xK2Rhvuw4kxRm83Q3xJ98j90s5VDnZU3ZKdHnolkGQJusszROAroaAjp9OfpwT1ZoqBPeGi7ayzd8KRm3haM76lLuJXajMLaLuOBY=; 20:KzufMRfdm+wBKlDbPg4SAqj7gwuTHGPDYx6buZT+q+5pcRFMLboG+hL13SPWhc/8jHo3pcJ/MzMSVjJHQ8BUJD2psiyKDLGrw6N72bVHJ9XUqx74qrwswCS3dFjZACz0JMyH6qQGdw9tzcPfA414kRnSbthJsMfBXqqBQvFbDMwbj5UuceoG/d0cAGmJVBJSsTC3E7pABVSbVvaX4rB8+XapzUS8xnwJEy5fuwkWNAP8H/Mrt/7bj5O5afAtaMB5FX8uatlhiZCPAfMmAk8If6ENvYaD9a6p3JOfk7VvVkaSSO05FtUQHbfdeLqFLduu9uOrcFTsQbpt3K/UYXH7auoCp/BZVsfmmas5kVCDSdePSwlgP1tUWCRLViZ85Mnle3QlmRk7YhZRf/EfbYN0LgK3cSiXWOd645t6xz+JcnIzQBrSGZoY7gVGtoNEEdIjrsvBJenmL00GiuQuRQtsZe5gb/gRzaCCiJA/4dXCXbBlWMsoFWt8lF9D1oye/kv1//jpPooETOjtkdbNqYk7FhrWiMppvZ3itCMXDlqlByDS1i6YnEZXK3Aj8C0jHZvW88FLbFe7z4JO/PKIVUfmhEYCAEqLAv2Ro0EwywR7zqQ= X-Microsoft-Antispam-PRVS: <BN4PR07MB22411C5F3520BE8B04C95130EEFA0@BN4PR07MB2241.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BN4PR07MB2241; BCL:0; PCL:0; RULEID:; SRVR:BN4PR07MB2241; X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2241; 4:8Jx3e6QeHFkEfQwd35aA6FTCLRuTLgLTiae5CmrQ/VoPAKzAuR3sn74yG5bjs4dFzFm1ks6OTgSZkG4GF3/XJyZQcde8Sjl2ooQeV52ih2TVqdGGMwcL4ZiLKeT1VTqrJVd/qxl9+BcQH9WZMnWlRWX9IALcg4OozClx2kk8FYjAyHF07bGbIVUuyFfxRqsm+37J1PPwOijJTK0QoKQqYms84oj/AzsGlaBsLxtTAWzQTnprHbJkcEErrcf4Pm8v+ALHtH8dk++I6IsZM/E3hjgUdDZ+7iCUIVroqil2mVHDXwOhQTT3WMpgtnxu3MJnckq+dElHGQOC7KqbcKSl4kcLcr+DPDCx5kT19fylCPzj2hB2e2jlQr6UKqKdaK/L2z2eO+l6F9k04VhfzZgg9Q== X-Forefront-PRVS: 00603B7EEF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(199003)(377424004)(189002)(2351001)(229853001)(42186005)(106356001)(586003)(105586002)(77096005)(6116002)(33646002)(4001430100002)(4326007)(189998001)(66066001)(19580395003)(2870700001)(92566002)(19580405001)(97736004)(3846002)(47776003)(110136002)(50226002)(107886002)(76506005)(7846002)(50986999)(305945005)(5660300001)(101416001)(8676002)(50466002)(81166006)(36756003)(23676002)(2906002)(7736002)(5820100001)(68736007)(450100001)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:BN4PR07MB2241; H:localhost; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjRQUjA3TUIyMjQxOzIzOnRBVkRoS3g3REx2UzJmZlJkVnY2bnl2ZUV0?= =?utf-8?B?cDJjZ2Q5UU1HMEdqdHVUUWJ2MlJodk5mL1pLTHRJbTdnY3NuMVhFeGcrbktk?= =?utf-8?B?Qk5TN3dZU29vTUlnSzdEc2FrL05PaDllcE5tUGc0MUVVYS9kNGFyMUkwQXoy?= =?utf-8?B?KzJmSGdZajd3Vk9Ham5WeDlTRTJTaVU0RElGWXhydG5SR0QwK3hVQUhXNkpB?= =?utf-8?B?TVBvZGpDM1RVOWI0Y3FwYk94bGRncFZ5bnpZS2tyVVkyVlNxU20vdDlxekhO?= =?utf-8?B?bTU2bndLbEx6TVlQSnowL0I2cDhaT1cxanZZakdvL2gybHFMeDdNMktqdmlN?= =?utf-8?B?ZWE1Q3RzSlZRK0ZrV3BFV0xReUM0ekhFdk9JbXU0QzV5c2tmR3BqcGdJOWIv?= =?utf-8?B?WkoxUW5zQkdFZnd4djB3aWJybUw0Z25BRzIzUHpxdUtONFVOcGU5Vk1kYVJ3?= =?utf-8?B?TVRUcFo2L1Z5RlJqQnYxL2dUcFJJbjNJWkFub3NrMEp6WGpOVDZSZGR0TkhD?= =?utf-8?B?TnlDVWJWUnpIWVhodFg0SllYQ2hSamorT2w5T0pQN3MzMEJ6bE1jUDNuSmgw?= =?utf-8?B?L2wzN2Z2WEVveElLMjcydU9oTG9OWEs3UUhWSjB5S053cWtJYVJ1M3BYemVv?= =?utf-8?B?UHkrekF3MEVOUEhveGRmQngwdkdOZTVMYlp6a3JzMTFGZzIwd05SVTBNNkpD?= =?utf-8?B?cWpHUUY4Y1VFSUtNMFZoWmRLVFQzemUrNktMY041ZFl0c2F3d2FoWDdJNndk?= =?utf-8?B?ZG41bmlJYXJhSDFEemJsRnRPU1RRdTA5WmNBUE52M3lzY1VhcHR1VDZLY1Qw?= =?utf-8?B?NC9Hc2VUOWJ3L3FQU1llQU16eVRsNXVaUjVkd20wbjJtM3FGdzlsanlxb3gw?= =?utf-8?B?WS9IMFVaYUNONUlVMyt1aktkbGpKWGsvcnhLaUdPcTg5WGlvSXo5WWRwVGdS?= =?utf-8?B?SVhnR1RoeDM4TE1Sc2pqcFhxUS9xTGtpTEZJZ0hMb1NvdGI3OFFQQjFERjE4?= =?utf-8?B?RDFOWjFzMXl0M0RQQTUrWG12VnhHQnZFMGJScHYzZEE5R3JwUGpmZ0haaXps?= =?utf-8?B?bUplRVBKc3NGMmhia3hkdC9mVnQ5dVlBUjBzbGx2VDVTVy9NaFdjdFZIS1E5?= =?utf-8?B?QmxZSzlXZzB6blUrRmFOOTduRU9CWkNSRzZqNGpEWHV2bWtOMlFOSC9BYThu?= =?utf-8?B?UHYrQWkxcGlsTEZ0VGdCdTVlMEFpZVdTc3BsUVpEWk9oWlZjd1RpOXVtMnlH?= =?utf-8?B?VksxVnR2N2VEbmplc0l3d0tHT0wxK3c3alJ4UWtDUWZJdWRDTG0xSG1rS3Iw?= =?utf-8?B?bXZqbFVSVWY1UElYRmtROVphdzZObG5CYnpCSm4wSEdPd3I2bjd5dTJuNVQ3?= =?utf-8?B?SUhZdW5YcWNvVEcyVisyMlJiVmRmb0xnK3EwVUN3cEE3VFpJVkxaek5STkhR?= =?utf-8?B?am5DL2psUG1qb2J5cVZMbVpnOThUZk5QQmFEazViOHZpaWxPTnlMSW9lb2l1?= =?utf-8?B?K1dvOStTYlBOUzF3SHJJOXl6Mlh4a2dTQi9WMVYwMWhFTWhXT1piNFR5SE01?= =?utf-8?Q?PQf/hJAbNpU70xyK0T4SfkZyyhmU9b5zLn8e1gFie3dk=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2241; 6:4ZyXsgLzGZTCSedBMVaZNw5/BhS50/UiZ9yWvx75Ax+uLNzhPh3ZlScaAzLmCHU7/ooJFQYBGve2/g4q4Rd2S3sCt5sY+MzR+l4qNgG0N6O5qvjmCyTuuIt6zErIBI1G9hDp2Ir8Lt7Fd0dLs1fhBmEUx5czOC9IMJy799Ogzco6CFrilDupFyTLJDbM1LMg5poZHQnLgJshbH+890JiL3npFZLN3T6wOe7sb+RA5nXYr7EwGzuX338182Bjickh/jtyhiodTtuL4NP2PJbMrYtw0wDWkjtZYt6w1Fy1hi4=; 5:bsBcy5xPIctMhVbuUNqkhh0vT0o3XgAmWUlSpUPXB185e7jHqBFXpyH5HO8AeBJaTn+iPXxAr1DnL9mvFkXGOS1/E46ZhtvACDC62QaAVI601lVU2dKaeNeIxvBIpt2+djOglu7jsC4wS7F3Fgi3Vg==; 24:nvy0/oxWVi57XzUbjM1rXzFakGnDhoAYIl66Dx4jRneYM+3x8S/iyflDWAZj8ZZ1QsmRSts5/oY+a6jtYezQRO0yyyGXDNy2JTsH0TUrD9M=; 7:cbkJ0igywZWzdnDCOJXcF2OIpyHkge2E8IqTUH07dc4DxjYlaRUA8h4UK9qC4hGpR/18De4v0eMalD2PB4BDPnGpL+l9tHRReNDcXFo/rhBgNRZ8nJeWhHyr5l5i1Zko2DwKTS3xXKXOWV09l/WdplMVdm6a9AjBwPnMOe9b2KZwMLn2l/rm0qbW8hTOTC9Zb3HM+Lsr4DCOT4+IlRSQdICZW6Hj8QNkanq0asMebk4ujCAnwlz0On4johhsCh0d SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2016 12:29:22.8856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2241 |
Commit Message
Yury Norov
Sept. 9, 2016, 12:29 p.m. UTC
__fxstatat64 is defined with hidden_def, if XSTAT_IS_XSTAT64 is
enabled. It causes compile-time error. This patch fixes it.
GCC error:
In file included from <command-line>:0:0:
./../include/libc-symbols.h:432:26: error: ‘__EI___fxstatat64’ aliased to undefined symbol ‘__GI___fxstatat64’
extern __typeof (name) __EI_##name \
^
./../include/libc-symbols.h:436:29: note: in expansion of macro ‘__hidden_ver1’
# define hidden_def(name) __hidden_ver1(__GI_##name, name, name);
^
./../include/libc-symbols.h:487:32: note: in expansion of macro ‘hidden_def’
# define libc_hidden_def(name) hidden_def (name)
^
../sysdeps/unix/sysv/linux/fxstatat.c:64:1: note: in expansion of macro ‘libc_hidden_def’
libc_hidden_def (__fxstatat64)
^
2016-09-09 Yury Norov <ynorov@caviumnetworks.com>
* sysdeps/unix/sysv/linux/fxstatat.c: fix __fxstatat64
symmbol generation
Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
---
sysdeps/unix/sysv/linux/fxstatat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Sep 09 2016, Yury Norov <ynorov@caviumnetworks.com> wrote: > diff --git a/sysdeps/unix/sysv/linux/fxstatat.c b/sysdeps/unix/sysv/linux/fxstatat.c > index f716bf3..32959e5 100644 > --- a/sysdeps/unix/sysv/linux/fxstatat.c > +++ b/sysdeps/unix/sysv/linux/fxstatat.c > @@ -61,5 +61,5 @@ libc_hidden_def (__fxstatat) > #ifdef XSTAT_IS_XSTAT64 > # undef __fxstatat64 > strong_alias (__fxstatat, __fxstatat64); > -libc_hidden_def (__fxstatat64) > +libc_hidden_ver (__fxstatat, __fxstatat64) libc_hidden_ver doesn't make sense, as __fxstatat64 isn't a versioned symbol. The real problem is that the hidden_proto for __fxstatat64 is suppressed. Andreas.
On Fri, Sep 09, 2016 at 04:16:44PM +0200, Andreas Schwab wrote: > On Sep 09 2016, Yury Norov <ynorov@caviumnetworks.com> wrote: > > > diff --git a/sysdeps/unix/sysv/linux/fxstatat.c b/sysdeps/unix/sysv/linux/fxstatat.c > > index f716bf3..32959e5 100644 > > --- a/sysdeps/unix/sysv/linux/fxstatat.c > > +++ b/sysdeps/unix/sysv/linux/fxstatat.c > > @@ -61,5 +61,5 @@ libc_hidden_def (__fxstatat) > > #ifdef XSTAT_IS_XSTAT64 > > # undef __fxstatat64 > > strong_alias (__fxstatat, __fxstatat64); > > -libc_hidden_def (__fxstatat64) > > +libc_hidden_ver (__fxstatat, __fxstatat64) > > libc_hidden_ver doesn't make sense, as __fxstatat64 isn't a versioned > symbol. The real problem is that the hidden_proto for __fxstatat64 is > suppressed. > > Andreas. Maybe. I'm not too experienced in glibc versioning. And what the correct fix for it? Yury.
On Sep 09 2016, Yury Norov <ynorov@caviumnetworks.com> wrote: > On Fri, Sep 09, 2016 at 04:16:44PM +0200, Andreas Schwab wrote: >> On Sep 09 2016, Yury Norov <ynorov@caviumnetworks.com> wrote: >> >> > diff --git a/sysdeps/unix/sysv/linux/fxstatat.c b/sysdeps/unix/sysv/linux/fxstatat.c >> > index f716bf3..32959e5 100644 >> > --- a/sysdeps/unix/sysv/linux/fxstatat.c >> > +++ b/sysdeps/unix/sysv/linux/fxstatat.c >> > @@ -61,5 +61,5 @@ libc_hidden_def (__fxstatat) >> > #ifdef XSTAT_IS_XSTAT64 >> > # undef __fxstatat64 >> > strong_alias (__fxstatat, __fxstatat64); >> > -libc_hidden_def (__fxstatat64) >> > +libc_hidden_ver (__fxstatat, __fxstatat64) >> >> libc_hidden_ver doesn't make sense, as __fxstatat64 isn't a versioned >> symbol. The real problem is that the hidden_proto for __fxstatat64 is >> suppressed. >> >> Andreas. > > Maybe. I'm not too experienced in glibc versioning. And what the > correct fix for it? Reinstate the hidden_proto, but with a non-conflicting definition. Andreas.
diff --git a/sysdeps/unix/sysv/linux/fxstatat.c b/sysdeps/unix/sysv/linux/fxstatat.c index f716bf3..32959e5 100644 --- a/sysdeps/unix/sysv/linux/fxstatat.c +++ b/sysdeps/unix/sysv/linux/fxstatat.c @@ -61,5 +61,5 @@ libc_hidden_def (__fxstatat) #ifdef XSTAT_IS_XSTAT64 # undef __fxstatat64 strong_alias (__fxstatat, __fxstatat64); -libc_hidden_def (__fxstatat64) +libc_hidden_ver (__fxstatat, __fxstatat64) #endif