Patchwork [v2] gnu: Add mtd-utils.

login
register
mail settings
Submitter Leo Famulari
Date Sept. 6, 2016, 9:49 p.m.
Message ID <20160906214941.GA28845@jasmine>
Download mbox | patch
Permalink /patch/15364/
State New
Headers show

Comments

Leo Famulari - Sept. 6, 2016, 9:49 p.m.
On Thu, Sep 01, 2016 at 02:33:57PM +0200, Danny Milosavljevic wrote:
> gnu: Add mtd-utils.
> 
> * gnu/packages/linux.scm (mtd-utils): New variable.

Thanks for this patch!

I made some adjustments, as attached.

I imported the acl module, used #:make-flags to set PREFIX, and made a
minor adjustment to the description.

What do you think?
From dd00ffc45982b393cb458445e875188baf77175f Mon Sep 17 00:00:00 2001
From: Danny Milosavljevic <dannym@scratchpost.org>
Date: Thu, 1 Sep 2016 14:33:57 +0200
Subject: [PATCH] gnu: Add mtd-utils.

* gnu/packages/linux.scm (mtd-utils): New variable.

Signed-off-by: Leo Famulari <leo@famulari.name>
---
 gnu/packages/linux.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
Efraim Flashner - Sept. 7, 2016, 6:29 a.m.
On Tue, Sep 06, 2016 at 05:49:41PM -0400, Leo Famulari wrote:
> On Thu, Sep 01, 2016 at 02:33:57PM +0200, Danny Milosavljevic wrote:
> > gnu: Add mtd-utils.
> > 
> > * gnu/packages/linux.scm (mtd-utils): New variable.
> 
> Thanks for this patch!
> 
> I made some adjustments, as attached.
> 
> I imported the acl module, used #:make-flags to set PREFIX, and made a
> minor adjustment to the description.
> 
> What do you think?

> From dd00ffc45982b393cb458445e875188baf77175f Mon Sep 17 00:00:00 2001
> From: Danny Milosavljevic <dannym@scratchpost.org>
> Date: Thu, 1 Sep 2016 14:33:57 +0200
> Subject: [PATCH] gnu: Add mtd-utils.
> 
> * gnu/packages/linux.scm (mtd-utils): New variable.
> 
> Signed-off-by: Leo Famulari <leo@famulari.name>
> ---
>  gnu/packages/linux.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 030e35e..ed96996 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -33,6 +33,7 @@
>  
>  (define-module (gnu packages linux)
>    #:use-module (gnu packages)
> +  #:use-module (gnu packages acl)
>    #:use-module (gnu packages admin)
>    #:use-module (gnu packages algebra)
>    #:use-module (gnu packages attr)
> @@ -2929,3 +2930,33 @@ native Linux file system, and has been part of the Linux kernel since version
>      ;; The files src/key_mod/ecryptfs_key_mod_{openssl,pkcs11_helper,tspi}.c
>      ;; grant additional permission to link with OpenSSL.
>      (license license:gpl2+)))
> +
> +(define-public mtd-utils
> +  (package
> +    (name "mtd-utils")
> +    (version "1.5.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "ftp://ftp.infradead.org/pub/mtd-utils/"
> +                    "mtd-utils-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "007lhsd8yb34l899r4m37whhzdw815cz4fnjbpnblfha524p7dax"))))
> +    (inputs
> +     `(("acl" ,acl)
> +       ("libuuid" ,util-linux)
> +       ("lzo", lzo)
> +       ("zlib" ,zlib)))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:test-target "tests"
> +       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> +       #:phases (modify-phases %standard-phases
> +                  (delete 'configure))))
> +    (synopsis "MTD Flash Storage Utilities")
> +    (description "This package provides utilities for testing, partitioning, etc
> +of flash storage.")
> +    (home-page "http://www.linux-mtd.infradead.org/")
> +    ;; mkfs.ubifs/crc16.h is GPLv2
> +    (license (list license:gpl2 license:mpl1.1 license:bsd-3))))
> -- 
> 2.10.0
> 

Is the package under all three licenses or are certain parts under
different licenses? I've found packages that include a mozilla license
seem to have these three, or a variation of them.
Danny Milosavljevic - Sept. 7, 2016, 7:27 a.m.
Hi Leo,

On Tue, 6 Sep 2016 17:49:41 -0400
Leo Famulari <leo@famulari.name> wrote:

> I imported the acl module, used #:make-flags to set PREFIX, and made a
> minor adjustment to the description.
> 
> What do you think?

Looks good and works :)
Leo Famulari - Sept. 10, 2016, 7:45 p.m.
On Wed, Sep 07, 2016 at 09:29:46AM +0300, Efraim Flashner wrote:
> > +    (license (list license:gpl2 license:mpl1.1 license:bsd-3))))
> 
> Is the package under all three licenses or are certain parts under
> different licenses? I've found packages that include a mozilla license
> seem to have these three, or a variation of them.

Ping :)
Efraim Flashner - Sept. 26, 2016, 9:39 a.m.
On Sat, Sep 10, 2016 at 03:45:16PM -0400, Leo Famulari wrote:
> On Wed, Sep 07, 2016 at 09:29:46AM +0300, Efraim Flashner wrote:
> > > +    (license (list license:gpl2 license:mpl1.1 license:bsd-3))))
> > 
> > Is the package under all three licenses or are certain parts under
> > different licenses? I've found packages that include a mozilla license
> > seem to have these three, or a variation of them.
> 
> Ping :)

After grepping License, here's what I got:

jffsdump.c        gpl2
compr_lzo.c       gpl2
mtdpart.c         gpl2
ftl_format.c      mpl1.1
ftl_check.c       mpl1.1
./ubi-utils/LICENSE.libiniparser:MIT License
tests/ubi-tests   gpl2+
tests/fs-tests    gpl2
mkfs.ubifs/       gpl2+
include/mtd/ftl-user.h  mpl1.1

everything else in include/ and loose files in / are gpl2+

Patch

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 030e35e..ed96996 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -33,6 +33,7 @@ 
 
 (define-module (gnu packages linux)
   #:use-module (gnu packages)
+  #:use-module (gnu packages acl)
   #:use-module (gnu packages admin)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages attr)
@@ -2929,3 +2930,33 @@  native Linux file system, and has been part of the Linux kernel since version
     ;; The files src/key_mod/ecryptfs_key_mod_{openssl,pkcs11_helper,tspi}.c
     ;; grant additional permission to link with OpenSSL.
     (license license:gpl2+)))
+
+(define-public mtd-utils
+  (package
+    (name "mtd-utils")
+    (version "1.5.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "ftp://ftp.infradead.org/pub/mtd-utils/"
+                    "mtd-utils-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "007lhsd8yb34l899r4m37whhzdw815cz4fnjbpnblfha524p7dax"))))
+    (inputs
+     `(("acl" ,acl)
+       ("libuuid" ,util-linux)
+       ("lzo", lzo)
+       ("zlib" ,zlib)))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:test-target "tests"
+       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure))))
+    (synopsis "MTD Flash Storage Utilities")
+    (description "This package provides utilities for testing, partitioning, etc
+of flash storage.")
+    (home-page "http://www.linux-mtd.infradead.org/")
+    ;; mkfs.ubifs/crc16.h is GPLv2
+    (license (list license:gpl2 license:mpl1.1 license:bsd-3))))