Patchwork : gnu: gnurl: Update to 7.50.1.

login
register
mail settings
Submitter non such
Date Aug. 5, 2016, 6:19 p.m.
Message ID <87invfxels.fsf@we.make.ritual.n0.is>
Download mbox | patch
Permalink /patch/14344/
State New
Headers show

Comments

non such - Aug. 5, 2016, 6:19 p.m.
ng0 <ng0@we.make.ritual.n0.is> writes:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Fri, Aug 05, 2016 at 02:57:10PM +0000, ng0 wrote:
>>> From 81f605a551a3cfcfe48fae27fd7aa5d9affa4bd2 Mon Sep 17 00:00:00 2001
>>> From: ng0 <ng0@we.make.ritual.n0.is>
>>> Date: Fri, 5 Aug 2016 14:44:38 +0000
>>> Subject: [PATCH] gnu: gnurl: Update to 7.50.1.
>>> 
>>> * gnu/packages/gnunet.scm (gnurl): Update to 7.50.1.
>>> [configure-flags]: Configure with --disable-smb.
>>> Disable test1139.
>>
>> Can you add a comment explaining why test1139 is disabled? Just saying
>> that it won't work doesn't tell those reading the package why it is
>> disabled.
>
> My assumption: files or lines of code are searched which will not exist
> in gnurl. If this is not just us (sadly in Gentoo i have test/checks
> disabled for this package), I will fix this upstream.
> If your perl knowledge is better look at the failing test yourself. This
> is my best judgment with the little perl knowledge I have.
> It was just ruling out what could cause the test failure.

Is this okay?
non such - Aug. 14, 2016, 9:18 a.m.
ng0 <ng0@we.make.ritual.n0.is> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> Leo Famulari <leo@famulari.name> writes:
>>
>>> On Fri, Aug 05, 2016 at 02:57:10PM +0000, ng0 wrote:
>>>> From 81f605a551a3cfcfe48fae27fd7aa5d9affa4bd2 Mon Sep 17 00:00:00 2001
>>>> From: ng0 <ng0@we.make.ritual.n0.is>
>>>> Date: Fri, 5 Aug 2016 14:44:38 +0000
>>>> Subject: [PATCH] gnu: gnurl: Update to 7.50.1.
>>>> 
>>>> * gnu/packages/gnunet.scm (gnurl): Update to 7.50.1.
>>>> [configure-flags]: Configure with --disable-smb.
>>>> Disable test1139.
>>>
>>> Can you add a comment explaining why test1139 is disabled? Just saying
>>> that it won't work doesn't tell those reading the package why it is
>>> disabled.
>>
>> My assumption: files or lines of code are searched which will not exist
>> in gnurl. If this is not just us (sadly in Gentoo i have test/checks
>> disabled for this package), I will fix this upstream.
>> If your perl knowledge is better look at the failing test yourself. This
>> is my best judgment with the little perl knowledge I have.
>> It was just ruling out what could cause the test failure.
>
> Is this okay?

Can someone tell me if this is okay or if it needs further changes?
I'd like to update this.

> From 8b99ce31e269334aa339af27c3e78577f73052ce Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@we.make.ritual.n0.is>
> Date: Fri, 5 Aug 2016 14:44:38 +0000
> Subject: [PATCH] gnu: gnurl: Update to 7.50.1.
>
> * gnu/packages/gnunet.scm (gnurl): Update to 7.50.1.
> [configure-flags]: Configure with --disable-smb.
> Disable test1139.
> ---
>  gnu/packages/gnunet.scm | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
> index 4d888bd..36aa8c0 100644
> --- a/gnu/packages/gnunet.scm
> +++ b/gnu/packages/gnunet.scm
> @@ -153,7 +153,7 @@ and support for SSL3 and TLS.")
>  (define-public gnurl
>    (package
>     (name "gnurl")
> -   (version "7.48.0")
> +   (version "7.50.1")
>     (source (origin
>              (method url-fetch)
>              (uri (let ((version-with-underscores
> @@ -162,7 +162,7 @@ and support for SSL3 and TLS.")
>                                    name "-" version-with-underscores ".tar.bz2")))
>              (sha256
>               (base32
> -              "14gch4rdibrc8qs4mijsczxvl45dsclf234g17dk6c8nc2s4bm0a"))))
> +              "0irb8df3lqd9w1pb627q260hn448vbkh0sn4l6p6jh0q8lqscv84"))))
>     (build-system gnu-build-system)
>     (inputs `(("gnutls" ,gnutls)
>               ("libidn" ,libidn)
> @@ -183,17 +183,24 @@ and support for SSL3 and TLS.")
>                            "--disable-ldap" "--disable-rtsp" "--disable-dict"
>                            "--disable-telnet" "--disable-tftp" "--disable-pop3"
>                            "--disable-imap" "--disable-smtp" "--disable-gopher"
> -                          "--disable-file" "--disable-ftp")
> +                          "--disable-file" "--disable-ftp" "--disable-smb")
>       #:test-target "test"
>       #:parallel-tests? #f
> -     ;; We have to patch runtests.pl in tests/ directory
>       #:phases
> +     ;; We have to patch runtests.pl in tests/ directory
>        (alist-cons-before
>         'check 'patch-runtests
>         (lambda _
>           (substitute* "tests/runtests.pl"
> -                      (("/bin/sh") (which "sh"))))
> -       %standard-phases)))
> +           (("/bin/sh") (which "sh"))))
> +       ;; This test is disabled because of some reduction in code gnurl
> +       ;; implies, it can not succeed when some functions it expects are
> +       ;; not built.
> +       (alist-cons-before
> +        'check 'delete-failing-test1139
> +        (lambda _
> +          (delete-file "tests/data/test1139"))
> +       %standard-phases))))
>     (synopsis "Microfork of cURL with support for the HTTP/HTTPS/GnuTLS subset of cURL")
>     (description
>      "Gnurl is a microfork of cURL, a command line tool for transferring data
> -- 
> 2.9.2
>
>
>
> -- 
> ♥Ⓐ  ng0
> Current Keys: https://we.make.ritual.n0.is/ng0.txt
> For non-prism friendly talk find me on http://www.psyced.org
Leo Famulari - Aug. 15, 2016, 5:53 p.m.
On Sun, Aug 14, 2016 at 09:18:11AM +0000, ng0 wrote:
> ng0 <ng0@we.make.ritual.n0.is> writes:
> > ng0 <ng0@we.make.ritual.n0.is> writes:
> >> Leo Famulari <leo@famulari.name> writes:
> >>> Can you add a comment explaining why test1139 is disabled? Just saying
> >>> that it won't work doesn't tell those reading the package why it is
> >>> disabled.
> >>
> >> My assumption: files or lines of code are searched which will not exist
> >> in gnurl. If this is not just us (sadly in Gentoo i have test/checks
> >> disabled for this package), I will fix this upstream.
> >> If your perl knowledge is better look at the failing test yourself. This
> >> is my best judgment with the little perl knowledge I have.
> >> It was just ruling out what could cause the test failure.
> >
> > Is this okay?
> 
> Can someone tell me if this is okay or if it needs further changes?
> I'd like to update this.

Okay, I think it should updated too, considering that gnurl is a cURL
fork, and that the latest release of cURL fixed these bugs:

CVE-2016-5419:
https://curl.haxx.se/docs/adv_20160803A.html
CVE-2016-5420:
https://curl.haxx.se/docs/adv_20160803B.html
CVE-2016-5421:
https://curl.haxx.se/docs/adv_20160803C.html

Pushed as 5f9d5905745.

Will you file a bug report with the gnurl developers about this failing
test and reply to this email with a link to the bug report?

Ideally, the package update commit would include a link to the upstream
bug report about the failing test, but I'm not going to wait for the
link to update this.

If a Guix package is passing its entire test suite, we should react to
new tests failures proactively. That means that we should try to
understand the problem, and work with the upstream developers to fix the
problem.
non such - Aug. 15, 2016, 11:24 p.m.
Leo Famulari <leo@famulari.name> writes:

> On Sun, Aug 14, 2016 at 09:18:11AM +0000, ng0 wrote:
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>> > ng0 <ng0@we.make.ritual.n0.is> writes:
>> >> Leo Famulari <leo@famulari.name> writes:
>> >>> Can you add a comment explaining why test1139 is disabled? Just saying
>> >>> that it won't work doesn't tell those reading the package why it is
>> >>> disabled.
>> >>
>> >> My assumption: files or lines of code are searched which will not exist
>> >> in gnurl. If this is not just us (sadly in Gentoo i have test/checks
>> >> disabled for this package), I will fix this upstream.
>> >> If your perl knowledge is better look at the failing test yourself. This
>> >> is my best judgment with the little perl knowledge I have.
>> >> It was just ruling out what could cause the test failure.
>> >
>> > Is this okay?
>> 
>> Can someone tell me if this is okay or if it needs further changes?
>> I'd like to update this.
>
> Okay, I think it should updated too, considering that gnurl is a cURL
> fork, and that the latest release of cURL fixed these bugs:
>
> CVE-2016-5419:
> https://curl.haxx.se/docs/adv_20160803A.html
> CVE-2016-5420:
> https://curl.haxx.se/docs/adv_20160803B.html
> CVE-2016-5421:
> https://curl.haxx.se/docs/adv_20160803C.html
>
> Pushed as 5f9d5905745.

Thanks,

> Will you file a bug report with the gnurl developers about this failing
> test and reply to this email with a link to the bug report?

yes I will do so and see who can fix it.

> Ideally, the package update commit would include a link to the upstream
> bug report about the failing test, but I'm not going to wait for the
> link to update this.

I see, I thought this should just be placed into comments in the package
definition. Makes sense to include it in the commit message.

> If a Guix package is passing its entire test suite, we should react to
> new tests failures proactively. That means that we should try to
> understand the problem, and work with the upstream developers to fix the
> problem.
Leo Famulari - Aug. 16, 2016, 12:05 a.m.
On Mon, Aug 15, 2016 at 11:24:37PM +0000, ng0 wrote:
> Leo Famulari <leo@famulari.name> writes:
> > Will you file a bug report with the gnurl developers about this failing
> > test and reply to this email with a link to the bug report?
> 
> yes I will do so and see who can fix it.

Thank you!

> > Ideally, the package update commit would include a link to the upstream
> > bug report about the failing test, but I'm not going to wait for the
> > link to update this.
> 
> I see, I thought this should just be placed into comments in the package
> definition. Makes sense to include it in the commit message.

That's what I meant: the link should go in a code comment in the package
itself.

Patch

From 8b99ce31e269334aa339af27c3e78577f73052ce Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Fri, 5 Aug 2016 14:44:38 +0000
Subject: [PATCH] gnu: gnurl: Update to 7.50.1.

* gnu/packages/gnunet.scm (gnurl): Update to 7.50.1.
[configure-flags]: Configure with --disable-smb.
Disable test1139.
---
 gnu/packages/gnunet.scm | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index 4d888bd..36aa8c0 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -153,7 +153,7 @@  and support for SSL3 and TLS.")
 (define-public gnurl
   (package
    (name "gnurl")
-   (version "7.48.0")
+   (version "7.50.1")
    (source (origin
             (method url-fetch)
             (uri (let ((version-with-underscores
@@ -162,7 +162,7 @@  and support for SSL3 and TLS.")
                                   name "-" version-with-underscores ".tar.bz2")))
             (sha256
              (base32
-              "14gch4rdibrc8qs4mijsczxvl45dsclf234g17dk6c8nc2s4bm0a"))))
+              "0irb8df3lqd9w1pb627q260hn448vbkh0sn4l6p6jh0q8lqscv84"))))
    (build-system gnu-build-system)
    (inputs `(("gnutls" ,gnutls)
              ("libidn" ,libidn)
@@ -183,17 +183,24 @@  and support for SSL3 and TLS.")
                           "--disable-ldap" "--disable-rtsp" "--disable-dict"
                           "--disable-telnet" "--disable-tftp" "--disable-pop3"
                           "--disable-imap" "--disable-smtp" "--disable-gopher"
-                          "--disable-file" "--disable-ftp")
+                          "--disable-file" "--disable-ftp" "--disable-smb")
      #:test-target "test"
      #:parallel-tests? #f
-     ;; We have to patch runtests.pl in tests/ directory
      #:phases
+     ;; We have to patch runtests.pl in tests/ directory
       (alist-cons-before
        'check 'patch-runtests
        (lambda _
          (substitute* "tests/runtests.pl"
-                      (("/bin/sh") (which "sh"))))
-       %standard-phases)))
+           (("/bin/sh") (which "sh"))))
+       ;; This test is disabled because of some reduction in code gnurl
+       ;; implies, it can not succeed when some functions it expects are
+       ;; not built.
+       (alist-cons-before
+        'check 'delete-failing-test1139
+        (lambda _
+          (delete-file "tests/data/test1139"))
+       %standard-phases))))
    (synopsis "Microfork of cURL with support for the HTTP/HTTPS/GnuTLS subset of cURL")
    (description
     "Gnurl is a microfork of cURL, a command line tool for transferring data
-- 
2.9.2