Patchwork [01/31] gnu: network-manager: Propagate GLIB.

login
register
mail settings
Submitter David Craven
Date Aug. 1, 2016, 6:13 p.m.
Message ID <20160801181342.16203-2-david@craven.ch>
Download mbox | patch
Permalink /patch/14195/
State New
Headers show

Comments

David Craven - Aug. 1, 2016, 6:13 p.m.
* gnu/packages/gnome.scm (network-manager)[propagated-inputs]: Add glib.
---
 gnu/packages/gnome.scm | 2 ++
 1 file changed, 2 insertions(+)
Andreas Enge - Aug. 1, 2016, 7:48 p.m.
On Mon, Aug 01, 2016 at 08:13:12PM +0200, David Craven wrote:
> * gnu/packages/gnome.scm (network-manager)[propagated-inputs]: Add glib.
> +    (propagated-inputs
> +     `(("glib" ,glib)))

This requires a little comment at the end of the line.

I wonder if it is really needed. network-manager provides several libraries.
Looking into the pkgconfig subdirectory, there is the following:
-r--r--r-- 2 root guixbuild 389  1. Jan 1970  libnm-glib.pc
-r--r--r-- 2 root guixbuild 375  1. Jan 1970  libnm-glib-vpn.pc
-r--r--r-- 2 root guixbuild 361  1. Jan 1970  libnm.pc
-r--r--r-- 2 root guixbuild 370  1. Jan 1970  libnm-util.pc
-r--r--r-- 2 root guixbuild 414  1. Jan 1970  NetworkManager.pc
libnm-glib.pc, libnm-glib-vpn.pc and libnm-util.pc require glib, the others
do not. So it seems entirely possible to use network-manager without pulling
glib into a profile.

What do the specialists think?

Andreas
David Craven - Aug. 1, 2016, 7:56 p.m.
> libnm-glib.pc, libnm-glib-vpn.pc and libnm-util.pc require glib, the others
> do not. So it seems entirely possible to use network-manager without pulling
> glib into a profile.

libnm requires glib too.

pkg-config libnm --libs
-L/gnu/store/m3py3rk71ihlfgvj2kss7054hwfqwkpq-glib-2.48.0/lib
-L/nix/store/apa8hagf5bnsw0fyb0i9a3b59z6h8ppb-network-manager-1.0.12/lib
-lnm -lgio-2.0 -lgobject-2.0 -lglib-2.0
Andreas Enge - Aug. 1, 2016, 9:16 p.m.
On Mon, Aug 01, 2016 at 09:56:44PM +0200, David Craven wrote:
> libnm requires glib too.
> pkg-config libnm --libs
> -L/gnu/store/m3py3rk71ihlfgvj2kss7054hwfqwkpq-glib-2.48.0/lib
> -L/nix/store/apa8hagf5bnsw0fyb0i9a3b59z6h8ppb-network-manager-1.0.12/lib
> -lnm -lgio-2.0 -lgobject-2.0 -lglib-2.0

Okay. Should be fine to propagate then.

Andreas

Patch

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 445e94a..2038f8f 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -4423,6 +4423,8 @@  users.")
                              "rundir=/tmp"
                              "statedir=/tmp"
                              "install")))))))
+    (propagated-inputs
+     `(("glib" ,glib)))
     (native-inputs
      `(("glib:bin" ,glib "bin") ; for gdbus-codegen
        ("gobject-introspection" ,gobject-introspection)