Patchwork gnu: dmidecode: Update to 3.0.

login
register
mail settings
Submitter Kei Yamashita
Date July 31, 2016, 9:24 p.m.
Message ID <87y44hijqw.fsf@openmailbox.org>
Download mbox | patch
Permalink /patch/14177/
State New
Headers show

Comments

Kei Yamashita - July 31, 2016, 9:24 p.m.
ng0 <ng0@we.make.ritual.n0.is> writes:

> Kei Kebreau <kei@openmailbox.org> writes:
>
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>
>>> Hi,
>>>
>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>
>>>> A package for those who like to roam around the lower levels of their
>>>> machines. As soon as this package is verified to build successfully and
>>>> reproducibly on another user's machine, I can push it to the repos.
>
> snip
>
>> Wow! I must have misspelled dmidecode when I searched for it! Silly me. :-P
>>
>> I've attached a new patch. I don't know whether updating a version
>> number necessitates a copyright assignment, so I omitted it.
>
> Thanks. No problem. I can not review it (or at least not right now), but
> version bumps get copyright assignments too.
> I think I could review it on tuesday or tomorrow night. Could you send
> it as .patch in addition to inlined? I have not figured out how to
> extract inlined patches in notmuch yet.
>

Sure thing:

From 06770d6275aacdb0c5763bcc8aff4d27fe6ae2f5 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Sun, 31 Jul 2016 17:15:25 -0400
Subject: [PATCH] gnu: dmidecode: Update to 3.0.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/packages/admin.scm (dmidecode): Update to 3.0.
[arguments]: Use ’modify-phases’ instead of ‘alist-delete’.
---
 gnu/packages/admin.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Ludovic Courtès - Aug. 1, 2016, 12:03 p.m.
Kei Kebreau <kei@openmailbox.org> skribis:

> From 06770d6275aacdb0c5763bcc8aff4d27fe6ae2f5 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Sun, 31 Jul 2016 17:15:25 -0400
> Subject: [PATCH] gnu: dmidecode: Update to 3.0.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * gnu/packages/admin.scm (dmidecode): Update to 3.0.
> [arguments]: Use ’modify-phases’ instead of ‘alist-delete’.

LGTM! :-)

Ludo'.
non such - Aug. 1, 2016, 1:02 p.m.
Kei Kebreau <kei@openmailbox.org> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> Kei Kebreau <kei@openmailbox.org> writes:
>>
>>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>>
>>>> Hi,
>>>>
>>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>>
>>>>> A package for those who like to roam around the lower levels of their
>>>>> machines. As soon as this package is verified to build successfully and
>>>>> reproducibly on another user's machine, I can push it to the repos.
>>
>> snip
>>
>>> Wow! I must have misspelled dmidecode when I searched for it! Silly me. :-P
>>>
>>> I've attached a new patch. I don't know whether updating a version
>>> number necessitates a copyright assignment, so I omitted it.
>>
>> Thanks. No problem. I can not review it (or at least not right now), but
>> version bumps get copyright assignments too.
>> I think I could review it on tuesday or tomorrow night. Could you send
>> it as .patch in addition to inlined? I have not figured out how to
>> extract inlined patches in notmuch yet.
>>

Weird, did you sent it as patch the first time already and not inlined?
I should really allow myself a vacation at some point.

Builds here, patch looks good to me.
>
> Sure thing:
>
> From 06770d6275aacdb0c5763bcc8aff4d27fe6ae2f5 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Sun, 31 Jul 2016 17:15:25 -0400
> Subject: [PATCH] gnu: dmidecode: Update to 3.0.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * gnu/packages/admin.scm (dmidecode): Update to 3.0.
> [arguments]: Use ’modify-phases’ instead of ‘alist-delete’.
> ---
>  gnu/packages/admin.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 195959e..a80ee9d 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -981,18 +981,18 @@ network, which causes enabled computers to power on.")
>  (define-public dmidecode
>    (package
>      (name "dmidecode")
> -    (version "2.12")
> +    (version "3.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append
>                      "mirror://savannah/dmidecode/dmidecode-"
> -                    version ".tar.bz2"))
> +                    version ".tar.xz"))
>                (sha256
>                 (base32
> -                "122hgaw8mpqdfra159lfl6pyk3837giqx6vq42j64fjnbl2z6gwi"))))
> +                "0iby0xfk5x3cdr0x0gxj5888jjyjhafvaq0l79civ73jjfqmphvy"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:phases (alist-delete 'configure %standard-phases)
> +     '(#:phases (modify-phases %standard-phases (delete 'configure))
>         #:tests? #f                                ; no 'check' target
>         #:make-flags (list (string-append "prefix="
>                                           (assoc-ref %outputs "out")))))
> -- 
> 2.9.2
>
> From 06770d6275aacdb0c5763bcc8aff4d27fe6ae2f5 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Sun, 31 Jul 2016 17:15:25 -0400
> Subject: [PATCH] gnu: dmidecode: Update to 3.0.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * gnu/packages/admin.scm (dmidecode): Update to 3.0.
> [arguments]: Use ’modify-phases’ instead of ‘alist-delete’.
> ---
>  gnu/packages/admin.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 195959e..a80ee9d 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -981,18 +981,18 @@ network, which causes enabled computers to power on.")
>  (define-public dmidecode
>    (package
>      (name "dmidecode")
> -    (version "2.12")
> +    (version "3.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append
>                      "mirror://savannah/dmidecode/dmidecode-"
> -                    version ".tar.bz2"))
> +                    version ".tar.xz"))
>                (sha256
>                 (base32
> -                "122hgaw8mpqdfra159lfl6pyk3837giqx6vq42j64fjnbl2z6gwi"))))
> +                "0iby0xfk5x3cdr0x0gxj5888jjyjhafvaq0l79civ73jjfqmphvy"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:phases (alist-delete 'configure %standard-phases)
> +     '(#:phases (modify-phases %standard-phases (delete 'configure))
>         #:tests? #f                                ; no 'check' target
>         #:make-flags (list (string-append "prefix="
>                                           (assoc-ref %outputs "out")))))
> -- 
> 2.9.2
>
Kei Yamashita - Aug. 1, 2016, 3:45 p.m.
ng0 <ng0@we.make.ritual.n0.is> writes:

> Kei Kebreau <kei@openmailbox.org> writes:
>
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>
>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>
>>>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>>>
>>>>> Hi,
>>>>>
>>>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>>>
>>>>>> A package for those who like to roam around the lower levels of their
>>>>>> machines. As soon as this package is verified to build successfully and
>>>>>> reproducibly on another user's machine, I can push it to the repos.
>>>
>>> snip
>>>
>>>> Wow! I must have misspelled dmidecode when I searched for it! Silly me. :-P
>>>>
>>>> I've attached a new patch. I don't know whether updating a version
>>>> number necessitates a copyright assignment, so I omitted it.
>>>
>>> Thanks. No problem. I can not review it (or at least not right now), but
>>> version bumps get copyright assignments too.
>>> I think I could review it on tuesday or tomorrow night. Could you send
>>> it as .patch in addition to inlined? I have not figured out how to
>>> extract inlined patches in notmuch yet.
>>>
>
> Weird, did you sent it as patch the first time already and not inlined?
> I should really allow myself a vacation at some point.
>

I did indeed. You have my permission to take a break any time you like! :-)

> Builds here, patch looks good to me.

Patch

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 195959e..a80ee9d 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -981,18 +981,18 @@  network, which causes enabled computers to power on.")
 (define-public dmidecode
   (package
     (name "dmidecode")
-    (version "2.12")
+    (version "3.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
                     "mirror://savannah/dmidecode/dmidecode-"
-                    version ".tar.bz2"))
+                    version ".tar.xz"))
               (sha256
                (base32
-                "122hgaw8mpqdfra159lfl6pyk3837giqx6vq42j64fjnbl2z6gwi"))))
+                "0iby0xfk5x3cdr0x0gxj5888jjyjhafvaq0l79civ73jjfqmphvy"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:phases (alist-delete 'configure %standard-phases)
+     '(#:phases (modify-phases %standard-phases (delete 'configure))
        #:tests? #f                                ; no 'check' target
        #:make-flags (list (string-append "prefix="
                                          (assoc-ref %outputs "out")))))