Patchwork [7/8] gnu: qemu: Enable spice support.

login
register
mail settings
Submitter David Craven
Date July 29, 2016, 8:23 a.m.
Message ID <20160729082357.17501-7-david@craven.ch>
Download mbox | patch
Permalink /patch/14136/
State New
Headers show

Comments

David Craven - July 29, 2016, 8:23 a.m.
* gnu/packages/qemu.scm (qemu): Enable spice.
---
 gnu/packages/qemu.scm | 4 ++++
 1 file changed, 4 insertions(+)
Ludovic Courtès - July 29, 2016, 7:10 p.m.
David Craven <david@craven.ch> skribis:

> * gnu/packages/qemu.scm (qemu): Enable spice.

I’m nitpicking, but it should be something like:

  * gnu/packages/qemu.scm (qemu)[inputs]: Add SPICE and VIRGLRENDERER.
  [arguments]: Pass --enable-spice.

… so we see precisely what changes are made.

I notice that virglrenderer hasn’t landed yet, right?

Also, I compared ‘guix size qemu’ to ‘guix size qemu spice’ and I see a
3% increase of the closure size (to 502 MiB), which sounds reasonable.

While we’re at it, could you create an account on
<https://savannah.gnu.org/> and let send the account name by
OpenPGP-signed email to the 6 people listed at
<https://savannah.gnu.org/projects/guix/>?

Thanks in advance!  :-)

Ludo’.
David Craven - July 29, 2016, 7:12 p.m.
It's in gnu/packages/spice.scm, Leo merged it this morning... Things
move fast around here =P
Ludovic Courtès - July 30, 2016, 12:47 p.m.
Hello!

ludo@gnu.org (Ludovic Courtès) skribis:

> While we’re at it, could you create an account on
> <https://savannah.gnu.org/> and let send the account name by
> OpenPGP-signed email to the 6 people listed at
> <https://savannah.gnu.org/projects/guix/>?

You now have commit access to the repo, which hopefully will make the
process smoother.

You probably already know about
<https://www.gnu.org/software/guix/manual/html_node/Contributing.html>;
make sure to read ‘HACKING’ on the rules for committers.

Happy hacking!  :-)

Ludo’.

Patch

diff --git a/gnu/packages/qemu.scm b/gnu/packages/qemu.scm
index 6b5a41b..97642af 100644
--- a/gnu/packages/qemu.scm
+++ b/gnu/packages/qemu.scm
@@ -33,6 +33,7 @@ 
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages sdl)
+  #:use-module (gnu packages spice)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages xdisorg)
   #:use-module (guix build-system gnu)
@@ -91,6 +92,7 @@ 
                          ,(string-append "--cc=" (which "gcc"))
                          "--disable-debug-info" ; save build space
                          "--enable-virtfs"      ; just to be sure
+                         "--enable-spice"
                          ,(string-append "--prefix=" out)
                          ,@configure-flags))))))
          (add-after 'install 'install-info
@@ -132,8 +134,10 @@ 
        ;; ("pciutils" ,pciutils)
        ("pixman" ,pixman)
        ("sdl" ,sdl)
+       ("spice" ,spice)
        ("util-linux" ,util-linux)
        ;; ("vde2" ,vde2)
+       ("virglrenderer" ,virglrenderer)
        ("zlib" ,zlib)))
     (native-inputs `(("glib:bin" ,glib "bin") ; gtester, etc.
                      ("perl" ,perl)