Patchwork download: Add official SourceForge mirror.

login
register
mail settings
Submitter Alex Griffin
Date July 22, 2016, 6:08 p.m.
Message ID <1469210911.1549087.674070209.3110DF3E@webmail.messagingengine.com>
Download mbox | patch
Permalink /patch/13933/
State New
Headers show

Comments

Alex Griffin - July 22, 2016, 6:08 p.m.
This patch mirrors a similar change in nixpkgs [1][2].

The official method for downloading from SourceForge is to use
downloads.sourceforge.net, which redirects to various other mirrors. It
can be unreliable, but also faster because it can find a nearby mirror
and load-balance. If it fails Guix will still fall back to known good
mirrors.

[1]: https://github.com/NixOS/nixpkgs/issues/16900
[2]: https://github.com/NixOS/nixpkgs/pull/16976
Leo Famulari - July 22, 2016, 11:10 p.m.
On Fri, Jul 22, 2016 at 01:08:31PM -0500, Alex Griffin wrote:
> This patch mirrors a similar change in nixpkgs [1][2].
> 
> The official method for downloading from SourceForge is to use
> downloads.sourceforge.net, which redirects to various other mirrors. It
> can be unreliable, but also faster because it can find a nearby mirror
> and load-balance. If it fails Guix will still fall back to known good
> mirrors.

I think it's a good idea. It wouldn't have helped with the latest
problem, where the project-specific parts of the URL changed. But, if
our users can automatically use closer mirrors, that seems best.

Any objections?
Efraim Flashner - July 24, 2016, 7:29 a.m.
On Fri, Jul 22, 2016 at 07:10:26PM -0400, Leo Famulari wrote:
> On Fri, Jul 22, 2016 at 01:08:31PM -0500, Alex Griffin wrote:
> > This patch mirrors a similar change in nixpkgs [1][2].
> > 
> > The official method for downloading from SourceForge is to use
> > downloads.sourceforge.net, which redirects to various other mirrors. It
> > can be unreliable, but also faster because it can find a nearby mirror
> > and load-balance. If it fails Guix will still fall back to known good
> > mirrors.
> 
> I think it's a good idea. It wouldn't have helped with the latest
> problem, where the project-specific parts of the URL changed. But, if
> our users can automatically use closer mirrors, that seems best.
> 
> Any objections?
> 

This sounds like a good idea
Leo Famulari - July 24, 2016, 4:36 p.m.
On Fri, Jul 22, 2016 at 01:08:31PM -0500, Alex Griffin wrote:
> * guix/download.scm (mirrors)[sourceforge]: Add official SourceForge mirror.

I added a copyright line for you and pushed as fe224d20cc. Thanks!

Patch

From 387f1116e6d6c8aa99e19a0ade3605300d59b0f9 Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Fri, 22 Jul 2016 12:55:47 -0500
Subject: [PATCH] download: Add official SourceForge mirror.

The official method for downloading from SourceForge is to use
downloads.sourceforge.net, which redirects to various other mirrors. It
can be unreliable, but also faster because it can find a nearby mirror
and load-balance. If it fails Guix will still fall back to known good
mirrors.

* guix/download.scm (mirrors)[sourceforge]: Add official SourceForge mirror.
---
 guix/download.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/guix/download.scm b/guix/download.scm
index 8f38a4f..aa403af 100644
--- a/guix/download.scm
+++ b/guix/download.scm
@@ -99,6 +99,7 @@ 
        "http://www.centervenus.com/mirrors/nongnu/"
        "http://download.savannah.gnu.org/releases-noredirect/")
       (sourceforge ; https://sourceforge.net/p/forge/documentation/Mirrors/
+       "http://downloads.sourceforge.net/project/"
        "http://ufpr.dl.sourceforge.net/project/"
        "http://heanet.dl.sourceforge.net/project/"
        "http://freefr.dl.sourceforge.net/project/"
-- 
2.9.1