Patchwork gnu: perl-io-socket-ssl: Add IDN support.

login
register
mail settings
Submitter non such
Date July 22, 2016, 12:05 a.m.
Message ID <87r3amlep1.fsf_-_@we.make.ritual.n0.is>
Download mbox | patch
Permalink /patch/13917/
State New
Headers show

Comments

non such - July 22, 2016, 12:05 a.m.
From d841892a6563fa79f8185d6ea470a160d1b54b2c Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Fri, 22 Jul 2016 00:01:03 +0000
Subject: [PATCH] gnu: perl-io-socket-ssl: Add IDN support.

* gnu/packages/web.scm (perl-io-socket-ssl)[propagated-inputs]: Add perl-uri
for IDN support.
---
 gnu/packages/web.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Efraim Flashner - July 24, 2016, 6:27 a.m.
On Fri, Jul 22, 2016 at 12:05:46AM +0000, ng0 wrote:
> From d841892a6563fa79f8185d6ea470a160d1b54b2c Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@we.make.ritual.n0.is>
> Date: Fri, 22 Jul 2016 00:01:03 +0000
> Subject: [PATCH] gnu: perl-io-socket-ssl: Add IDN support.
> 
> * gnu/packages/web.scm (perl-io-socket-ssl)[propagated-inputs]: Add perl-uri
> for IDN support.
> ---
>  gnu/packages/web.scm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index c2cae27..33c1e88 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -2401,7 +2401,10 @@ and IPv6 sockets, intended as a replacement for IO::Socket::INET.")
>                (patches (search-patches
>                          "perl-io-socket-ssl-openssl-1.0.2f-fix.patch"))))
>      (build-system perl-build-system)
> -    (propagated-inputs `(("perl-net-ssleay" ,perl-net-ssleay)))
> +    (propagated-inputs
> +     `(("perl-net-ssleay" ,perl-net-ssleay)
> +       ;; for IDN support
> +       ("perl-uri" ,perl-uri)))
>      (synopsis "Nearly transparent SSL encapsulation for IO::Socket::INET")
>      (description
>       "IO::Socket::SSL makes using SSL/TLS much easier by wrapping the
> -- 
> 2.9.1
> 
> 
> -- 
> ♥Ⓐ  ng0 – http://we.make.ritual.n0.is
> For non-prism friendly talk find me on http://www.psyced.org
> SecuShare – http://secushare.org
> 

LGTM!
non such - July 24, 2016, 9:08 a.m.
Efraim Flashner <efraim@flashner.co.il> writes:

> On Fri, Jul 22, 2016 at 12:05:46AM +0000, ng0 wrote:
>> From d841892a6563fa79f8185d6ea470a160d1b54b2c Mon Sep 17 00:00:00 2001
>> From: ng0 <ng0@we.make.ritual.n0.is>
>> Date: Fri, 22 Jul 2016 00:01:03 +0000
>> Subject: [PATCH] gnu: perl-io-socket-ssl: Add IDN support.
>> 
>> * gnu/packages/web.scm (perl-io-socket-ssl)[propagated-inputs]: Add perl-uri
>> for IDN support.
>> ---
>>  gnu/packages/web.scm | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
>> index c2cae27..33c1e88 100644
>> --- a/gnu/packages/web.scm
>> +++ b/gnu/packages/web.scm
>> @@ -2401,7 +2401,10 @@ and IPv6 sockets, intended as a replacement for IO::Socket::INET.")
>>                (patches (search-patches
>>                          "perl-io-socket-ssl-openssl-1.0.2f-fix.patch"))))
>>      (build-system perl-build-system)
>> -    (propagated-inputs `(("perl-net-ssleay" ,perl-net-ssleay)))
>> +    (propagated-inputs
>> +     `(("perl-net-ssleay" ,perl-net-ssleay)
>> +       ;; for IDN support
>> +       ("perl-uri" ,perl-uri)))
>>      (synopsis "Nearly transparent SSL encapsulation for IO::Socket::INET")
>>      (description
>>       "IO::Socket::SSL makes using SSL/TLS much easier by wrapping the
>> -- 
>> 2.9.1

>
> LGTM!

What does this mean? LetsGetThisMerged?
Efraim Flashner - July 24, 2016, 1:08 p.m.
On Sun, Jul 24, 2016 at 09:08:05AM +0000, ng0 wrote:
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > On Fri, Jul 22, 2016 at 12:05:46AM +0000, ng0 wrote:
> >> From d841892a6563fa79f8185d6ea470a160d1b54b2c Mon Sep 17 00:00:00 2001
> >> From: ng0 <ng0@we.make.ritual.n0.is>
> >> Date: Fri, 22 Jul 2016 00:01:03 +0000
> >> Subject: [PATCH] gnu: perl-io-socket-ssl: Add IDN support.
> >> 
> >> * gnu/packages/web.scm (perl-io-socket-ssl)[propagated-inputs]: Add perl-uri
> >> for IDN support.
> >> ---
> >>  gnu/packages/web.scm | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> >> index c2cae27..33c1e88 100644
> >> --- a/gnu/packages/web.scm
> >> +++ b/gnu/packages/web.scm
> >> @@ -2401,7 +2401,10 @@ and IPv6 sockets, intended as a replacement for IO::Socket::INET.")
> >>                (patches (search-patches
> >>                          "perl-io-socket-ssl-openssl-1.0.2f-fix.patch"))))
> >>      (build-system perl-build-system)
> >> -    (propagated-inputs `(("perl-net-ssleay" ,perl-net-ssleay)))
> >> +    (propagated-inputs
> >> +     `(("perl-net-ssleay" ,perl-net-ssleay)
> >> +       ;; for IDN support
> >> +       ("perl-uri" ,perl-uri)))
> >>      (synopsis "Nearly transparent SSL encapsulation for IO::Socket::INET")
> >>      (description
> >>       "IO::Socket::SSL makes using SSL/TLS much easier by wrapping the
> >> -- 
> >> 2.9.1
> 
> >
> > LGTM!
> 
> What does this mean? LetsGetThisMerged?
> 

Yeah

> -- 
> ♥Ⓐ  ng0 – http://we.make.ritual.n0.is
> For non-prism friendly talk find me on http://www.psyced.org
> SecuShare – http://secushare.org
>
Leo Famulari - July 24, 2016, 4:05 p.m.
On Sun, Jul 24, 2016 at 04:08:20PM +0300, Efraim Flashner wrote:
> On Sun, Jul 24, 2016 at 09:08:05AM +0000, ng0 wrote:
> > Efraim Flashner <efraim@flashner.co.il> writes:
> > > LGTM!
> > 
> > What does this mean? LetsGetThisMerged?
> 
> Yeah

I thought it meant Looks Good To Me, although yours works too :)
John Darrington - July 24, 2016, 4:19 p.m.
On Sun, Jul 24, 2016 at 12:05:35PM -0400, Leo Famulari wrote:
     On Sun, Jul 24, 2016 at 04:08:20PM +0300, Efraim Flashner wrote:
     > On Sun, Jul 24, 2016 at 09:08:05AM +0000, ng0 wrote:
     > > Efraim Flashner <efraim@flashner.co.il> writes:
     > > > LGTM!
     > > 
     > > What does this mean? LetsGetThisMerged?
     > 
     > Yeah
     
     I thought it meant Looks Good To Me, although yours works too :)

I'm glad that has been explained.  I always assumed it was Lesbian Gay Transgender Martian.
J'
non such - Aug. 7, 2016, 10:40 p.m.
John Darrington <john@darrington.wattle.id.au> writes:

> On Sun, Jul 24, 2016 at 12:05:35PM -0400, Leo Famulari wrote:
>      On Sun, Jul 24, 2016 at 04:08:20PM +0300, Efraim Flashner wrote:
>      > On Sun, Jul 24, 2016 at 09:08:05AM +0000, ng0 wrote:
>      > > Efraim Flashner <efraim@flashner.co.il> writes:
>      > > > LGTM!
>      > > 
>      > > What does this mean? LetsGetThisMerged?
>      > 
>      > Yeah
>      
>      I thought it meant Looks Good To Me, although yours works too :)
>
> I'm glad that has been explained.  I always assumed it was Lesbian Gay Transgender Martian.
> J'
>

First, please don't do this.

Second, is there something left to fix or did someone push this already
and I did not notice?

thanks
Leo Famulari - Aug. 8, 2016, 8:52 p.m.
On Sun, Aug 07, 2016 at 10:40:47PM +0000, ng0 wrote:
> Second, is there something left to fix or did someone push this already
> and I did not notice?

I believe this patch corresponds to commit 578aeea6. Please let us know
if it does not.
non such - Aug. 8, 2016, 10:08 p.m.
Leo Famulari <leo@famulari.name> writes:

> On Sun, Aug 07, 2016 at 10:40:47PM +0000, ng0 wrote:
>> Second, is there something left to fix or did someone push this already
>> and I did not notice?
>
> I believe this patch corresponds to commit 578aeea6. Please let us know
> if it does not.

Indeed, it does.

Thanks.

Patch

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index c2cae27..33c1e88 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -2401,7 +2401,10 @@  and IPv6 sockets, intended as a replacement for IO::Socket::INET.")
               (patches (search-patches
                         "perl-io-socket-ssl-openssl-1.0.2f-fix.patch"))))
     (build-system perl-build-system)
-    (propagated-inputs `(("perl-net-ssleay" ,perl-net-ssleay)))
+    (propagated-inputs
+     `(("perl-net-ssleay" ,perl-net-ssleay)
+       ;; for IDN support
+       ("perl-uri" ,perl-uri)))
     (synopsis "Nearly transparent SSL encapsulation for IO::Socket::INET")
     (description
      "IO::Socket::SSL makes using SSL/TLS much easier by wrapping the