Patchwork gnu: Add mono.

login
register
mail settings
Submitter Jan Nieuwenhuizen
Date July 15, 2016, 7:32 p.m.
Message ID <87r3aud7dw.fsf@gnu.org>
Download mbox | patch
Permalink /patch/13813/
State New
Headers show

Comments

Jan Nieuwenhuizen - July 15, 2016, 7:32 p.m.
Jan Nieuwenhuizen writes:

Here is what I intended to send; find version 4.4.1.0 attached.

Greetings,
Jan
Leo Famulari - July 22, 2016, 3:55 p.m.
On Fri, Jul 15, 2016 at 09:32:43PM +0200, Jan Nieuwenhuizen wrote:
> Subject: [PATCH] gnu: Add mono.
> 
> * gnu/packages/mono.scm: New file.
> * gnu/packages/local.mk (GNU_SYSTEM_MODULES): Add it.

Thank you!

I assume this mono is working for you? I'm wondering if the problems
requiring skipped tests hide a larger problem or if it's benign.

Do you know if mono is supposed to work on all of our architectures? Or,
should we disable it on some of them?

> +              (snippet

Did you try doing these substitutions in a build phase? The origin
snippet affects what you get from `guix build --source mono`, so we tend
to reserve it for removing non-free components, so that we don't
distribute things that we don't have a right to distribute.

> +                  ;; tests fail, trying to access $HOME
> +                  (substitute* "mcs/class/Makefile"
> +                    (("^include ../build/rules.make" all)
> +                     (string-append
> +                      all
> +                      "\nrun-test-recursive:\n\t@echo skipping tests\n")))

After moving this into a build phase, there could be a prior phase
'set-env' that just sets $HOME to '/tmp'. Can you check if that works?

> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("gettext" ,gnu-gettext)
> +       ("glib" ,glib)

I notice many uses of glib:bin rather than the full glib output. But,
to be honest, I don't understand the distinction ;)

> +     ;; these 3 tests fail
> +     `(#:make-flags
> +       `(,(string-append "PLATFORM_DISABLED_TESTS="
> +                         " appdomain-unload.exe"
> +                         " delegate2.exe"
> +                         " finally_guard.exe"
> +                         " remoting4.exe"))

4 tests?

> +       #:parallel-tests? #f))

Parallel testing is not supported? Let's add a comment.

> +    (home-page "http://mono-project.org/")

s/org/com/

Patch

From cd4bfa9478c855fa2d212336a99941e473a5c0c5 Mon Sep 17 00:00:00 2001
From: Jan Nieuwenhuizen <janneke@gnu.org>
Date: Wed, 13 Jul 2016 14:47:55 +0200
Subject: [PATCH] gnu: Add mono.

* gnu/packages/mono.scm: New file.
* gnu/packages/local.mk (GNU_SYSTEM_MODULES): Add it.
---
 gnu/local.mk          |  1 +
 gnu/packages/mono.scm | 98 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 99 insertions(+)
 create mode 100644 gnu/packages/mono.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 3a0d5c2..dfc038f 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -236,6 +236,7 @@  GNU_SYSTEM_MODULES =				\
   %D%/packages/mg.scm				\
   %D%/packages/mit-krb5.scm			\
   %D%/packages/moe.scm				\
+  %D%/packages/mono.scm				\
   %D%/packages/moreutils.scm			\
   %D%/packages/mpd.scm				\
   %D%/packages/mp3.scm				\
diff --git a/gnu/packages/mono.scm b/gnu/packages/mono.scm
new file mode 100644
index 0000000..f0f715e
--- /dev/null
+++ b/gnu/packages/mono.scm
@@ -0,0 +1,98 @@ 
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages mono)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages perl)
+  #:use-module (gnu packages python)
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix git-download)
+  #:use-module (guix build-system gnu))
+
+(define-public mono
+  (package
+    (name "mono")
+    (version "4.4.1.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "http://download.mono-project.com/sources/mono/"
+                    name "-" version
+                    ".tar.bz2"))
+              (modules '((guix build utils)))
+              (snippet
+               '(begin
+                  (substitute* "mono/tests/Makefile.in"
+                    ;; does not build: no rule to make unhandled-exception-*
+                    (("@test-unhandled-exception-2:" all)
+                     (string-append all "#")))
+                  (substitute* "mcs/tools/mono-symbolicate/Makefile"
+                    ;; does not build: Source file `Test/StackTraceDumper.cs'
+                    ;; could not be found
+                    (("^check: test-local") "check:\ntest-local:")
+                    (("^test-local: all") "disabled-test-local:"))
+                  (substitute* "mono/unit-tests/Makefile.in"
+                    ;; test fails
+                    (("^test-sgen-qsort.log:")
+                     "disabled-test-sgen-qsort.log:\ntest-sgen-qsort.log:"))
+                  ;; tests fail, trying to access $HOME
+                  (substitute* "mcs/class/Makefile"
+                    (("^include ../build/rules.make" all)
+                     (string-append
+                      all
+                      "\nrun-test-recursive:\n\t@echo skipping tests\n")))
+                  (substitute* '("mcs/tools/mono-shlib-cop/Makefile"
+                                 "mcs/tools/mdoc/Makefile")
+                    (("^run-test-local:" all)
+                     (string-append "#" all)))
+                  (substitute* "mcs/tools/sqlmetal/Makefile"
+                    (("^include ../../build/rules.make" all)
+                     (string-append
+                      "NO_TEST:=true\n"
+                      all
+                      "\nrun-test-lib:\n\t@echo skipping test\n")))))
+              (sha256
+               (base32
+                "0jibyvyv2jy8dq5ij0j00iq3v74r0y90dcjc3dkspcfbnn37cphn"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("gettext" ,gnu-gettext)
+       ("glib" ,glib)
+       ("libxslt" ,libxslt)
+       ("perl" ,perl)
+       ("python" ,python-2)))
+    (arguments
+     ;; these 3 tests fail
+     `(#:make-flags
+       `(,(string-append "PLATFORM_DISABLED_TESTS="
+                         " appdomain-unload.exe"
+                         " delegate2.exe"
+                         " finally_guard.exe"
+                         " remoting4.exe"))
+       #:parallel-tests? #f))
+    (synopsis "Compiler and libraries for the C# programming language")
+    (description "Mono is a compiler, vm, debugger and set of libraries for
+C#, a C-style programming language from Microsoft that is very similar to
+Java.")
+    (home-page "http://mono-project.org/")
+    (license license:x11)))
-- 
2.8.4