Patchwork [2/2] gnu: Add gnome-mpv.

login
register
mail settings
Submitter Alex Griffin
Date July 7, 2016, 2:39 p.m.
Message ID <1467902388.677813.659579777.62341118@webmail.messagingengine.com>
Download mbox | patch
Permalink /patch/13697/
State New
Headers show

Comments

Alex Griffin - July 7, 2016, 2:39 p.m.
On Thu, Jul 7, 2016, at 02:10 AM, Ricardo Wurmus wrote:
> > +       (uri (string-append "https://github.com/gnome-mpv/gnome-mpv/releases/download/v"
> > +                           version "/gnome-mpv-" version ".tar.xz"))
> 
> This line looks a bit long to me.  Have you checked with “guix lint
> gnome-mpv”?

Actually, yes I did, and it didn't catch it. Maybe there's a bug in the
linter?

Anyway, here's an updated patch. In addition to correcting the long
line, I also tweaked the synopsis and description to make clear that
this is a media player, for the benefit of anyone who hasn't heard of
mpv.
Eric Bavier - July 7, 2016, 5:07 p.m.
On July 7, 2016 9:39:48 AM CDT, Alex Griffin <a@ajgrf.com> wrote:
>On Thu, Jul 7, 2016, at 02:10 AM, Ricardo Wurmus wrote:
>> > +       (uri (string-append
>"https://github.com/gnome-mpv/gnome-mpv/releases/download/v"
>> > +                           version "/gnome-mpv-" version
>".tar.xz"))
>> 
>> This line looks a bit long to me.  Have you checked with “guix lint
>> gnome-mpv”?
>
>Actually, yes I did, and it didn't catch it. Maybe there's a bug in the
>linter?

The linter is slightly tolerant and will accept lines under 90 characters IIRC. 

>Anyway, here's an updated patch. In addition to correcting the long
>line, I also tweaked the synopsis and description to make clear that
>this is a media player, for the benefit of anyone who hasn't heard of
>mpv.
Efraim Flashner - July 7, 2016, 5:17 p.m.
On Thu, Jul 07, 2016 at 09:39:48AM -0500, Alex Griffin wrote:
> On Thu, Jul 7, 2016, at 02:10 AM, Ricardo Wurmus wrote:
> > > +       (uri (string-append "https://github.com/gnome-mpv/gnome-mpv/releases/download/v"
> > > +                           version "/gnome-mpv-" version ".tar.xz"))
> > 
> > This line looks a bit long to me.  Have you checked with “guix lint
> > gnome-mpv”?
> 
> Actually, yes I did, and it didn't catch it. Maybe there's a bug in the
> linter?

The linkter checks that there aren't any lines over 90 characters, to
allow for incredibly long urls and super-indented code.

> 
> Anyway, here's an updated patch. In addition to correcting the long
> line, I also tweaked the synopsis and description to make clear that
> this is a media player, for the benefit of anyone who hasn't heard of
> mpv.
> -- 
> Alex Griffin
Efraim Flashner - July 10, 2016, 4:13 a.m.
On Thu, Jul 07, 2016 at 09:39:48AM -0500, Alex Griffin wrote:
> On Thu, Jul 7, 2016, at 02:10 AM, Ricardo Wurmus wrote:
> > > +       (uri (string-append "https://github.com/gnome-mpv/gnome-mpv/releases/download/v"
> > > +                           version "/gnome-mpv-" version ".tar.xz"))
> > 
> > This line looks a bit long to me.  Have you checked with “guix lint
> > gnome-mpv”?
> 
> Actually, yes I did, and it didn't catch it. Maybe there's a bug in the
> linter?
> 
> Anyway, here's an updated patch. In addition to correcting the long
> line, I also tweaked the synopsis and description to make clear that
> this is a media player, for the benefit of anyone who hasn't heard of
> mpv.
> -- 
> Alex Griffin

packaged pushed!

Patch

From e3f40673b6883bba023eec9eb8995df97d9245fd Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Wed, 6 Jul 2016 18:58:17 -0500
Subject: [PATCH 2/2] gnu: Add gnome-mpv.

* gnu/packages/video.scm (gnome-mpv): New variable.
---
 gnu/packages/video.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ae1813d..6888e36 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -33,6 +33,7 @@ 
   #:use-module (guix git-download)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system python)
   #:use-module (guix build-system waf)
   #:use-module (gnu packages)
@@ -829,6 +830,34 @@  fork of mplayer2 and MPlayer.  It shares some features with the former
 projects while introducing many more.")
     (license license:gpl2+)))
 
+(define-public gnome-mpv
+  (package
+    (name "gnome-mpv")
+    (version "0.9")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/gnome-mpv/gnome-mpv/releases"
+                           "/download/v" version "/gnome-mpv-" version
+                           ".tar.xz"))
+       (sha256
+        (base32
+         "06pgxl6f3kkgxv8nlmyl7gy3pg55sqf8vgr8m6426mlpm4p3qdn0"))))
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("libepoxy" ,libepoxy)
+       ("mpv" ,mpv)))
+    (build-system glib-or-gtk-build-system)
+    (home-page "https://github.com/gnome-mpv/gnome-mpv")
+    (synopsis "GTK+ frontend for the mpv media player")
+    (description "GNOME MPV is a simple GTK+ frontend for the mpv media player.
+GNOME MPV interacts with mpv via the client API exported by libmpv, allowing
+access to mpv's powerful playback capabilities.")
+    (license license:gpl3+)))
+
 (define-public libvpx
   (package
     (name "libvpx")
-- 
2.9.0