Message ID | b6881e06-a9a2-7d03-29c3-71532a69b19c@gmail.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 11211 invoked by alias); 30 Jun 2016 15:44:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 11202 invoked by uid 89); 30 Jun 2016 15:44:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-0.3 required=5.0 tests=AWL, BAYES_00, BODY_8BITS, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GARBLED_BODY, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=no version=3.3.2 spammy=ribbon, =d0=be=d0=b2, rights?= X-HELO: mail-lf0-f67.google.com Received: from mail-lf0-f67.google.com (HELO mail-lf0-f67.google.com) (209.85.215.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 30 Jun 2016 15:44:38 +0000 Received: by mail-lf0-f67.google.com with SMTP id l188so8836489lfe.0 for <gdb-patches@sourceware.org>; Thu, 30 Jun 2016 08:44:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=9lvjsa3OCaw5LBWSmNfyY9OXcx3pvde0MBc7XwPtaow=; b=gXVlSYESnCdsjdjdPcv1FZoC580ofyZSgSgwMUaV6EYTvYOSh+O45pEBTxmKcJUXus bPVWcQv1G6WutvgNxWcnOUeZi3YOqPI3y+RAsAiG8UGjC8SinDyoBTeZzRRTLEyex97E iKJnBcxZX9nvB6A2qekD0YtoRE1zGTixCOLOPe//4562sM+rBtCLUF8krMENHQsv5UGk 4RQ7V/l/RPo4u1FV84gDOz0SEK8UQLZX1+sGxQPKbrQc5zVu5ME2blSaAGBu84gp1AeA PVIAohtFey2UePLb7C1yER+7q9QBCTzdvpfUu4JOxVl/kVeBhuXcU1TzEHVJmlnaL9Tf dCGg== X-Gm-Message-State: ALyK8tLCdMpqhB+BtY0NhTHxH/PubvoZkAw/4glMQkGx7XiWCOy2QBnUI/ikcNhDF7ubow== X-Received: by 10.46.33.15 with SMTP id h15mr4489480ljh.36.1467301473552; Thu, 30 Jun 2016 08:44:33 -0700 (PDT) Received: from [192.168.4.39] (broadband-95-84-200-6.nationalcablenetworks.ru. [95.84.200.6]) by smtp.gmail.com with ESMTPSA id o93sm1638691lfi.5.2016.06.30.08.44.32 for <gdb-patches@sourceware.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jun 2016 08:44:32 -0700 (PDT) Subject: Re: [Bug win32/14529] Make gdb capable of JIT-debugging on W32 To: gdb-patches@sourceware.org References: <503E575D.1000608@gmail.com> <m3k3v9byys.fsf@redhat.com> <506A1DB5.60901@gmail.com> <m3626t8lne.fsf@redhat.com> <20121002124819.GB3028@adacore.com> <506AE4C6.9010304@gmail.com> <4be546e0-7811-6f51-e5a4-d441e8a9d16a@gmail.com> <83oa6ivgve.fsf@gnu.org> From: LRN <lrn1986@gmail.com> Message-ID: <b6881e06-a9a2-7d03-29c3-71532a69b19c@gmail.com> Date: Thu, 30 Jun 2016 18:44:28 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Thunderbird/49.0a1 MIME-Version: 1.0 In-Reply-To: <83oa6ivgve.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DrnPg8G4etdcRQvcvOVI4UurRSxhtPQ2D" |
Commit Message
LRN
June 30, 2016, 3:44 p.m. UTC
On 30.06.2016 18:25, Eli Zaretskii wrote: >> From: LRN <lrn1986@gmail.com> >> Date: Thu, 30 Jun 2016 16:16:40 +0300 >> >> I did the paperwork and now my rights on code that will be included in gdb >> are assigned to FSF. >> So i'm upping the thread. Also, attaching a version of the patch that can >> be applied to current git master. > > Thanks. The documentation change is approved, but please include a > NEWS entry, and also please show the ChangeLog entries for the > changes. > Attached the NEWS and ChangeLog patches. There's also a bug report[1] that will have to be updated/closed (it also has obsolete patch and ChangeLog entries attached). [1] https://sourceware.org/bugzilla/show_bug.cgi?id=14529
Comments
> From: LRN <lrn1986@gmail.com> > Date: Thu, 30 Jun 2016 18:44:28 +0300 > > > Thanks. The documentation change is approved, but please include a > > NEWS entry, and also please show the ChangeLog entries for the > > changes. > > > Attached the NEWS and ChangeLog patches. Thanks, but please format the ChangeLog entries according to our coding standards. You should be able to see many examples in the repository. The NEWS entry is OK, but this sentence: > +signal-event EVENTID > + Signal ("set") given Windows event object. lacks "the". IOW, say "Signal the given Windows event object."
On 30.06.2016 19:23, Eli Zaretskii wrote: > On Thu, 30 Jun 2016 18:44:28 +0300, LRN wrote: >>> Thanks. The documentation change is approved, but please include a >>> NEWS entry, and also please show the ChangeLog entries for the >>> changes. >>> >> Attached the NEWS and ChangeLog patches. > > Thanks, but please format the ChangeLog entries according to our > coding standards. You should be able to see many examples in the > repository. I did. What did i do wrong? Had a single space (instead of two spaces) after the name? Used "Fix PR gdb/14529" at the end instead of "PR gdb/14529" at the beginning? No function name in parentheses (should it have been signal_event_command?)? Can't spot any other differences.
> From: LRN <lrn1986@gmail.com> > Date: Thu, 30 Jun 2016 20:18:52 +0300 > > > Thanks, but please format the ChangeLog entries according to our > > coding standards. You should be able to see many examples in the > > repository. > > I did. What did i do wrong? Had a single space (instead of two spaces) > after the name? Used "Fix PR gdb/14529" at the end instead of "PR > gdb/14529" at the beginning? No function name in parentheses (should it > have been signal_event_command?)? The latter.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e98a565..891d125 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2016-06-30 РуÑлан Ижбулатов <lrn1986@gmail.com> + + * windows-nat.c: New command 'signal-event' for W32 compatibility + * gdb.texinfo: document the new 'signal-event' command. + * NEWS: Add an entry about the new 'signal-event' command. + Fix PR gdb/14529. + 2016-06-25 Tom Tromey <tom@tromey.com> * rust-lang.c (rust_get_disr_info, rust_print_type): Fix