Patchwork Emacs Zenburn

login
register
mail settings
Submitter Catonano
Date May 17, 2016, 10:12 a.m.
Message ID <CAJ98PDzeybD_Y9_3xZ=DnuCd-ohdvu_krgvNgf4U5cDKTX9-3Q@mail.gmail.com>
Download mbox | patch
Permalink /patch/12306/
State New
Headers show

Comments

Catonano - May 17, 2016, 10:12 a.m.
Alex,

thank you so much for your comments

2016-05-16 16:18 GMT+02:00 Alex Kost <alezost@gmail.com>:

>
> Could you send an updated patch please


I made a new patch trying to adhere to your indications

Only, I'm having troubles with git-send-email so now I'm trying to attach
the new patch to this email in a different way, maybe this time you can
access it ?

Please let me know
Thanks
Alex Kost - May 17, 2016, 6:10 p.m.
Catonano (2016-05-17 13:12 +0300) wrote:

> I made a new patch trying to adhere to your indications
>
> Only, I'm having troubles with git-send-email so now I'm trying to attach
> the new patch to this email in a different way, maybe this time you can
> access it ?

Yes, perfect, thanks!

> From 359d604b8cfb42726efc932a9002e7d69f439f83 Mon Sep 17 00:00:00 2001
> From: humanitiesNerd <catonano@gmail.com>
> Date: Tue, 17 May 2016 10:54:13 +0200
> Subject: [PATCH] gnu: Add emacs-zenburn-theme

As I wrote in the previous message, the commit message should be:

  gnu: Add emacs-zenburn-theme.

  * gnu/packages/emacs.scm (emacs-zenburn-theme): New variable.

Please keep it in mind next time ;-)

> ---
>  gnu/packages/emacs.scm (emacs-zenburn-theme): New variable | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index f0c1555..8bfcf5b 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1590,3 +1590,28 @@ to recognize a name like \"RFC 1234\".  This package enhances ffap so
>  that it correctly finds RFCs even when a space appears before the
>  number.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-zenburn-theme
> +  (package
> +    (name "emacs-zenburn-theme")
> +    (version "2.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/bbatsov/zenburn-emacs/archive/v"
> +             version
> +             ".tar.gz"))

"guix lint emacs-zenburn-theme" reports that «the source file name
should contain the package name».  This happens because (by default)
this tarball has the following name in the store:

  /gnu/store/…-v2.4.tar.gz

It is better to have something more understandable, like:

  /gnu/store/…-emacs-zenburn-theme-2.4.tar.gz

This can be achieved by adding the following line to the 'origin':

  (file-name (string-append name "-" version ".tar.gz"))

> +       (sha256
> +        (base32
> +         "0lyi84bm8sa7vj40n6zg6rlbsmi53mi1y9xn6gkjj29s5zbcnlg7"))))
> +    (build-system emacs-build-system)
> +    (home-page "http://github.com/bbatsov/zenburn-emacs")
> +    (synopsis
> +     "Low contrast color theme for Emacs")
> +    (description
> +     "Zenburn theme is a port of the popular Vim Zenburn theme for Emacs.
> +It is built on top of the custom theme support in Emacs 24 or later")
> +    (license license:gpl3+)))

I made the mentioned changes, added a copyright line for you and
committed it as 9576cc7¹.  Thanks for contributing!

¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=9576cc72dc4f2973551c72951e64e5bf6240ff6b
Catonano - May 17, 2016, 8:10 p.m.
2016-05-17 20:10 GMT+02:00 Alex Kost <alezost@gmail.com>:

> Catonano (2016-05-17 13:12 +0300) wrote:
>
> > I made a new patch trying to adhere to your indications
> >
> > Only, I'm having troubles with git-send-email so now I'm trying to attach
> > the new patch to this email in a different way, maybe this time you can
> > access it ?
>
> Yes, perfect, thanks!
>
> > From 359d604b8cfb42726efc932a9002e7d69f439f83 Mon Sep 17 00:00:00 2001
> > From: humanitiesNerd <catonano@gmail.com>
> > Date: Tue, 17 May 2016 10:54:13 +0200
> > Subject: [PATCH] gnu: Add emacs-zenburn-theme
>
> As I wrote in the previous message, the commit message should be:
>
>   gnu: Add emacs-zenburn-theme.
>
>   * gnu/packages/emacs.scm (emacs-zenburn-theme): New variable.
>
> Please keep it in mind next time ;-)
>
>
I was sure I had reached the right format.
I took a look at the patch as you published. Note taken.


>
> "guix lint emacs-zenburn-theme" reports that «the source file name
> should contain the package name».  This happens because (by default)
> this tarball has the following name in the store:
>
>   /gnu/store/…-v2.4.tar.gz
>
> It is better to have something more understandable, like:
>
>   /gnu/store/…-emacs-zenburn-theme-2.4.tar.gz
>
> This can be achieved by adding the following line to the 'origin':
>
>   (file-name (string-append name "-" version ".tar.gz"))
>

Sorry, it slipped. Thank you for fixing that


>
> I made the mentioned changes, added a copyright line for you and
> committed it as 9576cc7¹.  Thanks for contributing!
>
> ¹
> http://git.savannah.gnu.org/cgit/guix.git/commit/?id=9576cc72dc4f2973551c72951e64e5bf6240ff6b
>
>
It was a pleasure !

Thank you Alex ;-)

Patch

From 359d604b8cfb42726efc932a9002e7d69f439f83 Mon Sep 17 00:00:00 2001
From: humanitiesNerd <catonano@gmail.com>
Date: Tue, 17 May 2016 10:54:13 +0200
Subject: [PATCH] gnu: Add emacs-zenburn-theme

---
 gnu/packages/emacs.scm (emacs-zenburn-theme): New variable | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index f0c1555..8bfcf5b 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1590,3 +1590,28 @@  to recognize a name like \"RFC 1234\".  This package enhances ffap so
 that it correctly finds RFCs even when a space appears before the
 number.")
     (license license:gpl3+)))
+
+(define-public emacs-zenburn-theme
+  (package
+    (name "emacs-zenburn-theme")
+    (version "2.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/bbatsov/zenburn-emacs/archive/v"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0lyi84bm8sa7vj40n6zg6rlbsmi53mi1y9xn6gkjj29s5zbcnlg7"))))
+    (build-system emacs-build-system)
+    (home-page "http://github.com/bbatsov/zenburn-emacs")
+    (synopsis
+     "Low contrast color theme for Emacs")
+    (description
+     "Zenburn theme is a port of the popular Vim Zenburn theme for Emacs.
+It is built on top of the custom theme support in Emacs 24 or later")
+    (license license:gpl3+)))
+
+
-- 
2.5.5