Patchwork gnu: pulseaudio: Enable support for Bluetooth.

login
register
mail settings
Submitter Ricardo Wurmus
Date May 14, 2016, 9:43 a.m.
Message ID <1463219008-23189-2-git-send-email-rekado@elephly.net>
Download mbox | patch
Permalink /patch/12252/
State New
Headers show

Comments

Ricardo Wurmus - May 14, 2016, 9:43 a.m.
* gnu/packages/pulseaudio.scm (pulseaudio)[arguments]: Add
"--enable-bluez5" to configure flags.
[inputs]: Add "bluez" and "sbc".
---
 gnu/packages/pulseaudio.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Ludovic Courtès - May 16, 2016, 9:01 p.m.
Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/pulseaudio.scm (pulseaudio)[arguments]: Add
> "--enable-bluez5" to configure flags.
> [inputs]: Add "bluez" and "sbc".

I think it’s a reasonable change.

Ideally a ‘pulseaudio-updates’ branch would be the right thing.
However, if it builds and works as expected on master (at least make
sure ‘guix gc --references’ shows bluez and SBC), then it’s OK to commit
to ‘core-updates’ since it looks like a non-disruptive change.

Thanks!

Ludo’.
Ricardo Wurmus - June 28, 2016, 6:36 a.m.
Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/pulseaudio.scm (pulseaudio)[arguments]: Add
>> "--enable-bluez5" to configure flags.
>> [inputs]: Add "bluez" and "sbc".
>
> I think it’s a reasonable change.
>
> Ideally a ‘pulseaudio-updates’ branch would be the right thing.
> However, if it builds and works as expected on master (at least make
> sure ‘guix gc --references’ shows bluez and SBC), then it’s OK to commit
> to ‘core-updates’ since it looks like a non-disruptive change.

I’ve just pushed it to core-updates.  Thanks!

~~ Ricardo

Patch

diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
index b2b0508..2d97539 100644
--- a/gnu/packages/pulseaudio.scm
+++ b/gnu/packages/pulseaudio.scm
@@ -2,6 +2,7 @@ 
 ;;; Copyright © 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2014, 2015, 2016 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -138,6 +139,7 @@  rates.")
     (arguments
      `(#:configure-flags (list "--localstatedir=/var" ;"--sysconfdir=/etc"
                                "--disable-oss-output"
+                               "--enable-bluez5"
                                (string-append "--with-udev-rules-dir="
                                               (assoc-ref %outputs "out")
                                               "/lib/udev/rules.d"))
@@ -153,8 +155,9 @@  rates.")
                  %standard-phases)))
     (inputs
      ;; TODO: Add optional inputs (GTK+?).
-     `(;; ("sbc" ,sbc)
-       ("alsa-lib" ,alsa-lib)
+     `(("alsa-lib" ,alsa-lib)
+       ("bluez" ,bluez)
+       ("sbc" ,sbc)
        ("json-c" ,json-c)
        ("speex" ,speex)
        ("libsndfile" ,libsndfile)