Patchwork system: Do not export PS1 in /etc/skel/.bashrc.

login
register
mail settings
Submitter Alex Griffin
Date May 5, 2016, 3:07 p.m.
Message ID <1462460842.3188118.599119297.5D5C232E@webmail.messagingengine.com>
Download mbox | patch
Permalink /patch/12022/
State New
Headers show

Comments

Alex Griffin - May 5, 2016, 3:07 p.m.
There's really no reason for other programs to need to see your bash
prompt, so I removed a couple `export` keywords from the default bashrc.
Alex Griffin - May 5, 2016, 3:17 p.m.
Also, is this a large enough change that I should I have added my name
to the copyright notice? I have a few more patches nearly ready to
submit once I figure out this process, and I'm wondering what the
threshold is. What if all I do is update a version number+hash?

Thanks,
Efraim Flashner - May 5, 2016, 10:34 p.m.
On Thu, May 05, 2016 at 10:17:36AM -0500, Alex Griffin wrote:
> Also, is this a large enough change that I should I have added my name
> to the copyright notice? I have a few more patches nearly ready to
> submit once I figure out this process, and I'm wondering what the
> threshold is. What if all I do is update a version number+hash?
> 
> Thanks,
> -- 
> Alex Griffin
> 

I'm totally not a lawyer, but I believe officially and legally any
change you make is yours and needs/should have a copyright line.
On the other side, I believe that if you make a change and don't
attach your name to it then it's as if you've tossed it into the file
with all the other commits there and it can be assumed to follow the
rest of the file/project in terms of copyright.

Patch

From 597c788a6604bcd84a24a469d92c1fbd47f4bedb Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Thu, 5 May 2016 09:59:03 -0500
Subject: [PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

---
 gnu/system/shadow.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/system/shadow.scm b/gnu/system/shadow.scm
index a13ef11..1aa4422 100644
--- a/gnu/system/shadow.scm
+++ b/gnu/system/shadow.scm
@@ -166,9 +166,9 @@  fi
 # Adjust the prompt depending on whether we're in 'guix environment'.
 if [ -n \"$GUIX_ENVIRONMENT\" ]
 then
-    export PS1='\\u@\\h \\w [env]\\$ '
+    PS1='\\u@\\h \\w [env]\\$ '
 else
-    export PS1='\\u@\\h \\w\\$ '
+    PS1='\\u@\\h \\w\\$ '
 fi
 alias ls='ls -p --color'
 alias ll='ls -l'\n"))
-- 
2.7.4