From patchwork Tue May 27 21:28:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Don Breazeal X-Patchwork-Id: 1175 Received: (qmail 21326 invoked by alias); 27 May 2014 21:28:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 21315 invoked by uid 89); 27 May 2014 21:28:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 May 2014 21:28:43 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1WpOvH-0005gA-MK from donb@codesourcery.com ; Tue, 27 May 2014 14:28:39 -0700 Received: from [127.0.0.1] ([172.30.2.61]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 27 May 2014 14:28:39 -0700 Message-ID: <53850386.1040205@codesourcery.com> Date: Tue, 27 May 2014 14:28:38 -0700 From: "Breazeal, Don" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Document RSP support for Linux exec events References: <1398885482-8449-1-git-send-email-donb@codesourcery.com> <1400885374-18915-4-git-send-email-donb@codesourcery.com> <83d2f3lk23.fsf@gnu.org> In-Reply-To: <83d2f3lk23.fsf@gnu.org> X-IsSubscribed: yes On 5/24/2014 12:20 AM, Eli Zaretskii wrote: >> From: Don Breazeal >> Date: Fri, 23 May 2014 15:49:33 -0700 >> >> This patch adds documentation of the new RSP support for exec events. > > Thanks. > >> +@cindex exec events, remote reply >> +@item exec >> +The packet indicates that @code{execve} was called, and @var{r} is the >> +absolute pathname of the file that was executed, in hex. > > Please use "file name". GNU coding standards frown on using > "pathname" in this context. OK. > >> This is >> +only applicable to certain targets. > > What is "only applicable to certain targets", the packet or the fact > that R is the file name of the exec'ed process? Point taken. It's the packet. > > I also think you should mention the fact that gdbserver supports > follow-exec-mode in the "Forks" node, as the text there does sound as > if this is only supported in native debugging. OK. Updated patch follows below. Thanks for checking this over, --Don gdb/ 2014-05-27 Don Breazeal * NEWS: Mention RSP Stop Reply Packet, new stop reason 'exec'. Mention gdbserver support for exec events on Linux. doc/ 2014-05-27 Don Breazeal * gdb.texinfo (Stop Reply Packets): Document RSP support and gdbserver support for remote Linux exec events. --- gdb/NEWS | 6 ++++++ gdb/doc/gdb.texinfo | 9 ++++++++- 2 files changed, 14 insertions(+), 1 deletions(-) @kindex set follow-exec-mode @@ -34589,6 +34590,12 @@ The packet indicates that the loaded libraries have changed. @value{GDBN} should use @samp{qXfer:libraries:read} to fetch a new list of loaded libraries. @var{r} is ignored. +@cindex exec events, remote reply +@item exec +The packet indicates that @code{execve} was called, and @var{r} is the +absolute file name of the file that was executed, in hex. This packet +is only applicable to certain targets. + @cindex replay log events, remote reply @item replaylog The packet indicates that the target cannot continue replaying diff --git a/gdb/NEWS b/gdb/NEWS index b23c8a0..ffe3520 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -69,6 +69,8 @@ maint ada show ignore-descriptive-types Timestamps can also be turned on with the "monitor set debug-format timestamps" command from GDB. + ** GDBserver on GNU/Linux now supports exec events (follow-exec-mode). + * The 'record instruction-history' command now starts counting instructions at one. This also affects the instruction ranges reported by the 'record function-call-history' command when given the /i modifier. @@ -103,6 +105,10 @@ qXfer:btrace:read's annex The qXfer:btrace:read packet supports a new annex 'delta' to read branch trace incrementally. +T Stop Reply Packet's reason + The T stop reply packet supports a new stop reason, 'exec', signifying + that the specified inferior executed a call to execve. + * Python Scripting ** Valid Python operations on gdb.Value objects representing diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 6092ff4..efe7603 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -3141,7 +3141,8 @@ process, use the @code{file} command with the parent executable name as its argument. By default, after an @code{exec} call executes, @value{GDBN} discards the symbols of the previous executable image. You can change this behaviour with the @w{@code{set follow-exec-mode}} -command. +command. This command is supported when connected to @code{gdbserver} +using @kbd{target extended-remote} as well as in native mode. @table @code