[pushed] Re: [PATCH v2 1/3] Target remote mode fork and exec tests

From: Don Breazeal <donb@codesourcery.com>

  On 12/8/2015 4:58 AM, Pedro Alves wrote:
> On 12/07/2015 10:14 PM, Don Breazeal wrote:
> 
>> +# In remote mode we cannot use the 'set args' command, and this
>> +# test requires it.
>> +if { [target_info exists gdb_protocol] } then {
>> +    if { [target_info gdb_protocol] == "remote" } then {
>> +	continue
>> +    }
>>  }
>>  
> 
> It looks a little odd to me not to merge that into a single if:
> 
> if { [target_info exists gdb_protocol]
>      && [target_info gdb_protocol] == "remote" } {
>    continue
> }
> 
> 
>>  if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
>> diff --git a/gdb/testsuite/gdb.threads/fork-plus-threads.exp b/gdb/testsuite/gdb.threads/fork-plus-threads.exp
>> index 2b34b6c..d5a915b 100644
>> --- a/gdb/testsuite/gdb.threads/fork-plus-threads.exp
>> +++ b/gdb/testsuite/gdb.threads/fork-plus-threads.exp
>> @@ -20,6 +20,14 @@
>>  #
>>  # See https://sourceware.org/bugzilla/show_bug.cgi?id=18600
>>  
>> +# In remote mode, we cannot continue debugging after all
>> +# inferiors have terminated, and this test requires that.
>> +if { [target_info exists gdb_protocol] } then {
>> +    if { [target_info gdb_protocol] == "remote" } then {
>> +	continue
>> +    }
>> +}
> 
> Likewise.

I made both of the changes suggested above.

> 
> In any case, this is OK.
> 
> Thanks,
> Pedro Alves
> 
This is now pushed.  The updated patch is attached.

From: Don Breazeal <donb@codesourcery.com>
Subject: [pushed][PATCH v3 1/3] Target remote mode fork and exec tests

This is the version of the patch that was pushed.  This version is
identical to v2 except for changing:

if { [target_info exists gdb_protocol] } then {
    if { [target_info gdb_protocol] == "remote" } then {
	continue
    }
}

to

if { [target_info exists gdb_protocol]
     && [target_info gdb_protocol] == "remote" } {
   continue
}

in gdb.base/foll-exec-mode.exp and gdb.threads/fork-plus-threads.exp.

Here is the commit message:

This patch updates tests for fork and exec events in target remote mode.
In the majority of cases this was a simple matter of removing some code
that disabled the test for target remote.  In a few cases the test needed
to be disabled; in those cases the gdb_protocol was checked instead of
using the [is_remote target] etc.

In a couple of cases we needed to use clean_restart, since target remote
doesn't support the run command, and in one case we had to modify an expect
expression to allow for a "multiprocess-style" ptid.

Tested with the patch that implemented target remote mode fork and exec
event support.

gdb/testsuite/ChangeLog:

	* gdb.base/execl-update-breakpoints.exp (main): Enable for target
	remote.
	* gdb.base/foll-exec-mode.exp (main): Disable for target remote.
	* gdb.base/foll-exec.exp (main): Enable for target remote.
	* gdb.base/foll-fork.exp (main): Likewise.
	* gdb.base/foll-vfork.exp (main): Likewise.
	* gdb.base/multi-forks.exp (main): Likewise, and use clean_restart.
	(proc continue_to_exit_bp_loc): Use clean_restart.
	* gdb.base/pie-execl.exp (main): Disable for target remote.
	* gdb.base/watch-vfork.exp (main): Enable for target remote.
	* gdb.mi/mi-nsthrexec.exp (main): Likewise.
	* gdb.threads/execl.exp (main): Likewise.
	* gdb.threads/fork-child-threads.exp (main): Likewise.
	* gdb.threads/fork-plus-threads.exp (main): Disable for target
	remote.
	* gdb.threads/fork-thread-pending.exp (main): Enable for target
	remote.
	* gdb.threads/linux-dp.exp (check_philosopher_stack): Allow
	pid.tid style ptids, instead of just tid.
	* gdb.threads/thread-execl.exp (main): Enable for target remote.
	* gdb.threads/watchpoint-fork.exp (main): Likewise.
	* gdb.trace/report.exp (use_collected_data): Allow pid.tid style
	ptids, instead of just tid.
---
 gdb/testsuite/ChangeLog                            | 26
++++++++++++++++++++++
 .../gdb.base/execl-update-breakpoints.exp          |  6 -----
 gdb/testsuite/gdb.base/foll-exec-mode.exp          |  7 ++++--
 gdb/testsuite/gdb.base/foll-exec.exp               |  4 ----
 gdb/testsuite/gdb.base/foll-fork.exp               |  4 ----
 gdb/testsuite/gdb.base/foll-vfork.exp              |  4 ----
 gdb/testsuite/gdb.base/multi-forks.exp             |  6 ++---
 gdb/testsuite/gdb.base/pie-execl.exp               | 10 +++++----
 gdb/testsuite/gdb.base/watch-vfork.exp             |  5 -----
 gdb/testsuite/gdb.mi/mi-nsthrexec.exp              |  5 -----
 gdb/testsuite/gdb.threads/execl.exp                |  4 ----
 gdb/testsuite/gdb.threads/fork-child-threads.exp   |  4 ----
 gdb/testsuite/gdb.threads/fork-plus-threads.exp    |  7 ++++++
 gdb/testsuite/gdb.threads/fork-thread-pending.exp  |  6 -----
 gdb/testsuite/gdb.threads/linux-dp.exp             |  4 ++--
 gdb/testsuite/gdb.threads/thread-execl.exp         |  5 -----
 gdb/testsuite/gdb.threads/watchpoint-fork.exp      |  5 -----
 gdb/testsuite/gdb.trace/report.exp                 |  2 +-
 18 files changed, 49 insertions(+), 65 deletions(-)

\t\]+${binfile}.*"
     }
 }

[pushed] Re: [PATCH v2 1/3] Target remote mode fork and exec tests

Commit Message

Patch