Message ID | 20200207150003.8383-3-shahab.vahedi@gmail.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 82058 invoked by alias); 7 Feb 2020 15:01:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 81319 invoked by uid 89); 7 Feb 2020 15:00:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=truly, HX-Languages-Length:1052, naively, wrong! X-HELO: mail-lf1-f66.google.com Received: from mail-lf1-f66.google.com (HELO mail-lf1-f66.google.com) (209.85.167.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Feb 2020 15:00:48 +0000 Received: by mail-lf1-f66.google.com with SMTP id n25so1738695lfl.0 for <gdb-patches@sourceware.org>; Fri, 07 Feb 2020 07:00:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=saiHTnaqU7AiHZ6kmLhd37qA04DQbNf51bUyPON+8vg=; b=cMs6IGRmD6dSP+hznCwCzNLneiVeAW1o2L8tkHElGNgTxEAp5JQoSUVZ7v4YhIv2PY HC7RcVdajW3zgD5ObT/jB5VBFXkFB2qKti4myAMyR12VxAJhVwd3da4LpncRxMIINalU DkgEIPMMwscZj0KHu8fTgpMZSHBTnGDgqgQw3UnoBgAZEoO2iM8sobyg0sBqSSblXtjt NfGjfVN2iYCoDkpuF1M9iVw5VG+A7/enoJVkojHQcfOHeXLjMDHB07Yh2lN1avLuhJiu 1oEFRr61xM57JcUlCrZU1Ijb2awL6W1ISlktAIB2IoMo1FkXFSol5/vUWeV/ou17Dywx GOKg== Return-Path: <shahab.vahedi@gmail.com> Received: from archie.internal.synopsys.com ([2a03:1b20:6:f011::2d]) by smtp.gmail.com with ESMTPSA id p136sm1184412lfa.8.2020.02.07.07.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2020 07:00:39 -0800 (PST) From: Shahab Vahedi <shahab.vahedi@gmail.com> To: gdb-patches@sourceware.org Cc: Shahab Vahedi <shahab@synopsys.com>, Shahab Vahedi <shahab.vahedi@gmail.com>, Francois Bedard <fbedard@synopsys.com>, Anton Kolesov <Anton.Kolesov@synopsys.com> Subject: [PATCH 02/14] gdb/testsuite: Skip fileio.exp for remote targets Date: Fri, 7 Feb 2020 15:59:51 +0100 Message-Id: <20200207150003.8383-3-shahab.vahedi@gmail.com> In-Reply-To: <20200207150003.8383-1-shahab.vahedi@gmail.com> References: <20200207150003.8383-1-shahab.vahedi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit |
Commit Message
Shahab Vahedi
Feb. 7, 2020, 2:59 p.m. UTC
From: Anton Kolesov <Anton.Kolesov@synopsys.com> fileio.exp naively assumes that it will be always running on a target where application's output is printed into GDB's stdout. Wrong! If application is run on a gdbserver, then its output is not printed into GDB stdout. gdb/testsuite/ChangeLog: 2016-12-16 Anton Kolesov <Anton.Kolesov@synopsys.com> * gdb.base/fileio.exp: Skip the test if remote. Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com> --- gdb/testsuite/gdb.base/fileio.exp | 3 +++ 1 file changed, 3 insertions(+)
Comments
Hi, On 2/7/20 11:59 AM, Shahab Vahedi wrote: > From: Anton Kolesov <Anton.Kolesov@synopsys.com> > > fileio.exp naively assumes that it will be always running on a target > where application's output is printed into GDB's stdout. Wrong! If > application is run on a gdbserver, then its output is not printed into > GDB stdout. This relies on 01/14. The test does seem to be skipped when exercising the native-gdbserver/native-extended-gdbserver boards. I think we should clarify 01/14 and merge this patch with that, since this is basically just printing some output when the test is skipped. > > gdb/testsuite/ChangeLog: > 2016-12-16 Anton Kolesov <Anton.Kolesov@synopsys.com> > > * gdb.base/fileio.exp: Skip the test if remote. > > Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com> > --- > gdb/testsuite/gdb.base/fileio.exp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp > index 627a685e118d..241552691c38 100644 > --- a/gdb/testsuite/gdb.base/fileio.exp > +++ b/gdb/testsuite/gdb.base/fileio.exp > @@ -25,6 +25,9 @@ standard_testfile > > if {[is_remote target]} { > set outdir . > + verbose "Skipping fileio.exp because it is truly broken for remote " \ > + "hosts with gdbservers." > + continue > } else { > set outdir [standard_output_file {}] > } >
* Shahab Vahedi <shahab.vahedi@gmail.com> [2020-02-07 15:59:51 +0100]: > From: Anton Kolesov <Anton.Kolesov@synopsys.com> > > fileio.exp naively assumes that it will be always running on a target > where application's output is printed into GDB's stdout. Wrong! If > application is run on a gdbserver, then its output is not printed into > GDB stdout. > > gdb/testsuite/ChangeLog: > 2016-12-16 Anton Kolesov <Anton.Kolesov@synopsys.com> > > * gdb.base/fileio.exp: Skip the test if remote. See feedback for patch #1 in this series. I think that explains why you are running into this issue too. Thanks, Andrew > > Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com> > --- > gdb/testsuite/gdb.base/fileio.exp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp > index 627a685e118d..241552691c38 100644 > --- a/gdb/testsuite/gdb.base/fileio.exp > +++ b/gdb/testsuite/gdb.base/fileio.exp > @@ -25,6 +25,9 @@ standard_testfile > > if {[is_remote target]} { > set outdir . > + verbose "Skipping fileio.exp because it is truly broken for remote " \ > + "hosts with gdbservers." > + continue > } else { > set outdir [standard_output_file {}] > } > -- > 2.25.0 >
diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp index 627a685e118d..241552691c38 100644 --- a/gdb/testsuite/gdb.base/fileio.exp +++ b/gdb/testsuite/gdb.base/fileio.exp @@ -25,6 +25,9 @@ standard_testfile if {[is_remote target]} { set outdir . + verbose "Skipping fileio.exp because it is truly broken for remote " \ + "hosts with gdbservers." + continue } else { set outdir [standard_output_file {}] }