[2/7] ldbl-128ibm-compat: enforce correct abi flags on internal file

Message ID 20200214161051.32579-3-murphyp@linux.vnet.ibm.com
State Committed
Headers

Commit Message

Paul E. Murphy Feb. 14, 2020, 4:10 p.m. UTC
  A number of utility files and helper objects should also be
explicitly configured to build with the ibm128 ABI to prevent
gremlins when enabling IEEE long double.
---
 sysdeps/ieee754/ldbl-128ibm-compat/Makefile | 11 +++++++++++
 1 file changed, 11 insertions(+)
  

Comments

Paul E Murphy Feb. 21, 2020, 2:35 p.m. UTC | #1
Pushed.  Again, tested locally as this is not currently use
by any target.  But testd with build-many-glibcs.py with the
other patches committed.

On 2/14/20 10:10 AM, Paul E. Murphy wrote:
> A number of utility files and helper objects should also be
> explicitly configured to build with the ibm128 ABI to prevent
> gremlins when enabling IEEE long double.
> ---
>   sysdeps/ieee754/ldbl-128ibm-compat/Makefile | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> index 7efbd00089..2dceb658e7 100644
> --- a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> +++ b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> @@ -338,6 +338,17 @@ ldbl-ibm128-files := $(objpfx)test-%-ibm128^ \
>   		     $(objpfx)iovswscanf^ \
>   		     $(objpfx)iovfscanf^ \
>   		     $(objpfx)iovfwscanf^ \
> +		     $(objpfx)mpn2ldbl^ \
> +		     $(objpfx)ldbl2mpn^ \
> +		     $(objpfx)strtold_nan^ \
> +		     $(objpfx)strtold_l^ \
> +		     $(objpfx)strtold^ \
> +		     $(objpfx)strfroml^ \
> +		     $(objpfx)wcstold_nan^ \
> +		     $(objpfx)wcstold_l^ \
> +		     $(objpfx)wcstold^ \
> +		     $(objpfx)printf_fphex^ \
> +		     $(objpfx)printf_fp^ \
>   		     $(foreach r,$(ldbl-extra-routines),$(objpfx)$(r)^) \
>   		     $(foreach r,$(ldbl-extra-routines),$(objpfx)$(r)-internal^)
>   obj-suf-foreach = $(foreach suf,$(all-object-suffixes),$(subst ^,$(suf),$(1)))
>
  

Patch

diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
index 7efbd00089..2dceb658e7 100644
--- a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
+++ b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
@@ -338,6 +338,17 @@  ldbl-ibm128-files := $(objpfx)test-%-ibm128^ \
 		     $(objpfx)iovswscanf^ \
 		     $(objpfx)iovfscanf^ \
 		     $(objpfx)iovfwscanf^ \
+		     $(objpfx)mpn2ldbl^ \
+		     $(objpfx)ldbl2mpn^ \
+		     $(objpfx)strtold_nan^ \
+		     $(objpfx)strtold_l^ \
+		     $(objpfx)strtold^ \
+		     $(objpfx)strfroml^ \
+		     $(objpfx)wcstold_nan^ \
+		     $(objpfx)wcstold_l^ \
+		     $(objpfx)wcstold^ \
+		     $(objpfx)printf_fphex^ \
+		     $(objpfx)printf_fp^ \
 		     $(foreach r,$(ldbl-extra-routines),$(objpfx)$(r)^) \
 		     $(foreach r,$(ldbl-extra-routines),$(objpfx)$(r)-internal^)
 obj-suf-foreach = $(foreach suf,$(all-object-suffixes),$(subst ^,$(suf),$(1)))