diff mbox

[1/2] Print more information in arm_dump_tdep

Message ID 20200211170405.149870-1-cbiesinger@google.com
State New, archived
Headers

Commit Message

Terekhov, Mikhail via Gdb-patches Feb. 11, 2020, 5:04 p.m. UTC 
  I am keeping the (int) casts because a future patch will change the type
to bool.

gdb/ChangeLog:

2020-02-11  Christian Biesinger  <cbiesinger@google.com>

	* arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
---
 gdb/arm-tdep.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Tom Tromey Feb. 12, 2020, 10:05 p.m. UTC | #1 
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> I am keeping the (int) casts because a future patch will change the type
Christian> to bool.

Christian> gdb/ChangeLog:

Christian> 2020-02-11  Christian Biesinger  <cbiesinger@google.com>

Christian> 	* arm-tdep.c (arm_dump_tdep): Print more fields of tdep.

Looks reasonable to me.  Thanks.

Tom
Terekhov, Mikhail via Gdb-patches Feb. 12, 2020, 10:29 p.m. UTC | #2 
On Wed, Feb 12, 2020 at 4:05 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> I am keeping the (int) casts because a future patch will change the type
> Christian> to bool.
>
> Christian> gdb/ChangeLog:
>
> Christian> 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
>
> Christian>      * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
>
> Looks reasonable to me.  Thanks.

Thanks, pushed.

Christian
diff mbox

Patch

diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index cfe128bad2..aa26e6a48e 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -9468,6 +9468,20 @@  arm_dump_tdep (struct gdbarch *gdbarch, struct ui_file *file)
   if (tdep == NULL)
     return;
 
+  fprintf_unfiltered (file, _("arm_dump_tdep: fp_model = %i\n"),
+		      (int) tdep->fp_model);
+  fprintf_unfiltered (file, _("arm_dump_tdep: have_fpa_registers = %i\n"),
+		      (int) tdep->have_fpa_registers);
+  fprintf_unfiltered (file, _("arm_dump_tdep: have_wmmx_registers = %i\n"),
+		      (int) tdep->have_wmmx_registers);
+  fprintf_unfiltered (file, _("arm_dump_tdep: vfp_register_count = %i\n"),
+		      (int) tdep->vfp_register_count);
+  fprintf_unfiltered (file, _("arm_dump_tdep: have_vfp_pseudos = %i\n"),
+		      (int) tdep->have_vfp_pseudos);
+  fprintf_unfiltered (file, _("arm_dump_tdep: have_neon_pseudos = %i\n"),
+		      (int) tdep->have_neon_pseudos);
+  fprintf_unfiltered (file, _("arm_dump_tdep: have_neon = %i\n"),
+		      (int) tdep->have_neon);
   fprintf_unfiltered (file, _("arm_dump_tdep: Lowest pc = 0x%lx\n"),
 		      (unsigned long) tdep->lowest_pc);
 }