diff mbox

[1/8] Don't forward-declare struct objfile in frame.h

Message ID 20200208152758.29385-2-tom@tromey.com
State New, archived
Headers

Commit Message

Tom Tromey Feb. 8, 2020, 3:27 p.m. UTC 
  dwarf2/frame.h forward-declares struct objfile, but there's no need
for this.

gdb/ChangeLog
2020-02-08  Tom Tromey  <tom@tromey.com>

	* dwarf2/frame.h (struct objfile): Don't forward declare.

Change-Id: I4d54d46ac9422eeb64dc5f0b934792e77a875aa5
---
 gdb/ChangeLog      | 4 ++++
 gdb/dwarf2/frame.h | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Simon Marchi Feb. 12, 2020, 12:51 a.m. UTC | #1 
On 2020-02-08 10:27 a.m., Tom Tromey wrote:
> dwarf2/frame.h forward-declares struct objfile, but there's no need
> for this.
> 
> gdb/ChangeLog
> 2020-02-08  Tom Tromey  <tom@tromey.com>
> 
> 	* dwarf2/frame.h (struct objfile): Don't forward declare.
> 
> Change-Id: I4d54d46ac9422eeb64dc5f0b934792e77a875aa5
> ---
>  gdb/ChangeLog      | 4 ++++
>  gdb/dwarf2/frame.h | 1 -
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/dwarf2/frame.h b/gdb/dwarf2/frame.h
> index a0ec3615a45..dd7315c8515 100644
> --- a/gdb/dwarf2/frame.h
> +++ b/gdb/dwarf2/frame.h
> @@ -23,7 +23,6 @@
>  #define DWARF2_FRAME_H 1
>  
>  struct gdbarch;
> -struct objfile;
>  struct frame_info;
>  struct dwarf2_per_cu_data;
>  struct agent_expr;
> -- 
> 2.17.2
> 

I'd say "dwarf2/frame.h" in the subject, since there's also a frame.h in
the gdb directory.  But other than that, I think you could push patches like
this one right away.

Simon
Tom Tromey Feb. 12, 2020, 1 a.m. UTC | #2 
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> I'd say "dwarf2/frame.h" in the subject, since there's also a frame.h in
Simon> the gdb directory.

Good idea, I did that.

Simon> But other than that, I think you could push patches like
Simon> this one right away.

Yeah, I will try to do that, since there's little point in anybody
having to review these.

Tom
diff mbox

Patch

diff --git a/gdb/dwarf2/frame.h b/gdb/dwarf2/frame.h
index a0ec3615a45..dd7315c8515 100644
--- a/gdb/dwarf2/frame.h
+++ b/gdb/dwarf2/frame.h
@@ -23,7 +23,6 @@ 
 #define DWARF2_FRAME_H 1
 
 struct gdbarch;
-struct objfile;
 struct frame_info;
 struct dwarf2_per_cu_data;
 struct agent_expr;