Message ID | alpine.DEB.2.21.2001161620520.23348@digraph.polyomino.org.uk |
---|---|
State | Committed |
Headers |
Received: (qmail 56110 invoked by alias); 16 Jan 2020 16:31:23 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 56094 invoked by uid 89); 16 Jan 2020 16:31:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=capable, H*MI:sk:mwk15rn, H*f:sk:mwk15rn, H*i:sk:mwk15rn X-HELO: esa2.mentor.iphmx.com IronPort-SDR: NZU3jxiv3CVM9+QBXgbHCWGDnxEgoaHS1nMQF60BPyh7LscbcMlGpgaMNwjAenUElB3mbC/Z5h UrjcocXIhf4cmEvG+FdTIkwSiICMeLdIizxx6t7I8lNNdAiQn4smZEZTDDvAOzwYAZJh+c6wvQ yuBVrw8F1lziRazFiZyD6RBhV/O4glMe+Xepawk7HX9eHHQsD0lnVGpgs+Uht+tiFywtiwgKsW hVJ2RemLMO/aG2fXCXVJqoSucnF/4DLQrODaqN/x4qd9+qhLCEE8k4f+hIs75uscG4W4cUsIjU jnI= IronPort-SDR: uWJXhm4zgqUpFof5kBsi4gXxYGRq7eiL8MXfs5XK2pReK3EsrXU5pdqklNNqUGNdU2tsgMmEjM RsKmFrP+ubV3RIqniDm0w/+4/1pAUfrpS8powdk8B3GLLAbhJCFKYktq4+PIZ+ROCtV18+5jqK VsjACtp7fZZCyeYbaWFEgVfaAEqADtC/GU9RqZzSh5lO79qczMT8FlmJRoO86ZwJuQBIQFhB2i Mb66CCIPjT9+MWJXKr+Vl7iT5qLp3z+/DDVclx+R+1YuLOh1BeqIxx8DIiucdKIE9kd+asPrzA fMc= Date: Thu, 16 Jan 2020 16:31:05 +0000 From: Joseph Myers <joseph@codesourcery.com> To: paul zimmermann <Paul.Zimmermann@inria.fr> CC: Szabolcs Nagy <Szabolcs.Nagy@arm.com>, <carlos@redhat.com>, <nd@arm.com>, <libc-alpha@sourceware.org> Subject: Re: error when running "make bench" In-Reply-To: <mwk15rn10c.fsf@tomate.loria.fr> Message-ID: <alpine.DEB.2.21.2001161620520.23348@digraph.polyomino.org.uk> References: <mwr200mzh5.fsf@tomate.loria.fr> <CAEMqeSqBv=6Y2Xjz430VM5DcxzbMwzaKRv2=rdumLxNw0TiaQw@mail.gmail.com> <mwzhenkhw4.fsf@tomate.loria.fr> <7929b2d6-5609-f5b4-6ef1-4b10ecd164fb@arm.com> <mwk15rn10c.fsf@tomate.loria.fr> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Return-Path: joseph@codesourcery.com |
Commit Message
Joseph Myers
Jan. 16, 2020, 4:31 p.m. UTC
On Thu, 16 Jan 2020, paul zimmermann wrote: > thank you Szabolcs, this solved the problem. > > However, I believe the issue is on the glibc side. Indeed, the > bench-timing-type is linked with /tmp/lib/ld-linux-x86-64.so.2 > by the glibc Makefile, and that file doesn't exist if "make install" > was not done (I configured with ./configure --prefix=/tmp). The normal configuration people generally test with has --prefix=/usr. However, what this indicates to me is that the call of $(timing-type) needs to use $(test-via-rtld-prefix). Does this (untested) patch help in your configuration using --prefix=/tmp? Run bench-timing-type with newly built libc. benchtests/timing-type is built with the newly built libc, so should be run with it like actual tests and benchmarks.
Comments
Dear Joseph, > Date: Thu, 16 Jan 2020 16:31:05 +0000 > From: Joseph Myers <joseph@codesourcery.com> > > On Thu, 16 Jan 2020, paul zimmermann wrote: > > > thank you Szabolcs, this solved the problem. > > > > However, I believe the issue is on the glibc side. Indeed, the > > bench-timing-type is linked with /tmp/lib/ld-linux-x86-64.so.2 > > by the glibc Makefile, and that file doesn't exist if "make install" > > was not done (I configured with ./configure --prefix=/tmp). > > The normal configuration people generally test with has --prefix=/usr. > > However, what this indicates to me is that the call of $(timing-type) > needs to use $(test-via-rtld-prefix). Does this (untested) patch help in > your configuration using --prefix=/tmp? > > > Run bench-timing-type with newly built libc. > > benchtests/timing-type is built with the newly built libc, so should > be run with it like actual tests and benchmarks. > > diff --git a/benchtests/Makefile b/benchtests/Makefile > index 99c3fae9bf..71b9565fed 100644 > --- a/benchtests/Makefile > +++ b/benchtests/Makefile > @@ -217,7 +217,10 @@ bench-malloc: $(binaries-bench-malloc) > # capable language or tool. > bench-func: $(binaries-bench) > if [ -n '$^' ] ; then \ > - { timing_type=$$($(timing-type)); \ > + { timing_type=$$($(test-wrapper-env) \ > + $(run-program-env) \ > + $(test-via-rtld-prefix) \ > + $(timing-type)); \ > echo "{\"timing_type\": \"$${timing_type}\","; \ > echo " \"functions\": {"; \ > for run in $^; do \ yes this patch solves the issue. Paul
On Sat, 18 Jan 2020, paul zimmermann wrote:
> yes this patch solves the issue.
Siddhesh, is this patch
<https://sourceware.org/ml/libc-alpha/2020-01/msg00346.html> OK for the
current development stage?
On 20/01/20 4:53 pm, Joseph Myers wrote: > On Sat, 18 Jan 2020, paul zimmermann wrote: > >> yes this patch solves the issue. > > Siddhesh, is this patch > <https://sourceware.org/ml/libc-alpha/2020-01/msg00346.html> OK for the > current development stage? > Yes, this patch is OK for master. Thanks, Siddhesh
diff --git a/benchtests/Makefile b/benchtests/Makefile index 99c3fae9bf..71b9565fed 100644 --- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -217,7 +217,10 @@ bench-malloc: $(binaries-bench-malloc) # capable language or tool. bench-func: $(binaries-bench) if [ -n '$^' ] ; then \ - { timing_type=$$($(timing-type)); \ + { timing_type=$$($(test-wrapper-env) \ + $(run-program-env) \ + $(test-via-rtld-prefix) \ + $(timing-type)); \ echo "{\"timing_type\": \"$${timing_type}\","; \ echo " \"functions\": {"; \ for run in $^; do \