Message ID | 20191224122452.1668-2-ssbssa@yahoo.de |
---|---|
State | New, archived |
Headers |
Received: (qmail 131055 invoked by alias); 24 Dec 2019 12:25:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 130964 invoked by uid 89); 24 Dec 2019 12:25:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=2936, HContent-Transfer-Encoding:8bit X-HELO: sonic305-20.consmr.mail.ir2.yahoo.com Received: from sonic305-20.consmr.mail.ir2.yahoo.com (HELO sonic305-20.consmr.mail.ir2.yahoo.com) (77.238.177.82) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Dec 2019 12:25:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1577190312; bh=FYxQJVezzjpvyhxvI1TYT0rEWCo2zDrAOBat7PhUwvA=; h=From:To:Subject:Date:In-Reply-To:References:From:Subject; b=T1TP2vjiupvtt2Zft6RQHa+wL2nn8d/Co3QCxn8n1Ilu79TifhSvM1ws1jTsYhJx1i1iu00j3rba7dw7Js456M7T7V5hRUuf1V3Bp4ipVFiRAVTLCqIUbkfVUMyEq1a4gr1q6Qd0Gdd4fb/LxJN5rj8J282QNCuh9uyv45s08grKZlDpg1EwgSY9roPtuV9ZwVDeosOk9AAxJzghr2e8AlqTarwZWyZKgZDBUZcjh4dYn3dpM0dPuZyheRtGSTX15b2Lfa9VVjgoO754dzANSZhNIent/17eWEoeSwj0HI9Ucd8QFPqbDupnXA7P9QXMCB158sFsGJ1r5BQCyLgNaQ== Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Tue, 24 Dec 2019 12:25:12 +0000 Received: by smtp410.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID ef393b39daf56326d92bc0063080e006; Tue, 24 Dec 2019 12:25:09 +0000 (UTC) From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org> Reply-To: Hannes Domani <ssbssa@yahoo.de> To: gdb-patches@sourceware.org Subject: [PATCH 2/3] solib_target_free_so memory leak Date: Tue, 24 Dec 2019 13:24:51 +0100 Message-Id: <20191224122452.1668-2-ssbssa@yahoo.de> In-Reply-To: <20191224122452.1668-1-ssbssa@yahoo.de> References: <20191224122452.1668-1-ssbssa@yahoo.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 480 X-IsSubscribed: yes |
Commit Message
Terekhov, Mikhail via Gdb-patches
Dec. 24, 2019, 12:24 p.m. UTC
gdb/ChangeLog: 2019-12-24 Hannes Domani <ssbssa@yahoo.de> * solib-target.c (solib_target_free_so): Free li->offsets. --- gdb/solib-target.c | 1 + 1 file changed, 1 insertion(+)
Comments
On Tue, Dec 24, 2019 at 1:25 PM Hannes Domani via gdb-patches <gdb-patches@sourceware.org> wrote: > > gdb/ChangeLog: > > 2019-12-24 Hannes Domani <ssbssa@yahoo.de> > > * solib-target.c (solib_target_free_so): Free li->offsets. > --- > gdb/solib-target.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gdb/solib-target.c b/gdb/solib-target.c > index 2b473d6066..52e2a6068b 100644 > --- a/gdb/solib-target.c > +++ b/gdb/solib-target.c > @@ -293,6 +293,7 @@ solib_target_free_so (struct so_list *so) > > gdb_assert (li->name.empty ()); > > + xfree (li->offsets); > delete li; Maybe a better fix would be to change offsets to be a unique_xmalloc_ptr? Christian
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes: >> + xfree (li->offsets); >> delete li; Christian> Maybe a better fix would be to change offsets to be a Christian> unique_xmalloc_ptr? Makes sense to me. thanks, Tom
Am Freitag, 3. Januar 2020, 17:41:21 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben: > >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes: > > > >> + xfree (li->offsets); > >> delete li; > > > Christian> Maybe a better fix would be to change offsets to be a > Christian> unique_xmalloc_ptr? > > Makes sense to me. I've sent a v2 for this here: https://sourceware.org/ml/gdb-patches/2019-12/msg01034.html Regards Hannes Domani
diff --git a/gdb/solib-target.c b/gdb/solib-target.c index 2b473d6066..52e2a6068b 100644 --- a/gdb/solib-target.c +++ b/gdb/solib-target.c @@ -293,6 +293,7 @@ solib_target_free_so (struct so_list *so) gdb_assert (li->name.empty ()); + xfree (li->offsets); delete li; }