build-many-glibcs.py: Do not build C++ PCHs by default

Message ID 87d0cn7ymd.fsf@oldenburg2.str.redhat.com
State Committed
Headers

Commit Message

Florian Weimer Dec. 17, 2019, 3:36 p.m. UTC
  They are not used during the subsequent glibc build, so creating them
merely wastes time.

-----
 scripts/build-many-glibcs.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
  

Comments

Joseph Myers Dec. 17, 2019, 10:03 p.m. UTC | #1
On Tue, 17 Dec 2019, Florian Weimer wrote:

> They are not used during the subsequent glibc build, so creating them
> merely wastes time.
> 
> -----
>  scripts/build-many-glibcs.py | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

OK.
  

Patch

diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index 193d49727b..92cc613c5d 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -1382,9 +1382,12 @@  class Config(object):
         else:
             tool_build = 'gcc'
             # libsanitizer commonly breaks because of glibc header
-            # changes, or on unusual targets.
+            # changes, or on unusual targets.  C++ pre-compiled
+            # headers are not used during the glibc build and are
+            # expensive to create.
             if not self.ctx.full_gcc:
-                cfg_opts += ['--disable-libsanitizer']
+                cfg_opts += ['--disable-libsanitizer',
+                             '--disable-libstdcxx-pch']
             langs = 'all' if self.ctx.full_gcc else 'c,c++'
             cfg_opts += ['--enable-languages=%s' % langs,
                          '--enable-shared', '--enable-threads']