[review] Remove "fix" call for "long long" from ARI
Commit Message
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/755
......................................................................
Remove "fix" call for "long long" from ARI
ARI has a "fix" call for "long long", but this call is incorrect.
This patch removes it.
gdb/ChangeLog
2019-12-12 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 4 insertions(+), 2 deletions(-)
Comments
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/755
......................................................................
Patch Set 1:
(1 comment)
| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,17 @@
| +Parent: 13e991b1 (Accept -Wno- prefix in ARI)
| +Author: Tom Tromey <tromey@adacore.com>
| +AuthorDate: 2019-12-12 09:10:49 -0700
| +Commit: Tom Tromey <tromey@adacore.com>
| +CommitDate: 2019-12-12 10:31:38 -0700
| +
| +Remove "fix" call for "long long" from ARI
| +
| +ARI has a "fix" call for "long long", but this call is incorrect.
| +This patch removes it.
PS1, Line 10:
More like the definitions of ULONGEST/LONGEST moved from defs.h to
gdbsupport/common-types.h. I don't see markers there, don't we need
them?
| +
| +gdb/ChangeLog
| +2019-12-12 Tom Tromey <tromey@adacore.com>
| +
| + * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
| +
| +Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/755
......................................................................
Patch Set 1:
(1 comment)
| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,17 @@
| +Parent: 13e991b1 (Accept -Wno- prefix in ARI)
| +Author: Tom Tromey <tromey@adacore.com>
| +AuthorDate: 2019-12-12 09:10:49 -0700
| +Commit: Tom Tromey <tromey@adacore.com>
| +CommitDate: 2019-12-12 10:31:38 -0700
| +
| +Remove "fix" call for "long long" from ARI
| +
| +ARI has a "fix" call for "long long", but this call is incorrect.
| +This patch removes it.
PS1, Line 10:
> More like the definitions of ULONGEST/LONGEST moved from defs.h to gdbsupport/common-types.h. I don't see markers there, don't we need them?
Yeah, probably so. There are a few ways of running ARI, and
the one I'm mostly using doesn't note these. If you do enable
more warnings, you'll see a lot -- my "-Wari" run shows 637
(but some of these are warnings about deprecated or legacy
things, which I think aren't very interesting).
| +
| +gdb/ChangeLog
| +2019-12-12 Tom Tromey <tromey@adacore.com>
| +
| + * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
| +
| +Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
@@ -1,3 +1,7 @@
+2019-12-12 Tom Tromey <tromey@adacore.com>
+
+ * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
+
2019-12-05 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
@@ -587,8 +587,6 @@
BEGIN { doc["long long"] = "\
Do not use `long long'\'', instead use LONGEST"
category["long long"] = ari_code
- # defs.h needs two such patterns for LONGEST and ULONGEST definitions
- fix("long long", "gdb/defs.h", 2)
}
/(^|[^_[:alnum:]])long[[:space:]]+long([^_[:alnum:]]|$)/ {
fail("long long")