[FYI] Fix the build after bfd_get_signed_8 change
Commit Message
A recent commit changed bfd_get_signed_8 to extend the result to a
bfd_signed_vma. This caused a compiler error in one spot in my
--enable-targets=all gdb build, where the result of bfd_get_signed_8
was passed to printf.
This patch fixes the build. Tested by rebuilding.
gdb/ChangeLog
2019-12-11 Tom Tromey <tromey@adacore.com>
* fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
bfd_get_signed_8.
Change-Id: Ic015f5fd3d88da6b5da8f7b4e1d11d5c981333db
---
gdb/ChangeLog | 5 +++++
gdb/fbsd-tdep.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
Comments
On Wed, Dec 11, 2019 at 08:00:15AM -0700, Tom Tromey wrote:
> A recent commit changed bfd_get_signed_8 to extend the result to a
> bfd_signed_vma. This caused a compiler error in one spot in my
> --enable-targets=all gdb build, where the result of bfd_get_signed_8
> was passed to printf.
Sorry, and thanks for cleaning up after me. I saw the buildbot
message this morning and made the same fix, only to see it disappear
with git rebase. :-)
@@ -1433,7 +1433,7 @@ fbsd_core_info_proc_status (struct gdbarch *gdbarch)
sec, value);
printf_filtered ("stime, children: %s.%06d\n", plongest (sec), (int) value);
printf_filtered ("'nice' value: %d\n",
- bfd_get_signed_8 (core_bfd, descdata + kp->ki_nice));
+ (int) bfd_get_signed_8 (core_bfd, descdata + kp->ki_nice));
fbsd_core_fetch_timeval (gdbarch, descdata + kp->ki_start, sec, value);
printf_filtered ("Start time: %s.%06d\n", plongest (sec), (int) value);
printf_filtered ("Virtual memory size: %s kB\n",