[review] gdb/testsuite: Use -J option when compiling Fortran tests
Commit Message
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/733
......................................................................
gdb/testsuite: Use -J option when compiling Fortran tests
When compiling Fortran tests (e.g. gdb.fortran/info-modules.exp), the
Fotran compile produces .mod files. These files contain details of
compiled modules that are then consumed by the compiler when compiling
other files that USE a module.
Currently the compiler writes the .mod files into its current
directory, so for us this turns out to be 'build/gdb/testsuite/'.
This means that .mod files can be shared between tests, which seems
against the spirit of the GDB testsuite; source files should be
compiled fresh for each test.
This commit adds the -J option to the compiler flags whenever we
compile a Fortran file, this option tells the compiler where to write,
and look for, .mod files.
After this commit there was one Fortran test that needed fixing, with
that fix in place all of the Fortran tests pass again, but now the
.mod files are now produced in the per-test output directories.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (gdb_compile): Add -J compiler option when building
Fortran tests.
* gdb.mi/mi-fortran-modules.exp: Compile source files in correct
order.
Change-Id: I99444cf22d80e320093d3f3ed9abb8825f378e0b
---
M gdb/testsuite/ChangeLog
M gdb/testsuite/gdb.mi/mi-fortran-modules.exp
M gdb/testsuite/lib/gdb.exp
3 files changed, 18 insertions(+), 1 deletion(-)
Comments
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/733
......................................................................
Patch Set 1: Code-Review+2
Thank you very much for doing this. I vaguely recall wanting to do this
when I changed the test suite to use the "output/" directory, but I couldn't
figure out how.
@@ -1,3 +1,10 @@
+2019-11-28 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * lib/gdb.exp (gdb_compile): Add -J compiler option when building
+ Fortran tests.
+ * gdb.mi/mi-fortran-modules.exp: Compile source files in correct
+ order.
+
2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.fortran/info-modules.exp: Compile source files in correct
@@ -22,7 +22,7 @@
standard_testfile "mi-fortran-modules.f90" "mi-fortran-modules-2.f90"
if {[prepare_for_testing "failed to prepare" ${testfile} \
- [list $srcfile $srcfile2] {debug f90}]} {
+ [list $srcfile2 $srcfile] {debug f90}]} {
return -1
}
@@ -3719,6 +3719,16 @@
} else {
set new_options [universal_compile_options]
}
+
+ # Place (and look for) Fortran `.mod` files in the output
+ # directory for this specific test.
+ if {[lsearch -exact $options f77] != -1 \
+ || [lsearch -exact $options f90] != -1 } {
+ # Fortran compile.
+ set mod_path [standard_output_file ""]
+ lappend new_options "additional_flags=-J${mod_path}"
+ }
+
set shlib_found 0
set shlib_load 0
set getting_compiler_info 0