[review] login: Remove double-assignment of fl.l_whence in try_file_lock
Commit Message
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/515
......................................................................
login: Remove double-assignment of fl.l_whence in try_file_lock
Since l_whence is the second member of struct flock, it is written
twice. The double-assignment is technically undefined behavior due to
the lack of a sequence point.
Change-Id: I2baf9e70690e723c61051b25ccbd510aec15976c
---
M login/utmp_file.c
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Carlos O'Donell has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/515
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/515/1/login/utmp_file.c
File login/utmp_file.c:
https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/515/1/login/utmp_file.c@82
PS1, Line 82:
63 | try_file_lock (int fd, int type)
| ...
77 |
78 | /* Try to get the lock. */
79 | struct flock64 fl =
80 | {
81 | .l_type = type,
82 > .l_whence = SEEK_SET,
83 | };
84 |
85 | bool status = __fcntl64_nocancel (fd, F_SETLKW, &fl) < 0;
86 | int saved_errno = errno;
87 |
OK. The double assignment is that we used 'fl' in the orignal code. This fix is correct.
Carlos O'Donell has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/515
......................................................................
Patch Set 1:
OK for master. Totally a typo. I'd say this is almost a trivial bug fix not requiring a review, but I'm happy to review it.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
@@ -79,7 +79,7 @@
struct flock64 fl =
{
.l_type = type,
- fl.l_whence = SEEK_SET,
+ .l_whence = SEEK_SET,
};
bool status = __fcntl64_nocancel (fd, F_SETLKW, &fl) < 0;