[review] Introduce program_space::add_objfile
Commit Message
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/495
......................................................................
Introduce program_space::add_objfile
This introduces a new method, program_space::add_objfile, that adds an
objfile to the program space's list of objfiles. It also changes the
obfile's constructor so that linking an objfile into this list is not
done here.
The former is an improvement because it makes more sense to treat the
program space as a container holding objfiles -- so manipulation of
the list belongs there.
The latter is not strictly needed, but seemed better both because it
is removing a global side effect from a constructor, and for symmetry
reasons, as a subsequent patch will remove unlinking from the
destructor.
gdb/ChangeLog
2019-11-03 Tom Tromey <tom@tromey.com>
* progspace.h (struct program_space) <add_objfile>: Declare
method.
* progspace.c (program_space::add_objfile): New method.
* objfiles.c (~objfile): Don't unlink objfile.
(put_objfile_before): Remove.
(add_separate_debug_objfile): Don't call put_objfile_before.
(objfile::make): Call add_objfile. Set new_objfiles_available on
the per-program-space data.
Change-Id: I93e8525dda631cb89dcc2046a5c51c7c9f34ccfd
---
M gdb/ChangeLog
M gdb/objfiles.c
M gdb/progspace.c
M gdb/progspace.h
4 files changed, 45 insertions(+), 45 deletions(-)
Comments
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/495
......................................................................
Patch Set 1:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/495/1/gdb/objfiles.c
File gdb/objfiles.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/495/1/gdb/objfiles.c@512
PS1, Line 512:
502 | objfile::make (bfd *bfd_, const char *name_, objfile_flags flags_,
| ...
507 | add_separate_debug_objfile (result, parent);
508 |
509 | current_program_space->add_objfile (result, parent);
510 |
511 | /* Rebuild section map next time we need it. */
512 > get_objfile_pspace_data (current_program_space)->new_objfiles_available = 1;
513 |
514 | return result;
515 | }
516 |
517 | /* See objfiles.h. */
Maybe this should be done by add_objfile instead?
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/495
......................................................................
Patch Set 1:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/495/1/gdb/objfiles.c
File gdb/objfiles.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/495/1/gdb/objfiles.c@512
PS1, Line 512:
502 | objfile::make (bfd *bfd_, const char *name_, objfile_flags flags_,
| ...
507 | add_separate_debug_objfile (result, parent);
508 |
509 | current_program_space->add_objfile (result, parent);
510 |
511 | /* Rebuild section map next time we need it. */
512 > get_objfile_pspace_data (current_program_space)->new_objfiles_available = 1;
513 |
514 | return result;
515 | }
516 |
517 | /* See objfiles.h. */
> Maybe this should be done by add_objfile instead?
The objfile module stores some state on the program space, so
I think it's probably something that should be kept here.
At least, for the time being; maybe this should just be a field
on the program space instead of a side object; I am not sure.
@@ -1,5 +1,16 @@
2019-11-03 Tom Tromey <tom@tromey.com>
+ * progspace.h (struct program_space) <add_objfile>: Declare
+ method.
+ * progspace.c (program_space::add_objfile): New method.
+ * objfiles.c (~objfile): Don't unlink objfile.
+ (put_objfile_before): Remove.
+ (add_separate_debug_objfile): Don't call put_objfile_before.
+ (objfile::make): Call add_objfile. Set new_objfiles_available on
+ the per-program-space data.
+
+2019-11-03 Tom Tromey <tom@tromey.com>
+
* symfile.c (syms_from_objfile_1): Use objfile_up.
(syms_from_objfile_1, remove_symbol_file_command): Call unlink
method.
@@ -371,23 +371,6 @@
}
per_bfd = get_objfile_bfd_data (this, abfd);
-
- /* Add this file onto the tail of the linked list of other such files. */
-
- if (object_files == NULL)
- object_files = this;
- else
- {
- struct objfile *last_one;
-
- for (last_one = object_files;
- last_one->next;
- last_one = last_one->next);
- last_one->next = this;
- }
-
- /* Rebuild section map next time we need it. */
- get_objfile_pspace_data (pspace)->new_objfiles_available = 1;
}
/* Retrieve the gdbarch associated with OBJFILE. */
@@ -494,30 +477,6 @@
_("unlink_objfile: objfile already unlinked"));
}
-/* Put one object file before a specified on in the global list.
- This can be used to make sure an object file is destroyed before
- another when using objfiles_safe to free all objfiles. */
-static void
-put_objfile_before (struct objfile *objfile, struct objfile *before_this)
-{
- struct objfile **objp;
-
- unlink_objfile (objfile);
-
- for (objp = &object_files; *objp != NULL; objp = &((*objp)->next))
- {
- if (*objp == before_this)
- {
- objfile->next = *objp;
- *objp = objfile;
- return;
- }
- }
-
- internal_error (__FILE__, __LINE__,
- _("put_objfile_before: before objfile not in list"));
-}
-
/* Add OBJFILE as a separate debug objfile of PARENT. */
static void
@@ -535,10 +494,6 @@
objfile->separate_debug_objfile_backlink = parent;
objfile->separate_debug_objfile_link = parent->separate_debug_objfile;
parent->separate_debug_objfile = objfile;
-
- /* Put the separate debug object before the normal one, this is so that
- usage of objfiles_safe will stay safe. */
- put_objfile_before (objfile, parent);
}
/* See objfiles.h. */
@@ -550,6 +505,12 @@
objfile *result = new objfile (bfd_, name_, flags_);
if (parent != nullptr)
add_separate_debug_objfile (result, parent);
+
+ current_program_space->add_objfile (result, parent);
+
+ /* Rebuild section map next time we need it. */
+ get_objfile_pspace_data (current_program_space)->new_objfiles_available = 1;
+
return result;
}
@@ -153,6 +153,28 @@
program_space_free_data (this);
}
+/* See progspace.h. */
+
+void
+program_space::add_objfile (struct objfile *objfile, struct objfile *before)
+{
+ for (struct objfile **objp = &objfiles_head;
+ *objp != NULL;
+ objp = &((*objp)->next))
+ {
+ if (*objp == before)
+ {
+ objfile->next = *objp;
+ *objp = objfile;
+ return;
+ }
+ }
+
+ internal_error (__FILE__, __LINE__,
+ _("put_objfile_before: before objfile not in list"));
+
+}
+
/* Copies program space SRC to DEST. Copies the main executable file,
and the main symbol file. Returns DEST. */
@@ -165,6 +165,12 @@
return objfiles_safe_range (objfiles_head);
}
+ /* Add OBJFILE to the list of objfiles, putting it just before
+ BEFORE. If BEFORE is nullptr, it will go at the end of the
+ list. */
+ void add_objfile (struct objfile *objfile, struct objfile *before);
+
+
/* Pointer to next in linked list. */
struct program_space *next = NULL;