[review] Also check for strerror_r in gdbserver
Commit Message
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476
......................................................................
Also check for strerror_r in gdbserver
I forgot to do this in b231e86ac9608056ea837e24d42a878927f5787a
Since safe_strerror is in gdbsupport, gdbserver also needs to
check for strerror_r, although it's less critical since gdbserver
does not use threads as much.
gdb/gdbserver/ChangeLog:
2019-10-31 Christian Biesinger <cbiesinger@google.com>
* config.in: Regenerate.
* configure: Regenerate.
* configure.ac: Also check for strerror_r.
Change-Id: I6a67c8543cd7a28d6dc94f5986f56abcb55727fe
---
M gdb/gdbserver/config.in
M gdb/gdbserver/configure
M gdb/gdbserver/configure.ac
3 files changed, 5 insertions(+), 2 deletions(-)
Comments
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476
......................................................................
Patch Set 1: Code-Review+2
Yeah, I suppose it can't hurt to use the thread-safe version even if not needed.
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476
......................................................................
Patch Set 2:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476/2//COMMIT_MSG
Commit Message:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476/2//COMMIT_MSG@11
PS2, Line 11:
6 |
7 | Also check for strerror_r in gdbserver
8 |
9 | I forgot to do this in b231e86ac9608056ea837e24d42a878927f5787a
10 |
11 > Since safe_strerror is in gdbsupport, gdbserver also needs to
12 > check for strerror_r, although it's less critical since gdbserver
13 > does not use threads as much.
14 |
15 | gdb/gdbserver/ChangeLog:
16 |
17 | 2019-10-31 Christian Biesinger <cbiesinger@google.com>
18 |
Normally this means the check should be put into common.m4.
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476
......................................................................
Patch Set 2:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476/2//COMMIT_MSG
Commit Message:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476/2//COMMIT_MSG@11
PS2, Line 11:
6 |
7 | Also check for strerror_r in gdbserver
8 |
9 | I forgot to do this in b231e86ac9608056ea837e24d42a878927f5787a
10 |
11 > Since safe_strerror is in gdbsupport, gdbserver also needs to
12 > check for strerror_r, although it's less critical since gdbserver
13 > does not use threads as much.
14 |
15 | gdb/gdbserver/ChangeLog:
16 |
17 | 2019-10-31 Christian Biesinger <cbiesinger@google.com>
18 |
> Normally this means the check should be put into common.m4.
Oh, thanks, let me make a new patch to move it.
@@ -229,6 +229,9 @@
/* Define to 1 if you have the <stdlib.h> header file. */
#undef HAVE_STDLIB_H
+/* Define to 1 if you have the `strerror_r' function. */
+#undef HAVE_STRERROR_R
+
/* Define to 1 if you have the <strings.h> header file. */
#undef HAVE_STRINGS_H
@@ -6448,7 +6448,7 @@
fi
-for ac_func in getauxval pread pwrite pread64 setns
+for ac_func in getauxval pread pwrite pread64 setns strerror_r
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
@@ -90,7 +90,7 @@
sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl
netinet/tcp.h arpa/inet.h)
AC_FUNC_FORK
-AC_CHECK_FUNCS(getauxval pread pwrite pread64 setns)
+AC_CHECK_FUNCS(getauxval pread pwrite pread64 setns strerror_r)
GDB_AC_COMMON