diff mbox

Added International_Standard_Book_Number (ISBN) for various Locales

Message ID 1563532775-4696-1-git-send-email-s.charan@samsung.com
State Rejected
Headers

Commit Message

Sai Charan Sane July 19, 2019, 10:39 a.m. UTC 
  From: Akhilesh Kumar <akhilesh.k@samsung.com>

[BZ #24817]
* locales/om_KE (LC_TIME): copy "om_ET".
* locales/aa_ER  (LC_ADDRESS): Added country_isbn.
* locales/aa_ET  (LC_ADDRESS): Added country_isbn.
* locales/am_ET  (LC_ADDRESS): Added country_isbn.
* locales/byn_ER  (LC_ADDRESS): Added country_isbn.
* locales/gez_ER  (LC_ADDRESS): Added country_isbn.
* locales/gez_ET  (LC_ADDRESS): Added country_isbn.
* locales/om_ET  (LC_ADDRESS): Added country_isbn.
* locales/sid_ET  (LC_ADDRESS): Added country_isbn.
* locales/so_ET  (LC_ADDRESS): Added country_isbn.
* locales/ti_ER  (LC_ADDRESS): Added country_isbn.
* locales/ti_ET  (LC_ADDRESS): Added country_isbn.
* locales/tig_ER  (LC_ADDRESS): Added country_isbn.
* locales/wal_ET  (LC_ADDRESS): Added country_isbn.
---
 localedata/locales/aa_ER  | 2 +-
 localedata/locales/aa_ET  | 2 +-
 localedata/locales/am_ET  | 2 +-
 localedata/locales/byn_ER | 2 +-
 localedata/locales/gez_ER | 2 +-
 localedata/locales/gez_ET | 2 +-
 localedata/locales/om_ET  | 2 +-
 localedata/locales/sid_ET | 2 +-
 localedata/locales/so_ET  | 2 +-
 localedata/locales/ti_ER  | 2 +-
 localedata/locales/ti_ET  | 2 +-
 localedata/locales/tig_ER | 2 +-
 localedata/locales/wal_ET | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)

Comments

Rafal Luzynski July 19, 2019, 2:26 p.m. UTC | #1 
Hello,

Thank you for your contribution, and thank you for posting it here
at libc-alpha.  Please see below:

19.07.2019 12:39 Sai Charan Sane <s.charan@samsung.com> wrote:
> 
> 
> From: Akhilesh Kumar <akhilesh.k@samsung.com>
> 
> [BZ #24817]
> * locales/om_KE (LC_TIME): copy "om_ET".

This does not seem to be part of this patch (which is OK but
this line should be deleted).

> * locales/aa_ER  (LC_ADDRESS): Added country_isbn.

Alternatively I think it is OK if you mention (country_isbn) as
a new entry instead of (LC_ADDRESS).  But this is correct as well.

> * locales/aa_ET  (LC_ADDRESS): Added country_isbn.
> * locales/am_ET  (LC_ADDRESS): Added country_isbn.
> * locales/byn_ER  (LC_ADDRESS): Added country_isbn.
> * locales/gez_ER  (LC_ADDRESS): Added country_isbn.
> * locales/gez_ET  (LC_ADDRESS): Added country_isbn.
> * locales/om_ET  (LC_ADDRESS): Added country_isbn.
> * locales/sid_ET  (LC_ADDRESS): Added country_isbn.
> * locales/so_ET  (LC_ADDRESS): Added country_isbn.
> * locales/ti_ER  (LC_ADDRESS): Added country_isbn.
> * locales/ti_ET  (LC_ADDRESS): Added country_isbn.
> * locales/tig_ER  (LC_ADDRESS): Added country_isbn.
> * locales/wal_ET  (LC_ADDRESS): Added country_isbn.

Please use "Likewise." instead of the actual comment if it
is the same for all entries unless the comment is shorter than
"Likewise."

> [...]
> diff --git a/localedata/locales/aa_ER b/localedata/locales/aa_ER
> index 6d20ae9..ca49c22 100644
> --- a/localedata/locales/aa_ER
> +++ b/localedata/locales/aa_ER
> @@ -112,7 +112,7 @@ country_ab2   "ER"
>  country_ab3   "ERI"
>  country_num   232
>  country_car   "ER"
> -% country_isbn  unknown, Need ISO 2108
> +country_isbn  99948 

Please provide the source of this information.

>  lang_name     "Qafar"
>  lang_ab       "aa"
>  lang_term     "aar"
> diff --git a/localedata/locales/aa_ET b/localedata/locales/aa_ET
> index 93fcdb7..31bcf49 100644
> --- a/localedata/locales/aa_ET
> +++ b/localedata/locales/aa_ET
> @@ -112,7 +112,7 @@ country_ab2   "ET"
>  country_ab3   "ETH"
>  country_num   231   % 210 found in at least one ISO 3166 doc
>  country_car   "ETH"
> -% country_isbn  unknown, Need ISO 2108
> +country_isbn  99944  
> [...]

Likewise.

I have cut off the rest of the patch because the further parts provide
the same changes as mentioned above.

I don't see any missing locale in this patch.

Regards,

Rafal
diff mbox

Patch

diff --git a/localedata/locales/aa_ER b/localedata/locales/aa_ER
index 6d20ae9..ca49c22 100644
--- a/localedata/locales/aa_ER
+++ b/localedata/locales/aa_ER
@@ -112,7 +112,7 @@  country_ab2   "ER"
 country_ab3   "ERI"
 country_num   232
 country_car   "ER"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99948 
 lang_name     "Qafar"
 lang_ab       "aa"
 lang_term     "aar"
diff --git a/localedata/locales/aa_ET b/localedata/locales/aa_ET
index 93fcdb7..31bcf49 100644
--- a/localedata/locales/aa_ET
+++ b/localedata/locales/aa_ET
@@ -112,7 +112,7 @@  country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car   "ETH"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99944  
 lang_name     "Qafar"
 lang_ab       "aa"
 lang_term     "aar"
diff --git a/localedata/locales/am_ET b/localedata/locales/am_ET
index 7846d62..bf81c22 100644
--- a/localedata/locales/am_ET
+++ b/localedata/locales/am_ET
@@ -947,7 +947,7 @@  country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 % ETH
 country_car   "ETH"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99944 
 lang_name     "<U12A0><U121B><U122D><U129B>"
 lang_ab      "am"
 lang_term    "amh"
diff --git a/localedata/locales/byn_ER b/localedata/locales/byn_ER
index 608378d..0db4310 100644
--- a/localedata/locales/byn_ER
+++ b/localedata/locales/byn_ER
@@ -123,7 +123,7 @@  country_ab2   "ER"
 country_ab3   "ERI"
 country_num   232
 country_car  "ER"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99948  
 lang_name     "<U1265><U120A><U1295>"
 lang_ab       ""
 lang_term     "byn"
diff --git a/localedata/locales/gez_ER b/localedata/locales/gez_ER
index 261f9da..ff5eee5 100644
--- a/localedata/locales/gez_ER
+++ b/localedata/locales/gez_ER
@@ -110,7 +110,7 @@  country_ab2   "ER"
 country_ab3   "ERI"
 country_num   232
 country_car   "ER"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99948 
 lang_name     "<U130D><U12D5><U12DD>"
 lang_term     "gez"
 %
diff --git a/localedata/locales/gez_ET b/localedata/locales/gez_ET
index bc8e0d3..4aecae7 100644
--- a/localedata/locales/gez_ET
+++ b/localedata/locales/gez_ET
@@ -110,7 +110,7 @@  country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car    "ETH"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99944 
 lang_name     "<U130D><U12D5><U12DD>"
 lang_term     "gez"
 %
diff --git a/localedata/locales/om_ET b/localedata/locales/om_ET
index 881b43f..3d949fe 100644
--- a/localedata/locales/om_ET
+++ b/localedata/locales/om_ET
@@ -145,7 +145,7 @@  country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car    "ETH"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99944 
 lang_name     "Oromoo"
 lang_ab       "om"
 lang_term     "orm"
diff --git a/localedata/locales/sid_ET b/localedata/locales/sid_ET
index fd56445..ffc223f 100644
--- a/localedata/locales/sid_ET
+++ b/localedata/locales/sid_ET
@@ -113,7 +113,7 @@  country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car   "ETH"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99944 
 lang_name     "Sidaamu Afo"
 lang_term     "sid"
 lang_lib      "sid"
diff --git a/localedata/locales/so_ET b/localedata/locales/so_ET
index 2f8fe42..5eecbb0 100644
--- a/localedata/locales/so_ET
+++ b/localedata/locales/so_ET
@@ -123,7 +123,7 @@  country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car    "ETH"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99944 
 lang_name     "Soomaali"
 lang_ab       "so"
 lang_term     "som"
diff --git a/localedata/locales/ti_ER b/localedata/locales/ti_ER
index 890bbb6..15b57d8 100644
--- a/localedata/locales/ti_ER
+++ b/localedata/locales/ti_ER
@@ -143,7 +143,7 @@  country_ab2   "ER"
 country_ab3   "ERI"
 country_num   232
 country_car  "ER"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99948 
 lang_name     "<U1275><U130D><U122D><U129B>"
 lang_ab       "ti"
 lang_term     "tir"
diff --git a/localedata/locales/ti_ET b/localedata/locales/ti_ET
index e7c8ec3..551f580 100644
--- a/localedata/locales/ti_ET
+++ b/localedata/locales/ti_ET
@@ -946,7 +946,7 @@  country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car    "ETH"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99944 
 lang_name     "<U1275><U130D><U122D><U129B>"
 lang_ab       "ti"
 lang_term     "tir"
diff --git a/localedata/locales/tig_ER b/localedata/locales/tig_ER
index 403a919..8142dc6 100644
--- a/localedata/locales/tig_ER
+++ b/localedata/locales/tig_ER
@@ -123,7 +123,7 @@  country_ab2   "ER"
 country_ab3   "ERI"
 country_num   232
 country_car  "ER"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99948 
 lang_name     "<U1275><U130D><U1228>"
 lang_ab       ""
 lang_term     "tig"
diff --git a/localedata/locales/wal_ET b/localedata/locales/wal_ET
index 65b8e5f..05b329e 100644
--- a/localedata/locales/wal_ET
+++ b/localedata/locales/wal_ET
@@ -110,7 +110,7 @@  country_ab2   "ET"
 country_ab3   "ETH"
 country_num   231   % 210 found in at least one ISO 3166 doc
 country_car    "ETH"
-% country_isbn  unknown, Need ISO 2108
+country_isbn  99944
 lang_name     "<U12C8><U120B><U12ED><U1273><U1271>"
 lang_term     "wal"
 lang_lib      "wal"