Don't check noargs in remotetimeout.exp
Commit Message
The condition [target_info exists noargs] is checked when
remotetimeout.exp was added
https://sourceware.org/ml/gdb-patches/2005-02/msg00052.html
noargs means GDB does not support argument passing for inferior,
rather than doesn't support argument passing to GDB (remotetimeout.exp
passes -l to GDB).
This patch is to remove such unnecessary checking, and
remotetimeout.exp then can be run with native-gdbserver board file.
gdb/testsuite:
2014-10-13 Yao Qi <yao@codesourcery.com>
* gdb.base/remotetimeout.exp: Remove noargs checking.
---
gdb/testsuite/gdb.base/remotetimeout.exp | 5 -----
1 file changed, 5 deletions(-)
Comments
On 10/13/2014 03:24 AM, Yao Qi wrote:
> The condition [target_info exists noargs] is checked when
> remotetimeout.exp was added
> https://sourceware.org/ml/gdb-patches/2005-02/msg00052.html
>
> noargs means GDB does not support argument passing for inferior,
> rather than doesn't support argument passing to GDB (remotetimeout.exp
> passes -l to GDB).
Yeah, makes sense.
>
> This patch is to remove such unnecessary checking, and
> remotetimeout.exp then can be run with native-gdbserver board file.
>
> gdb/testsuite:
>
> 2014-10-13 Yao Qi <yao@codesourcery.com>
>
> * gdb.base/remotetimeout.exp: Remove noargs checking.
LGTM.
Thanks,
Pedro Alves
Pedro Alves <palves@redhat.com> writes:
>> This patch is to remove such unnecessary checking, and
>> remotetimeout.exp then can be run with native-gdbserver board file.
>>
>> gdb/testsuite:
>>
>> 2014-10-13 Yao Qi <yao@codesourcery.com>
>>
>> * gdb.base/remotetimeout.exp: Remove noargs checking.
>
> LGTM.
Thanks, patch is pushed in.
@@ -21,11 +21,6 @@
global GDBFLAGS
-# Skip test if target does not support argument passing.
-if [target_info exists noargs] {
- return
-}
-
#
# Test that -l is processed correctly.
#