diff mbox

[17/25] gdb/sh: Use default gdbarch methods where possible

Message ID aca9c5ca500e3f8149e541ebcc6a64eb70f28488.1553721877.git.andrew.burgess@embecosm.com
State New, archived
Headers

Commit Message

Andrew Burgess March 27, 2019, 9:34 p.m. UTC 
  Make use of the default gdbarch methods for gdbarch_dummy_id,
gdbarch_unwind_pc, and gdbarch_unwind_sp where possible.

I have not tested this change but, by inspecting the code, I believe
the default methods are equivalent to the code being deleted.

gdb/ChangeLog:

	* sh-tdep.c (sh_unwind_sp): Delete.
	(sh_unwind_pc): Delete.
	(sh_dummy_id): Delete.
	(sh_gdbarch_init): Don't register deleted functions with
	gdbarch.
---
 gdb/ChangeLog |  8 ++++++++
 gdb/sh-tdep.c | 25 -------------------------
 2 files changed, 8 insertions(+), 25 deletions(-)

Comments

Kevin Buettner March 27, 2019, 10:06 p.m. UTC | #1 
On Wed, 27 Mar 2019 21:34:13 +0000
Andrew Burgess <andrew.burgess@embecosm.com> wrote:

> gdb/ChangeLog:
> 
> 	* sh-tdep.c (sh_unwind_sp): Delete.
> 	(sh_unwind_pc): Delete.
> 	(sh_dummy_id): Delete.
> 	(sh_gdbarch_init): Don't register deleted functions with
> 	gdbarch.

Okay.

Kevin
diff mbox

Patch

diff --git a/gdb/sh-tdep.c b/gdb/sh-tdep.c
index de53dcd8285..8337a07501e 100644
--- a/gdb/sh-tdep.c
+++ b/gdb/sh-tdep.c
@@ -1976,28 +1976,6 @@  static const struct frame_unwind sh_frame_unwind = {
   default_frame_sniffer
 };
 
-static CORE_ADDR
-sh_unwind_sp (struct gdbarch *gdbarch, struct frame_info *next_frame)
-{
-  return frame_unwind_register_unsigned (next_frame,
-					 gdbarch_sp_regnum (gdbarch));
-}
-
-static CORE_ADDR
-sh_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame)
-{
-  return frame_unwind_register_unsigned (next_frame,
-					 gdbarch_pc_regnum (gdbarch));
-}
-
-static struct frame_id
-sh_dummy_id (struct gdbarch *gdbarch, struct frame_info *this_frame)
-{
-  CORE_ADDR sp = get_frame_register_unsigned (this_frame,
-					      gdbarch_sp_regnum (gdbarch));
-  return frame_id_build (sp, get_frame_pc (this_frame));
-}
-
 static CORE_ADDR
 sh_frame_base_address (struct frame_info *this_frame, void **this_cache)
 {
@@ -2308,9 +2286,6 @@  sh_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
   set_gdbarch_believe_pcc_promotion (gdbarch, 1);
 
   set_gdbarch_frame_align (gdbarch, sh_frame_align);
-  set_gdbarch_unwind_sp (gdbarch, sh_unwind_sp);
-  set_gdbarch_unwind_pc (gdbarch, sh_unwind_pc);
-  set_gdbarch_dummy_id (gdbarch, sh_dummy_id);
   frame_base_set_default (gdbarch, &sh_frame_base);
 
   set_gdbarch_stack_frame_destroyed_p (gdbarch, sh_stack_frame_destroyed_p);