diff mbox

[24/25] gdb/rl78: Use default gdbarch methods where possible

Message ID 0da38d6a7e027a236d1db7dc22fd0b54f32f2f77.1553721879.git.andrew.burgess@embecosm.com
State New, archived
Headers

Commit Message

Andrew Burgess March 27, 2019, 9:34 p.m. UTC 
  Make use of the default gdbarch method gdbarch_unwind_sp where
possible.

I have not tested this change but, by inspecting the code, I believe
the default methods are equivalent to the code being deleted.

gdb/ChangeLog:

	* rl78-tdep.c (rl78_unwind_sp): Delete.
	(rl78_gdbarch_init): Don't register deleted function with gdbarch.
---
 gdb/ChangeLog   | 5 +++++
 gdb/rl78-tdep.c | 9 ---------
 2 files changed, 5 insertions(+), 9 deletions(-)

Comments

Kevin Buettner March 27, 2019, 10:05 p.m. UTC | #1 
On Wed, 27 Mar 2019 21:34:20 +0000
Andrew Burgess <andrew.burgess@embecosm.com> wrote:

> gdb/ChangeLog:
> 
> 	* rl78-tdep.c (rl78_unwind_sp): Delete.
> 	(rl78_gdbarch_init): Don't register deleted function with gdbarch.

Okay.

Kevin
diff mbox

Patch

diff --git a/gdb/rl78-tdep.c b/gdb/rl78-tdep.c
index 52e52a40b9f..f66cda88179 100644
--- a/gdb/rl78-tdep.c
+++ b/gdb/rl78-tdep.c
@@ -1084,14 +1084,6 @@  rl78_unwind_pc (struct gdbarch *arch, struct frame_info *next_frame)
 	                                          RL78_PC_REGNUM));
 }
 
-/* Implement the "unwind_sp" gdbarch method.  */
-
-static CORE_ADDR
-rl78_unwind_sp (struct gdbarch *arch, struct frame_info *next_frame)
-{
-  return frame_unwind_register_unsigned (next_frame, RL78_SP_REGNUM);
-}
-
 /* Given a frame described by THIS_FRAME, decode the prologue of its
    associated function if there is not cache entry as specified by
    THIS_PROLOGUE_CACHE.  Save the decoded prologue in the cache and
@@ -1470,7 +1462,6 @@  rl78_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
   set_gdbarch_inner_than (gdbarch, core_addr_lessthan);
   set_gdbarch_skip_prologue (gdbarch, rl78_skip_prologue);
   set_gdbarch_unwind_pc (gdbarch, rl78_unwind_pc);
-  set_gdbarch_unwind_sp (gdbarch, rl78_unwind_sp);
   set_gdbarch_frame_align (gdbarch, rl78_frame_align);
 
   dwarf2_append_unwinders (gdbarch);