| Message ID | 87ftsfx567.fsf@linux.ibm.com |
|---|---|
| State | Committed |
| Delegated to: | H.J. Lu |
| Headers |
Received: (qmail 10102 invoked by alias); 22 Feb 2019 14:35:10 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 10085 invoked by uid 89); 22 Feb 2019 14:35:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1096, H*F:D*br, Hx-spam-relays-external:ESMTPA X-HELO: catfish.maple.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|tuliom@ascii.art.br X-MailChannels-Auth-Id: dreamhost X-Cooperative-Cure: 3b91f3f05e3eef0f_1550846100503_2855026301 X-MC-Loop-Signature: 1550846100503:1255460682 X-MC-Ingress-Time: 1550846100503 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=ascii.art.br; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=ascii.art.br; bh=L9nXdlH3M1LZA6cqEOGsK5qFUPs=; b= IpCxNEhSKv/5dAaXPOH0kgAro3qm5IMkOR9wuiP4sNmdqHaa7P4YYuUL7nFRHgK7 0jBNJTP5YDNih42mVc6+A/tz57jEaz9mVYPIfz92DM0JqY3lR85MLEVz/Gnkhzsh czarUKwbmmw3VQU8ZNNNZur659m7gnMRZfH6gzjf6Kc= X-DH-BACKEND: pdx1-sub0-mail-a70 From: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br> To: "H.J. Lu" <hjl.tools@gmail.com>, libc-alpha@sourceware.org Cc: Subject: Re: [PATCH] elf/Makefile: Run IFUNC tests if binutils supports IFUNC In-Reply-To: <20190220162903.13315-1-hjl.tools@gmail.com> References: <20190220162903.13315-1-hjl.tools@gmail.com> User-Agent: Notmuch/0.27 (http://notmuchmail.org) Emacs/25.3.1 (x86_64-redhat-linux-gnu) Date: Fri, 22 Feb 2019 11:34:56 -0300 Message-ID: <87ftsfx567.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedutddruddtgdeikecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefvuhhlihhoucforghgnhhoucfsuhhithgvshcuofgrtghhrgguohcuhfhilhhhohcuoehtuhhlihhomhesrghstghiihdrrghrthdrsghrqeenucfkphepfedvrddutdegrddukedrvdegfeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghloheprghstghiihdrrghrthdrsghrpdhinhgvthepfedvrddutdegrddukedrvdegfedprhgvthhurhhnqdhprghthhepvfhulhhiohcuofgrghhnohcusfhuihhtvghsucforggthhgrughoucfhihhlhhhouceothhulhhiohhmsegrshgtihhirdgrrhhtrdgsrheqpdhmrghilhhfrhhomhepthhulhhiohhmsegrshgtihhirdgrrhhtrdgsrhdpnhhrtghpthhtoheplhhisggtqdgrlhhphhgrsehsohhurhgtvgifrghrvgdrohhrghenucevlhhushhtvghrufhiiigvpedt |
Commit Message
Tulio Magno Quites Machado Filho
Feb. 22, 2019, 2:34 p.m. UTC
"H.J. Lu" <hjl.tools@gmail.com> writes: > We should run IFUNC tests with --disable-multi-arch if the toolchain > supports IFUNCs. For correctness, --disable-multi-arch must not > remove IFUNC support from the loader. > > Tested on x86-64, x32 and i686 with and without --disable-multi-arch. > > * configure.ac (have-ifunc): New LIBC_CONFIG_VAR. > * configure: Regenerated. > * elf/Makefile: Run IFUNC tests if binutils supports IFUNC. We should also change this powerpc test: Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Comments
On Fri, Feb 22, 2019 at 6:35 AM Tulio Magno Quites Machado Filho <tuliom@ascii.art.br> wrote: > > "H.J. Lu" <hjl.tools@gmail.com> writes: > > > We should run IFUNC tests with --disable-multi-arch if the toolchain > > supports IFUNCs. For correctness, --disable-multi-arch must not > > remove IFUNC support from the loader. > > > > Tested on x86-64, x32 and i686 with and without --disable-multi-arch. > > > > * configure.ac (have-ifunc): New LIBC_CONFIG_VAR. > > * configure: Regenerated. > > * elf/Makefile: Run IFUNC tests if binutils supports IFUNC. > > We should also change this powerpc test: > > diff --git a/sysdeps/powerpc/Makefile b/sysdeps/powerpc/Makefile > index bac5a3a73c..5c6ea0a95e 100644 > --- a/sysdeps/powerpc/Makefile > +++ b/sysdeps/powerpc/Makefile > @@ -14,7 +14,7 @@ mod-tlsopt-powerpc.so-no-z-defs = yes > tests += tst-tlsopt-powerpc > $(objpfx)tst-tlsopt-powerpc: $(objpfx)mod-tlsopt-powerpc.so > > -ifneq (no,$(multi-arch)) > +ifeq (yes,$(have-ifunc)) > tests-static += tst-tlsifunc-static > tests-internal += tst-tlsifunc-static > ifeq (yes,$(build-shared)) > > Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> > If all supported powerpc binutils have IFUNC, you can drop this test like x86.
"H.J. Lu" <hjl.tools@gmail.com> writes: > On Fri, Feb 22, 2019 at 6:35 AM Tulio Magno Quites Machado Filho > <tuliom@ascii.art.br> wrote: >> >> "H.J. Lu" <hjl.tools@gmail.com> writes: >> >> > We should run IFUNC tests with --disable-multi-arch if the toolchain >> > supports IFUNCs. For correctness, --disable-multi-arch must not >> > remove IFUNC support from the loader. >> > >> > Tested on x86-64, x32 and i686 with and without --disable-multi-arch. >> > >> > * configure.ac (have-ifunc): New LIBC_CONFIG_VAR. >> > * configure: Regenerated. >> > * elf/Makefile: Run IFUNC tests if binutils supports IFUNC. >> >> We should also change this powerpc test: >> >> diff --git a/sysdeps/powerpc/Makefile b/sysdeps/powerpc/Makefile >> index bac5a3a73c..5c6ea0a95e 100644 >> --- a/sysdeps/powerpc/Makefile >> +++ b/sysdeps/powerpc/Makefile >> @@ -14,7 +14,7 @@ mod-tlsopt-powerpc.so-no-z-defs = yes >> tests += tst-tlsopt-powerpc >> $(objpfx)tst-tlsopt-powerpc: $(objpfx)mod-tlsopt-powerpc.so >> >> -ifneq (no,$(multi-arch)) >> +ifeq (yes,$(have-ifunc)) >> tests-static += tst-tlsifunc-static >> tests-internal += tst-tlsifunc-static >> ifeq (yes,$(build-shared)) >> >> Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> >> > > If all supported powerpc binutils have IFUNC, you can drop this test > like x86. Indeed. I've modified build-many-glibcs to use Binutils 2.25 and confirmed that all powerpc builds there enable have-ifunc.
diff --git a/sysdeps/powerpc/Makefile b/sysdeps/powerpc/Makefile index bac5a3a73c..5c6ea0a95e 100644 --- a/sysdeps/powerpc/Makefile +++ b/sysdeps/powerpc/Makefile @@ -14,7 +14,7 @@ mod-tlsopt-powerpc.so-no-z-defs = yes tests += tst-tlsopt-powerpc $(objpfx)tst-tlsopt-powerpc: $(objpfx)mod-tlsopt-powerpc.so -ifneq (no,$(multi-arch)) +ifeq (yes,$(have-ifunc)) tests-static += tst-tlsifunc-static tests-internal += tst-tlsifunc-static ifeq (yes,$(build-shared))