gdb/testsuite: Don't allow paths to appear in test name

Message ID 20190111232953.20100-1-andrew.burgess@embecosm.com
State New, archived
Headers

Commit Message

Andrew Burgess Jan. 11, 2019, 11:29 p.m. UTC
  Having paths in the test names makes it harder to compare results
between two runs in different directories.  Give the test a name so
that the path doesn't appear.

gdb/ChangeLog:

	* gdb.base/style.exp: Don't include path in testname.
---
 gdb/testsuite/ChangeLog          | 4 ++++
 gdb/testsuite/gdb.base/style.exp | 1 +
 2 files changed, 5 insertions(+)
  

Comments

Tom Tromey Jan. 12, 2019, 3:37 a.m. UTC | #1
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> Having paths in the test names makes it harder to compare results
Andrew> between two runs in different directories.  Give the test a name so
Andrew> that the path doesn't appear.

Andrew> gdb/ChangeLog:

Andrew> 	* gdb.base/style.exp: Don't include path in testname.

Thanks, this is ok.

Tom
  

Patch

diff --git a/gdb/testsuite/gdb.base/style.exp b/gdb/testsuite/gdb.base/style.exp
index 268f8018cd9..78d04b02903 100644
--- a/gdb/testsuite/gdb.base/style.exp
+++ b/gdb/testsuite/gdb.base/style.exp
@@ -54,4 +54,5 @@  save_vars { env(TERM) } {
     set quoted [string_to_regexp $binfile]
     gdb_test "file $binfile" \
 	"Reading symbols from \033\\\[32m${quoted}\033\\\[m..." \
+	"filename is styled when loading symbol file"
 }