Message ID | 20181020183429.21188-1-tom@tromey.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 29276 invoked by alias); 20 Oct 2018 18:34:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 29264 invoked by uid 89); 20 Oct 2018 18:34:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1073, oddity, modifying, day X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 20 Oct 2018 18:34:37 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 418D16F5C for <gdb-patches@sourceware.org>; Sat, 20 Oct 2018 13:34:36 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Dw56gZNAyRPojDw56gpP7t; Sat, 20 Oct 2018 13:34:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version :Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZVw0ELu/r57G9qjwCE1cQIb+XszcvX4EGJPLOHvWB0U=; b=l9sA8cmMfWQDDArvWaChRzZodF Zhu2Bw7srs0POEc+lrshFaEJ3+eyN7SCrfGgme6zdsqvV3sGz3Oqn+es1V2rh8adKDk1PN4KCWLVv Rh2GQZTTTkuh/5swjyzVUlRYo; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:52174 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from <tom@tromey.com>) id 1gDw56-0044ty-18; Sat, 20 Oct 2018 13:34:36 -0500 From: Tom Tromey <tom@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey <tom@tromey.com> Subject: [RFC] Make "all" depend on "info" Date: Sat, 20 Oct 2018 12:34:29 -0600 Message-Id: <20181020183429.21188-1-tom@tromey.com> |
Commit Message
Tom Tromey
Oct. 20, 2018, 6:34 p.m. UTC
I've broken "make info" a couple of times now, because I sometimes forget to run "make info" after modifying a Texinfo file. I don't know why gdb's "make all" doesn't build the info pages. I suspect this was some Cygnus-local oddity back in the day. This patch changes doc/Makefile.in so that the info pages are built by "make all". As a point of reference, Automake has essentially always worked this way. According to the Automake manual (I didn't double-check) this is required by the GNU coding standards. gdb/doc/ChangeLog 2018-10-20 Tom Tromey <tom@tromey.com> * Makefile.in (all): Depend on "info". --- gdb/doc/ChangeLog | 4 ++++ gdb/doc/Makefile.in | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)
Comments
On 2018-10-20 14:34, Tom Tromey wrote: > I've broken "make info" a couple of times now, because I sometimes > forget to run "make info" after modifying a Texinfo file. > > I don't know why gdb's "make all" doesn't build the info pages. I > suspect this was some Cygnus-local oddity back in the day. > > This patch changes doc/Makefile.in so that the info pages are built by > "make all". As a point of reference, Automake has essentially always > worked this way. According to the Automake manual (I didn't > double-check) this is required by the GNU coding standards. IIRC, another weird consequence of the current situation is that if you do ./configure && make && sudo make install, the doc artifacts will be generated during make install, so owned by root. I believe everything should be generated by "make", and make install should only install the files in the prefix. Simon
On Sat, 20 Oct 2018 12:34:29 -0600 Tom Tromey <tom@tromey.com> wrote: > I've broken "make info" a couple of times now, because I sometimes > forget to run "make info" after modifying a Texinfo file. > > I don't know why gdb's "make all" doesn't build the info pages. I > suspect this was some Cygnus-local oddity back in the day. > > This patch changes doc/Makefile.in so that the info pages are built by > "make all". As a point of reference, Automake has essentially always > worked this way. According to the Automake manual (I didn't > double-check) this is required by the GNU coding standards. > > gdb/doc/ChangeLog > 2018-10-20 Tom Tromey <tom@tromey.com> > > * Makefile.in (all): Depend on "info". I'm in favor of this change. Kevin
On Saturday, October 20 2018, Tom Tromey wrote: > I've broken "make info" a couple of times now, because I sometimes > forget to run "make info" after modifying a Texinfo file. > > I don't know why gdb's "make all" doesn't build the info pages. I > suspect this was some Cygnus-local oddity back in the day. > > This patch changes doc/Makefile.in so that the info pages are built by > "make all". As a point of reference, Automake has essentially always > worked this way. According to the Automake manual (I didn't > double-check) this is required by the GNU coding standards. I think it makes sense, especially because "info" the default documentation format for GNU. I was wondering if it would also make sense to build the documentation on the BuildBot. > gdb/doc/ChangeLog > 2018-10-20 Tom Tromey <tom@tromey.com> > > * Makefile.in (all): Depend on "info". > --- > gdb/doc/ChangeLog | 4 ++++ > gdb/doc/Makefile.in | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in > index 0323bc4ecb..4e167d59cf 100644 > --- a/gdb/doc/Makefile.in > +++ b/gdb/doc/Makefile.in > @@ -182,7 +182,7 @@ HAVE_NATIVE_GCORE_TARGET = @HAVE_NATIVE_GCORE_TARGET@ > > ### > > -all: > +all: info > > info: $(INFO_DEPS) > dvi: gdb.dvi stabs.dvi refcard.dvi annotate.dvi > -- > 2.17.1
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> This patch changes doc/Makefile.in so that the info pages are built by
Tom> "make all". As a point of reference, Automake has essentially always
Tom> worked this way. According to the Automake manual (I didn't
Tom> double-check) this is required by the GNU coding standards.
I haven't checked this in yet, because I remembered there are a number
of bugs in bugzilla from users who don't have (and maybe also don't
want) makeinfo installed. So, I thought I'd hold off on this until I
find the time to come up with a solution for them.
Tom
diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in index 0323bc4ecb..4e167d59cf 100644 --- a/gdb/doc/Makefile.in +++ b/gdb/doc/Makefile.in @@ -182,7 +182,7 @@ HAVE_NATIVE_GCORE_TARGET = @HAVE_NATIVE_GCORE_TARGET@ ### -all: +all: info info: $(INFO_DEPS) dvi: gdb.dvi stabs.dvi refcard.dvi annotate.dvi