diff mbox

x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458]

Message ID 20180727203837.11828-1-hjl.tools@gmail.com
State New, archived
Headers

Commit Message

H.J. Lu July 27, 2018, 8:38 p.m. UTC 
  All tests should be added to $(tests) and all static tests should be
added to $(tests-static).

	[BZ #23458]
	* sysdeps/x86/Makefile (tests): Add tst-get-cpu-features-static.
---
 sysdeps/x86/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Florian Weimer July 27, 2018, 9:14 p.m. UTC | #1 
On 07/27/2018 10:38 PM, H.J. Lu wrote:
> -tests += tst-get-cpu-features
> +# NB: All tests should be added to $(tests) and all static tests should
> +# be added to $(tests-static).
> +tests += tst-get-cpu-features tst-get-cpu-features-static

Why the comment?  What makes this instance so special to warrant one?

Thanks,
Florian
H.J. Lu July 27, 2018, 9:41 p.m. UTC | #2 
On Fri, Jul 27, 2018 at 2:14 PM, Florian Weimer <fweimer@redhat.com> wrote:
> On 07/27/2018 10:38 PM, H.J. Lu wrote:
>>
>> -tests += tst-get-cpu-features
>> +# NB: All tests should be added to $(tests) and all static tests should
>> +# be added to $(tests-static).
>> +tests += tst-get-cpu-features tst-get-cpu-features-static
>
>
> Why the comment?  What makes this instance so special to warrant one?
>

I can take out the comment.
diff mbox

Patch

diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile
index 672bb19489..85086b1410 100644
--- a/sysdeps/x86/Makefile
+++ b/sysdeps/x86/Makefile
@@ -5,7 +5,9 @@  endif
 ifeq ($(subdir),elf)
 sysdep-dl-routines += dl-get-cpu-features
 
-tests += tst-get-cpu-features
+# NB: All tests should be added to $(tests) and all static tests should
+# be added to $(tests-static).
+tests += tst-get-cpu-features tst-get-cpu-features-static
 tests-static += tst-get-cpu-features-static
 endif