default_type_align: Use type_length_units
Commit Message
On 2018-06-14 03:50 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> This use seems related to C++, and our compiler is C only, so I can't
> Simon> test that. But it would make sense, I can include that change if you
> Simon> prefer.
>
> Yeah, I think it would be best to either change both or change neither
> (and update the comment).
Here's what I pushed. However, I parsed the "and update the comment" of your reply
after pushing. Which comment did you want me to update?
Simon
From 55c748a1c01f33cec0f762969db1bae457e8bcca Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Thu, 14 Jun 2018 18:23:39 -0400
Subject: [PATCH] type alignment: Use type_length_units
The type alignment value is returned in 8-bit-bytes instead of target
memory addressable units. For example, on a target with 16-bit-bytes
where sizeof(int) == 1 (one addressable unit), alignof(int) currently
returns 2. After, this patch, it returns 1.
gdb/ChangeLog:
* arch-utils.c (default_type_align): Use type_length_units.
* gdbtypes.c (type_align): Use type_length_units.
---
gdb/ChangeLog | 5 +++++
gdb/arch-utils.c | 2 +-
gdb/gdbtypes.c | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
Comments
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> Here's what I pushed. However, I parsed the "and update the comment" of your reply
Simon> after pushing. Which comment did you want me to update?
Sorry that was unclear -- I meant if you decided not to use
type_length_units, then update the comment in gdbtypes.h to follow.
But, since you did do the type_length_units change, that's not relevant.
Thanks for fixing this btw.
Tom
@@ -1,3 +1,8 @@
+2018-06-14 Simon Marchi <simon.marchi@ericsson.com>
+
+ * arch-utils.c (default_type_align): Use type_length_units.
+ * gdbtypes.c (type_align): Use type_length_units.
+
2018-06-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* cli/cli-script.c (_initialize_cli_script): Fix online documentation
@@ -994,7 +994,7 @@ default_in_indirect_branch_thunk (gdbarch *gdbarch, CORE_ADDR pc)
ULONGEST
default_type_align (struct gdbarch *gdbarch, struct type *type)
{
- return TYPE_LENGTH (check_typedef (type));
+ return type_length_units (check_typedef (type));
}
void
@@ -3072,7 +3072,7 @@ type_align (struct type *type)
case TYPE_CODE_METHODPTR:
case TYPE_CODE_MEMBERPTR:
- align = TYPE_LENGTH (type);
+ align = type_length_units (type);
break;
case TYPE_CODE_VOID: