diff mbox

Remove struct keyword from section_addr_info

Message ID 20180323203608.8939-1-keiths@redhat.com
State New, archived
Headers

Commit Message

Keith Seitz March 23, 2018, 8:36 p.m. UTC 
  Buildbot pointed out a failiure in windows-nat.c:

../../binutils-gdb/gdb/windows-nat.c:582:10: error: using typedef-name 'section_addr_info' after 'struct'
   struct section_addr_info *addrs;
          ^~~~~~~~~~~~~~~~~
In file included from ../../binutils-gdb/gdb/windows-nat.c:49:0:
../../binutils-gdb/gdb/symfile.h:75:37: note: 'section_addr_info' has a previous declaration here
 typedef std::vector<other_sections> section_addr_info;
                                     ^~~~~~~~~~~~~~~~~

A recursive grep of the sources for "struct section_addr_info" reveals one
additional reference in a comment.  In both cases, this patch simply removes
the struct keyword.

gdb/ChangeLog:

	* symfile.c (place_section): Remove "struct" from section_addr_info
	in comment.
	* windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Likewise.
---
 gdb/ChangeLog     | 6 ++++++
 gdb/symfile.c     | 2 +-
 gdb/windows-nat.c | 2 +-
 3 files changed, 8 insertions(+), 2 deletions(-)

Comments

Simon Marchi March 24, 2018, 2:45 a.m. UTC | #1 
On 2018-03-23 04:36 PM, Keith Seitz wrote:
> Buildbot pointed out a failiure in windows-nat.c:
> 
> ../../binutils-gdb/gdb/windows-nat.c:582:10: error: using typedef-name 'section_addr_info' after 'struct'
>    struct section_addr_info *addrs;
>           ^~~~~~~~~~~~~~~~~
> In file included from ../../binutils-gdb/gdb/windows-nat.c:49:0:
> ../../binutils-gdb/gdb/symfile.h:75:37: note: 'section_addr_info' has a previous declaration here
>  typedef std::vector<other_sections> section_addr_info;
>                                      ^~~~~~~~~~~~~~~~~
> 
> A recursive grep of the sources for "struct section_addr_info" reveals one
> additional reference in a comment.  In both cases, this patch simply removes
> the struct keyword.
> 
> gdb/ChangeLog:
> 
> 	* symfile.c (place_section): Remove "struct" from section_addr_info
> 	in comment.
> 	* windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Likewise.

The "Likewise" is not really accurate, since the second entry isn't changing
a comment like the first one.  But otherwise LGTM (I would have considered it
as pretty obvious).

Simon
Keith Seitz March 26, 2018, 5:39 p.m. UTC | #2 
On 03/23/2018 07:45 PM, Simon Marchi wrote:
>> 	* symfile.c (place_section): Remove "struct" from section_addr_info
>> 	in comment.
>> 	* windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Likewise.
> 
> The "Likewise" is not really accurate, since the second entry isn't changing
> a comment like the first one.  But otherwise LGTM (I would have considered it
> as pretty obvious).

Bah, I can't believe I did that. I've edited the ChangeLog and pushed the patch.

Keith
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b543904db2..70d182d624 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@ 
+2018-MM-DD  Keith Seitz  <keiths@redhat.com>
+
+	* symfile.c (place_section): Remove "struct" from section_addr_info
+	in comment.
+	* windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Likewise.
+
 2018-03-23  Keith Seitz  <keiths@redhat.com>
 
 	PR c++/22968
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 9571664776..1e5297ee29 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -412,7 +412,7 @@  place_section (bfd *abfd, asection *sect, void *obj)
   arg->lowest = start_addr + bfd_get_section_size (sect);
 }
 
-/* Store struct section_addr_info as prepared (made relative and with SECTINDEX
+/* Store section_addr_info as prepared (made relative and with SECTINDEX
    filled-in) by addr_info_make_relative into SECTION_OFFSETS of NUM_SECTIONS
    entries.  */
 
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index f849f1f322..430cc60993 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -579,7 +579,7 @@  struct safe_symbol_file_add_args
 {
   char *name;
   int from_tty;
-  struct section_addr_info *addrs;
+  section_addr_info *addrs;
   int mainline;
   int flags;
   struct ui_file *err, *out;